The PStmtKey class keys off of a SQL statement, catalog but not the schema.
Since a catalog is usually a collection of schema, shouldn't we use the
schema as part of this key?
(Java 7 added supported for getSchema() on a Connection.)
Gary
Dang it!
On Tue, Jun 19, 2018 at 6:05 PM sebb wrote:
> There are some errors in this announce:
>
> The subject has a spelling error: ANNOUCEMENT => ANNOUNCEMENT
>
> Also the end of the email seems to be missing, as there is no link to
> the DBCP website
>
> S.
> On 19 June 2018 at 22:44, Gary G
There are some errors in this announce:
The subject has a spelling error: ANNOUCEMENT => ANNOUNCEMENT
Also the end of the email seems to be missing, as there is no link to
the DBCP website
S.
On 19 June 2018 at 22:44, Gary Gregory wrote:
> The Apache Commons DBCP team is pleased to announce th
To be clear:
DBCP 2.4.0 - Java 7 - JDBC 4.1 (just released)
DBCP 2.5.0 or 3.0.0 - Java 8 - JDBC 4.2 (in git master)
DBCP 2.6.0 or 4.0.0 - Java 9 - JDBC 4.3 (to do)
Thoughts?
Gary
On Tue, Jun 19, 2018 at 2:28 PM Gary Gregory wrote:
> I have no API breaking changes for 3.0, so I do not s
I have no API breaking changes for 3.0, so I do not see a need for a major
version change. Feedback welcome. I am more interested in getting the next
version out to pick up the new methods from JDBC 4.2 on Java 8.
Gary
On Tue, Jun 19, 2018, 13:49 Matt Sicker wrote:
> Bumping to 3.0 could allow
Bumping to 3.0 could allow for adopting lessons from other connection pool
libraries in API incompatible ways. I have no specific examples, but
HikariCP is a general one.
On 19 June 2018 at 14:27, Jochen Wiedmann wrote:
> On Sun, Jun 17, 2018 at 2:42 PM Gary Gregory
> wrote:
>
> > 3.0.0 somewha
On Sun, Jun 17, 2018 at 2:42 PM Gary Gregory wrote:
> 3.0.0 somewhat implies API breakage which has not happened yet so 2.5.0 is
> better for now IMO...
+1 for going to 3.0.0 anyways. This would perhaps fix the problem for
Tomcat, assuming that we keep a maintenance branch for 2.x.
Jochen
OK, I think I'll roll an RC for Commons Pool soon, which I've been wanting
to do anyway.
Gary
On Tue, Jun 19, 2018 at 9:16 AM Mark Thomas wrote:
> On 19/06/18 16:03, Gary Gregory wrote:
> > What is odd is that you've added generics to places where there are none.
>
> Ah. Found it. My local DBCP
On 19/06/18 16:03, Gary Gregory wrote:
> What is odd is that you've added generics to places where there are none.
Ah. Found it. My local DBCP workspace depends on the local Pool
workspace rather than the 2.5.0 release. I was picking up genrics
changes that will be in the next pool release and ada
What is odd is that you've added generics to places where there are none.
Gary
On Tue, Jun 19, 2018 at 8:42 AM Mark Thomas wrote:
> On 19 June 2018 15:23:52 BST, Gary Gregory wrote:
> >Mark,
> >
> >I'm not sure what compiler you are using, but these changes break the
> >build
> >in Jenkins, in
On 19 June 2018 15:23:52 BST, Gary Gregory wrote:
>Mark,
>
>I'm not sure what compiler you are using, but these changes break the
>build
>in Jenkins, in my local Eclipse workspace, and with Maven and Orcale
>Java
>8. Please fix:
Odd. I'm using Eclipse and Java 8 and was seeing generics warnings b
Mark,
I'm not sure what compiler you are using, but these changes break the build
in Jenkins, in my local Eclipse workspace, and with Maven and Orcale Java
8. Please fix:
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/vcs/git/apache/co
> On Jun 19, 2018, at 3:53 AM, Gilles wrote:
>
> The link
> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.3-RC1
> returns a "404" error.
>
I did the release promotion at 2300 (UTC-4).
-Rob
> Regards,
> Gilles
>
>> On Mon, 18 Jun 2018 22:39:32 -0400, Rob Tompkin
The link
https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.3-RC1
returns a "404" error.
Regards,
Gilles
On Mon, 18 Jun 2018 22:39:32 -0400, Rob Tompkins wrote:
Here’s my +1
On Jun 15, 2018, at 12:45 PM, Rob Tompkins
wrote:
We have fixed quite a few bugs and added
14 matches
Mail list logo