Re: [release-plugin] commit failure con't

2018-06-13 Thread Rob Tompkins
> On Jun 13, 2018, at 7:22 PM, Gary Gregory wrote: > > Looking at http://svnbook.red-bean.com/en/1.8/svn.ref.svn.c.add.html, it > seems we can just do a SCM add of the three folders (binaries, source, > site) instead of each file in those folders. > > Thoughts? I’ll give that a shot first th

Re: [DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-13 Thread Gary Gregory
The RC is out. Please review it :-) Gary On Tue, Jun 12, 2018, 15:49 Gary Gregory wrote: > After fixing prepared statements in the cpdsadapter package, I found a > cleaner solution that delegates all prepared and callable statement pooling > to DBCP's cpdsadapter. > > Thank you for the feedback

Re: [release-plugin] commit failure con't

2018-06-13 Thread Gary Gregory
Looking at http://svnbook.red-bean.com/en/1.8/svn.ref.svn.c.add.html, it seems we can just do a SCM add of the three folders (binaries, source, site) instead of each file in those folders. Thoughts? Gary On Wed, Jun 13, 2018 at 5:17 PM Gary Gregory wrote: > Rob, > > In our code, we have: > > n

[release-plugin] commit failure con't

2018-06-13 Thread Gary Gregory
Rob, In our code, we have: new ScmFileSet(distCheckoutDirectory, filesToCommit); The Javadoc for ScmFileSet says that the filesToCommit list must be _relative_ to the base dir in distCheckoutDirectory. For example, in our tests distCheckoutDirectory is: target\testing-commons-release-plugin\sc

Re: [release-plugin][build-plugin] Java 8

2018-06-13 Thread Pascal Schumacher
+1 Am 13.06.2018 um 23:07 schrieb Gary Gregory: I propose we make our release-plugin require Java 8. Newer dependencies like the latest Checkstyle require Java 8. Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apach

Re: [release-plugin][build-plugin] Java 8

2018-06-13 Thread Rob Tompkins
> On Jun 13, 2018, at 5:07 PM, Gary Gregory wrote: > > I propose we make our release-plugin require Java 8. Newer dependencies > like the latest Checkstyle require Java 8. +1 > > Gary - To unsubscribe, e-mail: dev-unsubscr

Re: [apache/commons-release-plugin] Update Checkstyle 6.19 -> 8.10.1. OK: mvn clean site (13210c7)

2018-06-13 Thread Rob Tompkins
> On Jun 13, 2018, at 4:39 PM, Gary Gregory wrote: > > It we should just make the plugin require Java 8. > Seems reasonable to me. > Gary > > On Wed, Jun 13, 2018 at 1:27 PM Pascal Schumacher > wrote: > >> But travis build fails with >> >> [WARNING] Error injecting: >> org.apache.maven

[release-plugin][build-plugin] Java 8

2018-06-13 Thread Gary Gregory
I propose we make our release-plugin require Java 8. Newer dependencies like the latest Checkstyle require Java 8. Gary

Re: [apache/commons-release-plugin] Update Checkstyle 6.19 -> 8.10.1. OK: mvn clean site (13210c7)

2018-06-13 Thread Gary Gregory
It we should just make the plugin require Java 8. Gary On Wed, Jun 13, 2018 at 1:27 PM Pascal Schumacher wrote: > But travis build fails with > > [WARNING] Error injecting: > org.apache.maven.plugins.checkstyle.CheckstyleViolationCheckMojo > java.lang.UnsupportedClassVersionError: > com/puppycr

[VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-13 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.3.0 was released, so I would like to release Apache Commons DBCP 2.4.0. Apache Commons DBCP 2.4.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (

[GitHub] commons-collections issue #43: Javadoc fixes

2018-06-13 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/43 [![Coverage Status](https://coveralls.io/builds/17475056/badge)](https://coveralls.io/builds/17475056) Coverage increased (+0.007%) to 87.393% when pulling **5e44c8e3d79ec

[GitHub] commons-collections pull request #43: Javadoc fixes

2018-06-13 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/43 Javadoc fixes Multiple small Javadoc fixes for obvious mistakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collect

Re: [release-plugin] fail on dist

2018-06-13 Thread Gary Gregory
On Wed, Jun 13, 2018 at 12:52 PM Rob Tompkins wrote: > > > > On Jun 13, 2018, at 2:21 PM, Gary Gregory > wrote: > > > > Hi Rob, > > > > I just tried to use the release plugin and I am getting this problem > > (again?). > > > > Is there a workaround? > > > > mvn -Dcommons.release-plugin.version=1

Re: [release-plugin] fail on dist

2018-06-13 Thread Rob Tompkins
> On Jun 13, 2018, at 2:21 PM, Gary Gregory wrote: > > Hi Rob, > > I just tried to use the release plugin and I am getting this problem > (again?). > > Is there a workaround? > > mvn -Dcommons.release-plugin.version=1.3-SNAPSHOT -Prelease clean package > site deploy The main work around wo

[release-plugin] fail on dist

2018-06-13 Thread Gary Gregory
Hi Rob, I just tried to use the release plugin and I am getting this problem (again?). Is there a workaround? mvn -Dcommons.release-plugin.version=1.3-SNAPSHOT -Prelease clean package site deploy [INFO] --- commons-release-plugin:1.3-SNAPSHOT:stage-distributions (stage-distributions) @ commons-

[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-06-13 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/42 [![Coverage Status](https://coveralls.io/builds/17473023/badge)](https://coveralls.io/builds/17473023) Coverage remained the same at 87.386% when pulling **2a9a1105428fc37

[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...

2018-06-13 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/42 Fix for 5 CheckStyle 3.0.0 plugin warnings. Fixed 5 CheckStyle warnings. There are still 11 warnings left which are false positive (JavadocMethod Unable to get class informati

Re: commons-release-plugin git commit: (rat) update excludes for test artifacts

2018-06-13 Thread Rob Tompkins
Yeah…saw that. Thoughts on those? I don’t know if it matters or not, given that those artifacts are actually released artifacts. -Rob > On Jun 13, 2018, at 12:55 PM, Gary Gregory wrote: > > Almost ;-) > > Files with unapproved licenses: > > > src/test/resources/mojos/detach-distributions/ta

Re: commons-release-plugin git commit: (rat) update excludes for test artifacts

2018-06-13 Thread Gary Gregory
Almost ;-) Files with unapproved licenses: src/test/resources/mojos/detach-distributions/target/commons-text-1.4-bin.tar.gz.asc src/test/resources/mojos/detach-distributions/target/commons-text-1.4-bin.zip.asc src/test/resources/mojos/detach-distributions/target/commons-text-1.4-javadoc.jar.as

Re: commons-release-plugin git commit: (fix) uniquely identify hashes in sha256 and sha1 artifact maps

2018-06-13 Thread Rob Tompkins
@Gary - I think this will fix the problem. -ROb > On Jun 13, 2018, at 12:39 PM, chtom...@apache.org wrote: > > Repository: commons-release-plugin > Updated Branches: > refs/heads/master 3b775f6f6 -> 812ea8f51 > > > (fix) uniquely identify hashes in sha256 and sha1 artifact maps > > > Projec

Re: [release-plugin] No longer publish MD5 files to Apache's dev and release folders.

2018-06-13 Thread Rob Tompkins
It seems that this does not carry sufficient specificity for uniquely identifying the artifact: https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L164-L166

Re: [release-plugin] No longer publish MD5 files to Apache's dev and release folders.

2018-06-13 Thread Gary Gregory
Note that I fixed the SHA-1 and SHA-256 files in SVN. Gary On Wed, Jun 13, 2018 at 9:45 AM Rob Tompkins wrote: > We don’t create the .md5 files that reside in nexus, it does when the > build get’s pushed up. So no concern there. Regarding the signatures, those > seem to be the ones from the -sr

Re: [release-plugin] No longer publish MD5 files to Apache's dev and release folders.

2018-06-13 Thread Rob Tompkins
We don’t create the .md5 files that reside in nexus, it does when the build get’s pushed up. So no concern there. Regarding the signatures, those seem to be the ones from the -src artifacts. Reading more closely to see where that happened. Thinking about checking in text-1.4 to the unit tests an

[release-plugin] No longer publish MD5 files to Apache's dev and release folders.

2018-06-13 Thread Gary Gregory
Rob, While Nexus still uses MD5 files, we should no longer publish MD5 files to Apache's dev and release folders. I manually deleted the ones for Commons Text just now, which leaves us with SHA-1 and SHA-256. Gary

Re: svn commit: r27426 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/

2018-06-13 Thread Rob Tompkins
Correct, I’m testing the release plugin adding the directories first before any of the sub-files. I think I’m getting weird parent-child commit failures in the svn mechanics. > On Jun 13, 2018, at 11:19 AM, Gary Gregory wrote: > > Hi Rob, > > Shouldn't the release plugin should do that? After

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Rob Tompkins
Agreed, that what I’m testing with to distinguish it from a real release staging event. > On Jun 13, 2018, at 11:20 AM, Gary Gregory wrote: > > We should not have a "-SNAPSHOT" in the folder names for RCs I do not think. > > Gary > > On Wed, Jun 13, 2018 at 9:16 AM wrote: > >> Author: chtom

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Gary Gregory
We should not have a "-SNAPSHOT" in the folder names for RCs I do not think. Gary On Wed, Jun 13, 2018 at 9:16 AM wrote: > Author: chtompki > Date: Wed Jun 13 15:16:43 2018 > New Revision: 27427 > > Log: > Adding release directories: commons-lang3, version: 3.8-SNAPSHOT > > Added: > dev/com

Re: svn commit: r27426 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/

2018-06-13 Thread Gary Gregory
Hi Rob, Shouldn't the release plugin should do that? After a release, I usually just blow away the whole dev folder, sub-folders and all. Gary On Wed, Jun 13, 2018 at 9:16 AM wrote: > Author: chtompki > Date: Wed Jun 13 15:16:41 2018 > New Revision: 27426 > > Log: > Adding release directories:

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Rob Tompkins
Been debugging committing everything for a few days now. Pardon if there are commits that periodically happen. > On Jun 13, 2018, at 11:16 AM, chtom...@apache.org wrote: > > Author: chtompki > Date: Wed Jun 13 15:16:43 2018 > New Revision: 27427 > > Log: > Adding release directories: commons-la

[REPORT] Apache Commons June 2018

2018-06-13 Thread Gary Gregory
## Description: - Apache Commons is an Apache project focused on all aspects of reusable Java components. ## Issues: - There are no issues requiring board attention at this time. ## Activity: - Activity is medium with the release of 4 components and 4 internal components. ## Health report: -

Re: [ALL][DRAFT] Board report

2018-06-13 Thread Matt Benson
Fwiw, [weaver] will also be released in the near future, and will be reported as being the primary remaining blocker for Apache BVal 2.0. Matt On Wed, Jun 13, 2018, 12:27 AM Gilles wrote: > Hello. > > On Tue, 12 Jun 2018 16:11:30 -0600, Gary Gregory wrote: > > Thank you for your review Gilles (