Re: [DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-07 Thread Gary Gregory
Thanks for your feedback Mark. Looking deeper into DBCP for a cleaner solution, it seems we are missing support for preparing callable statements in org.apache.commons.dbcp2.cpdsadapter.ConnectionImpl and org.apache.commons.dbcp2.cpdsadapter.PooledConnectionImpl. I see APIs implemented for prepare

Re: [DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-07 Thread Mark Thomas
On 07/06/18 17:18, Matt Sicker wrote: > This sounds like an honest bug that should be fixed, backwards > compatibility be damned. I don't see how the old behavior is useful for > anything other than connection starvation or some other strange behavior. I have completely the opposite view. There i

Re: [DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-07 Thread Matt Sicker
This sounds like an honest bug that should be fixed, backwards compatibility be damned. I don't see how the old behavior is useful for anything other than connection starvation or some other strange behavior. On 7 June 2018 at 10:44, Gary Gregory wrote: > Hi All: > > I just ran into a case where

Re: [RNG] Release v1.1 without the examples? (Was: [rng] japicmp failure)

2018-06-07 Thread Rob Tompkins
> On Jun 7, 2018, at 11:26 AM, Gilles wrote: > >> On Thu, 7 Jun 2018 10:49:28 -0400, Rob Tompkins wrote: >> I’m a +0 for not using japicmp because of its issues. We do need >> another [parent] release because of the japicmp skip availability in >> 0.12.0. I’d like to get the [release-plugin] u

[DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-07 Thread Gary Gregory
Hi All: I just ran into a case where different instances of subclasses of DelegatingConnection like PoolGuardConnectionWrapper and ConnectionImpl are used as keys in a Map (Map) The problem is that when you borrow a Connection out of a pool, you get a new PoolGuardConnectionWrapper, so that the M

Re: [RNG] Release v1.1 without the examples? (Was: [rng] japicmp failure)

2018-06-07 Thread Gilles
On Thu, 7 Jun 2018 10:49:28 -0400, Rob Tompkins wrote: I’m a +0 for not using japicmp because of its issues. We do need another [parent] release because of the japicmp skip availability in 0.12.0. I’d like to get the [release-plugin] up to snuff before going out though. Is [rng] ready to go for

Re: [RNG] Release v1.1 without the examples? (Was: [rng] japicmp failure)

2018-06-07 Thread Rob Tompkins
I’m a +0 for not using japicmp because of its issues. We do need another [parent] release because of the japicmp skip availability in 0.12.0. I’d like to get the [release-plugin] up to snuff before going out though. Is [rng] ready to go for 1.1? If so, I can try to roll an RC for you. -Rob >

[All] Release alternative CP without "japicmp"?

2018-06-07 Thread Gilles
Hi. Am I correct that "japicmp" has a bug that make it run, even if not requested by the config (or a profile-triggering file)? If so, wouldn't it be possible to have a commons-parent (with all the current features) that would just not refer to the plugin at all? Regards, Gilles --

[RNG] Release v1.1 without the examples? (Was: [rng] japicmp failure)

2018-06-07 Thread Gilles
Hello. The failure is triggered when including the "examples" module. [Reminder: "japicmp" seems to complain about the absence of an earlier version.] Thus, I'm contemplating to release v1.1 without the offending module. Any objection to my preparing a RC on that basis? Regards, Gilles -

[GitHub] asfgit closed pull request #5: README files

2018-06-07 Thread GitBox
asfgit closed pull request #5: README files URL: https://github.com/apache/commons-geometry/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), t