[GitHub] darkma773r opened a new pull request #2: GEOMETRY-2: Points and Vectors API Updates

2018-05-20 Thread GitBox
darkma773r opened a new pull request #2: GEOMETRY-2: Points and Vectors API Updates URL: https://github.com/apache/commons-geometry/pull/2 The main driver behind these changes was to try to clean up the API as it relates to points and vectors. The interfaces did not allow enough informatio

[GitHub] commons-fileupload issue #14: Add missing @Override annotations

2018-05-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-fileupload/pull/14 [![Coverage Status](https://coveralls.io/builds/17079238/badge)](https://coveralls.io/builds/17079238) Coverage remained the same at 77.177% when pulling **6377a58148c7a24d

[GitHub] commons-fileupload pull request #14: Add missing @Override annotations

2018-05-20 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/14 Add missing @Override annotations @Override annotations help to detect architectural errors and respond quicker to method changes. Unclear why the checkstyle configuration whic

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

2018-05-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-fileupload/pull/13 [![Coverage Status](https://coveralls.io/builds/17079215/badge)](https://coveralls.io/builds/17079215) Coverage remained the same at 77.177% when pulling **77d68a7ce0d15c05

[GitHub] commons-fileupload pull request #13: FileItem.java: remove throwing of Excep...

2018-05-20 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/13 FileItem.java: remove throwing of Exception Indicating that an interface method throws Exception is overly broad and hides design issues after inheritance changes. You can merge t

Re: [collections] Null-safe addAll(final Collection collection, final C... elements) [WAS] CollectionUtils not null-safe

2018-05-20 Thread Dave Brosius
I'd be much moreĀ  happy it the method was added, as something like safeAddAll so you knew when you were using it, but i agree then your api starts to bloat pretty badly. CollectionUtils.isEmpty checking for null makes sense. You are explicitly using the method to check for null as a conditi

[collections] Null-safe addAll(final Collection collection, final C... elements) [WAS] CollectionUtils not null-safe

2018-05-20 Thread Gary Gregory
Shall we do this in a more pragmatic fashion? One method at a time. Let's start with changing: /** * Adds all elements in the array to the given collection. * * @param the type of object the {@link Collection} contains * @param collection the collection to add to, must n

Re: [Numbers] More modules (Was: [Statistics] Port codes from Commons Math)

2018-05-20 Thread Gimhana Nadeeshan
Hi Gilles, [1] https://markmail.org/message/x6ng4ao62jjbj763 > Ok sure I'll try those out and ask here when I need support. while for "Commons Statistics" I > don't want to enter an open-ended discussion on how to improve the design > without the involvment of users of the "Commons Math" stat c

Re: [Statistics] Port codes from Commons Math

2018-05-20 Thread Gimhana Nadeeshan
Hi all, Porting *Interval Module * JIRA SUB-TASK : Interval Module Porting DESCRIPTION : Porting and Redesign Module Architecture from Classes at Commons.Math4.stat.Interval