[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 Great! @kinow Thanks in-depth check! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For a

Re: [text] Move to Java 8?

2018-04-08 Thread Gary Gregory
On Wed, Apr 4, 2018 at 7:30 AM, Rob Tompkins wrote: > > > > On Apr 4, 2018, at 9:27 AM, Gary Gregory wrote: > > > > Go for it. > > > > +1 > Done through TEXT-121 as well as updating to JUnit 5. Gary > > > Gary > > > > On Wed, Apr 4, 2018, 04:49 Pascal Schumacher > > wrote: > > > >> Hello, >

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-text/pull/79 Comitted! :-) Works for me as well in Eclipse 4.7.3. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org Fo

[GitHub] commons-text pull request #79: Upgrade to JUnit 5.1

2018-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/79 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 ![screenshot_2018-04-08_22-34-52](https://user-images.githubusercontent.com/304786/38466438-1d71ec6e-3b7d-11e8-82e2-d21cfa9e79bd.png) Screenshot with Eclipse version, and sample output (lo

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 Tested the master branch first, and everything obviously worked. Then switched to this branch, and got an error message, then Eclipse opened the run configuration. Followed @PascalSchumac

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 JUnit 5 should work with any Eclipse Version released during the last year (as long as you delete existing run configurations for the project). @garydgregory Can you give runnin