Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147397
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java
---
@@ -38,7 +41,7 @@
import static org.apache.com
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147391
--- Diff:
src/main/java/org/apache/commons/imaging/common/BinaryFunctions.java ---
@@ -317,4 +317,23 @@ public static void copyStreamToStream(final
In
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147410
--- Diff: src/test/data/specificTests/info.txt ---
@@ -0,0 +1 @@
+Licensed to the Apache Software Foundation (ASF) under one or more
contributor lic
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147413
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/specific/JpegImageParserTest.java
---
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2015
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147395
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/JpegConstants.java ---
@@ -125,7 +136,9 @@
SOF5_MARKER, SOF6_M
On Sat, 30 Dec 2017 14:25:32 +0100, Jan Matèrne wrote:
Maybe open the comparators and use a fluent API?
is(42).between(10).and(50) == true
is(10).between(10).and(20) == false
is(10).between(10).and(20).includingLeft() == true
is(50).between(10).and(50) == false
is(50).between(10).and(50).includin
