[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147886874 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
Sure, I'll do a full check on the whole dependency tree. Thanks for all the changes introduced to master. On Mon, Oct 30, 2017 at 9:55 AM, Gary Gregory wrote: > Also, would you mind updating direct dependencies to their latest versions? > This helps: 'mvn versions:display-dependency-updates' >

[GitHub] commons-rdf issue #42: COMMONSRDF-66: fixes RIOT exception in JenaDatasetImp...

2017-10-30 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/42 Please, rebase this PR on top of the current `HEAD` of `master`. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.o

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147883486 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147883290 --- Diff: jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread christopher-johnson
Github user christopher-johnson commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147875892 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Ove

Re: [dbcp] update to pool 2.4.3.

2017-10-30 Thread Gary Gregory
On Sun, Oct 29, 2017 at 2:09 AM, Mark Thomas wrote: > On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita" < > brunodepau...@yahoo.com.br.INVALID> wrote: > >Hi Gary, > > > >Started the tests in Maven command line, found which tests failed. > >Executed the tests in Eclipse, found which clas

Re: [pool] Using Java 7 and next version label

2017-10-30 Thread Gary Gregory
Git master now is at Java 7 and the version is 2.5.0-SNAPSHOT. Gary On Sat, Oct 28, 2017 at 1:11 PM, Pascal Schumacher wrote: > I would prefer 2.5. Upping the required java version in a bugfix release > seems unusual imho. > > -Pascal > > > Am 28.10.2017 um 21:03 schrieb Gary Gregory: > >> Hi A

[pool] close(). Closeable, and AutoCloseable

2017-10-30 Thread Gary Gregory
Hi All: Several [pool] interfaces implement close() but do not extend Closeable. Should they? Now that we are on Java 7, AutoCloseable is also available. Thoughts? Pros, Cons? Gary

Re: [LOGGING] Logging is Java 1.2 but required Java 1.4 code

2017-10-30 Thread Stephen Colebourne
Does commons-logging need to be a full module with a module-info.java? Probably not at this point. Adding Automatic-Module-Name is probably sufficient. However, if someone wants to do the work, then adding module-info shouldn't be blocked IMO. I don't believe that module-info.java requires Java 6

Re: [dbcp] update to pool 2.4.3.

2017-10-30 Thread Gary Gregory
Yes, thank you Matt. As mentioned previously on this thread, the missing method information can make it fiendishly difficult to track resource leaks. Gary On Mon, Oct 30, 2017 at 10:50 AM, Matt Sicker wrote: > Yes, I can look into this over the next couple days. I'd imagine this > should be con

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Also, would you mind updating direct dependencies to their latest versions? This helps: 'mvn versions:display-dependency-updates' Gary On Mon, Oct 30, 2017 at 10:54 AM, Gary Gregory wrote: > On Mon, Oct 30, 2017 at 10:38 AM, Sergio Fernández > wrote: > >> Completely agree. Thanks, Gary! >> >>

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
On Mon, Oct 30, 2017 at 10:38 AM, Sergio Fernández wrote: > Completely agree. Thanks, Gary! > > So, to wrap this up, the recommendation is that we should skip 0.4.0 and go > directly to 0.5.0 to avoid any issue, right? > Yes. Notice the src/changes/changes.xml file I added and that needs to be f

Re: [dbcp] update to pool 2.4.3.

2017-10-30 Thread Matt Sicker
Yes, I can look into this over the next couple days. I'd imagine this should be configurable whether you want just the class or if you need more info for leakage detection. On 30 October 2017 at 10:31, Gary Gregory wrote: > Hi Matt, > > Can you provide a patch to add an option to restore the beh

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
Completely agree. Thanks, Gary! So, to wrap this up, the recommendation is that we should skip 0.4.0 and go directly to 0.5.0 to avoid any issue, right? On Mon, Oct 30, 2017 at 9:36 AM, Gary Gregory wrote: > Yep, all will be 100% OK once all 8 artifacts are gone from r.a.o and MC. > > Then yo

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Yep, all will be 100% OK once all 8 artifacts are gone from r.a.o and MC. Then you can do it again for 0.5.0. Based on my experience as a RM, this is not the last mistake you'll make ;-) But heck, how are we supposed to learn? ;-) Gary On Mon, Oct 30, 2017 at 10:33 AM, Sergio Fernández wrote:

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
Thanks, Gary. I know the process. We also have it documented at https://github.com/apache/commons-rdf/blob/master/RELEASE-PROCESS.md But I pressed the wrong button when I was rolling-back because the dist issue I faced. In short, I screwed-up. I tried to solve it as soon as it happened. Chatting

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
In case you had not seen it: http://commons.apache.org/releases/prepare.html WRT to Nexus, all you need to do before a VOTE is to "Close" a repository on r.a.o. That makes it available for review. Gary On Mon, Oct 30, 2017 at 10:22 AM, Sergio Fernández wrote: > As Joel commented at OSSRH-35574

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
As Joel commented at OSSRH-35574: They may temporary appear in directory listings as well as search results on search.maven.org, but they shouldn't be download-able. I'll keep an eye on it on the next 48 hours, just in case anything else get synced or so. Once again, I'd like to apologize for the

Re: [dbcp] update to pool 2.4.3.

2017-10-30 Thread Gary Gregory
Hi Matt, Can you provide a patch to add an option to restore the behavior from we had in 2.4.2? Gary On Sun, Oct 29, 2017 at 2:32 PM, Matt Sicker wrote: > It's been a while since I looked at that, but from what I can tell, if the > method name needs to be tracked as well as the class name, the

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
I saw some there this morning. The parent POM is still there http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.commons%22%20AND%20a%3A%22commons-rdf-parent%22 Gary On Mon, Oct 30, 2017 at 9:05 AM, Sergio Fernández wrote: > Gary, > > as I said at INFRA-15404, I'm not really sure that

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
Gary, as I said at INFRA-15404, I'm not really sure that the invalid artifacts landed to Maven Central. I'll chat about the issue with INFRA and update here. On Mon, Oct 30, 2017 at 8:03 AM, Gary Gregory wrote: > Thank Rob, tracking at Sonatype: > https://issues.sonatype.org/browse/OSSRH-35574

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Thank Rob, tracking at Sonatype: https://issues.sonatype.org/browse/OSSRH-35574 Gary On Mon, Oct 30, 2017 at 8:36 AM, Rob Tompkins wrote: > Maven central issue tracker: > > https://issues.sonatype.org/projects/OSSRH/issues/OSSRH- > 27969?filter=allopenissues > > -Rob > > > On Oct 30, 2017, at 1

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Thank Rob, tracking at Sonatype: https://issues.sonatype.org/browse/OSSRH-35574 Gary On Mon, Oct 30, 2017 at 8:36 AM, Rob Tompkins wrote: > Maven central issue tracker: > > https://issues.sonatype.org/projects/OSSRH/issues/OSSRH- > 27969?filter=allopenissues > > -Rob > > > On Oct 30, 2017, at 1

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Sergio Fernández
Hi Gary, I had an issue with the staging repository while preparing RC1 (see another thread why I didn't continue with the process). But I chatted with INFRA, so they fixed my error last night few seconds after. So the artifacts shouldn't continue, in theory. I'm going to double-check what happene

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Rob Tompkins
Maven central issue tracker: https://issues.sonatype.org/projects/OSSRH/issues/OSSRH-27969?filter=allopenissues -Rob > On Oct 30, 2017, at 10:34 AM, Gary Gregory wrote: > > Tracking here: > > https://issues.apache.org/jira/browse/INFRA-15404 > > Gary > > On Mon, Oct 30, 2017 at 8:18 AM, Gar

Re: [rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Tracking here: https://issues.apache.org/jira/browse/INFRA-15404 Gary On Mon, Oct 30, 2017 at 8:18 AM, Gary Gregory wrote: > Hi All, > > It appears that Apache Commons RDF 0.4.0 has been released into the wild > (our Maven repo AND Maven Central) without approval by the Apache Commons > PMC. >

[rdf] Apache Commons RDF 0.4.0 has NOT been approved by the Commons PMC

2017-10-30 Thread Gary Gregory
Hi All, It appears that Apache Commons RDF 0.4.0 has been released into the wild (our Maven repo AND Maven Central) without approval by the Apache Commons PMC. I will create an INFRA ticket to delete this release from Apache repositories. If any one knows if there is a process for Maven Central,

Re: Nexus: Promotion Completed

2017-10-30 Thread Gary Gregory
This release must be pull back ASAP. Gary On Mon, Oct 30, 2017 at 7:24 AM, Gary Gregory wrote: > Did the RM actually release this without a VOTE, tell me it ain't so... > > Gary > > On Oct 29, 2017 20:43, "Nexus Repository Manager" < > ne...@repository.apache.org> wrote: > >> Message from: http

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701690 --- Diff: jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in com

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701840 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override p

Re: Nexus: Promotion Completed

2017-10-30 Thread Gary Gregory
Did the RM actually release this without a VOTE, tell me it ain't so... Gary On Oct 29, 2017 20:43, "Nexus Repository Manager" < ne...@repository.apache.org> wrote: > Message from: https://repository.apache.org > > > > *Deployer properties:* > >- "userAgent" = "Apache-Maven/3.5.0 (Java 1.8.0

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread christopher-johnson
GitHub user christopher-johnson opened a pull request: https://github.com/apache/commons-rdf/pull/42 COMMONSRDF-66: fixes RIOT exception in JenaDatasetImpl Lang.NT is not supported by registryDataset. Opts for Lang.NQUADS as a default replacement. adds test You can merge th

Re: [RDF] Commons release?

2017-10-30 Thread sebb
On 30 October 2017 at 03:26, Sergio Fernández wrote: > Hi, > > I started to prepare 0.4.0 release [1] at a RC branch [1]. But then I facea > with an unexpected problem: I have no permissions to write at the Commons' > dist area. > > That's because I shouldn't. After graduation, the Commons RDF PPM