Re: [apache/commons-lang] LANG-1346: Remove deprecation from RandomStringUtils (f2d8493)

2017-10-16 Thread Pascal Schumacher
There is no concrete release date yet, but hopefully it should not take to long. Am 17.10.2017 um 04:04 schrieb Daniel Kirkdorffer: When will this be released? - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org F

[GitHub] commons-collections issue #21: Add VI[M] temporary files to .gitignore

2017-10-16 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/commons-collections/pull/21 A `.gitignore` should be agnostic to the editor or IDE devs use for the project. Those files belong into `.git/info/excludes`. --- --

Re: [text] always use static imports for assertion methods

2017-10-16 Thread kenneth mcfarland
The inclusion of static imports is fairly common in the context Matt provided. One could easily argue that polluting names with another assertEquals method was a bad design decision. Especially when you have made a concisious design decision to use JUnit. Is it likely to cause confusion in real pr

[GitHub] commons-bcel pull request #17: BCEL-295 fix local variable live range length...

2017-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-bcel/pull/17 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-16 Thread Oliver Heger
Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site look good. +1 Oliver Am 14.10.2017 um 15:45 schrieb Stefan Bodewig: > Hi all > > this is mostly a bugfix release but it was about time for a new release. > > Compress 1.15 RC1 is available for review here: > https://d

Re: [VOTE] Release Apache Commons IO 2.6 based on RC3

2017-10-16 Thread Gary Gregory
+1 The bin zip contains the jar, which itself does NOT contain a cobertura properties file (which failed RC2) The src zip ASC, MD5 and SHA-1 are OK. The site builds with 'mvn clean site' and Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T13:39:06-06:00) Maven home: C:\

Re: [VOTE] Release Apache Commons IO 2.6 based on RC3

2017-10-16 Thread Oliver Heger
Am 15.10.2017 um 17:28 schrieb Gary Gregory: > How do you verify that the class files are not Cobertura tweaked? Can we > add that as a step to the wiki and commons build plugin? As long as there is no cobertura.properties file in the root of the jar, we should be on the safe side. However, it

[GitHub] commons-collections issue #21: Add VI[M] temporary files to .gitignore

2017-10-16 Thread mureinik
Github user mureinik commented on the issue: https://github.com/apache/commons-collections/pull/21 > @mureinik - Do you mind rebasing to master and re-opening this pull request? Sorry, missed this notification completely :-( I rebased my branch, but I don't think I can reo

Re: [LANG] Add module-info.java?

2017-10-16 Thread Stephen Colebourne
On 16 October 2017 at 14:14, Simon Spero wrote: > [In regards to original question, -0.0 (harmless, but pointless, since > applications should not use lang as a jpms module. Huh? Of course they should. > To be usable as a jpms > module, EVERY release that has ANY api change must use new module

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Gary Gregory
On Oct 15, 2017 16:34, "Gilles" wrote: On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: > Assertion classes are just containers for static methods. Using "import > static" is the only way in Java to import the individual methods as if the > class itself were a package. Also, doing this is

Re: [LANG] Add module-info.java?

2017-10-16 Thread Simon Spero
[In regards to original question, -0.0 (harmless, but pointless, since applications should not use lang as a jpms module. To be usable as a jpms module, EVERY release that has ANY api change must use new module and package names).[1] ] Since all dependencies have to be shad(e|ow)ed (and not exp

Re: [CANCEL][VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-16 Thread Benedikt Ritter
Hello, > Am 15.10.2017 um 20:14 schrieb Chas Honton : > > Jacoco code coverage does runtime instrumentation, so this would not happen > with Jacoco profile. We should update IO to use jacoco once we have released IO 2.6. Benedikt > > Chas > >> On Oct 15, 2017, at 2:45 AM, Benedikt Ritter

Re: [VOTE] Release Apache Commons IO 2.6 based on RC3

2017-10-16 Thread Benedikt Ritter
Hi, > Am 15.10.2017 um 17:28 schrieb Gary Gregory : > > How do you verify that the class files are not Cobertura tweaked? Can we > add that as a step to the wiki and commons build plugin? I explicitly called mvn clean deploy this time. Benedikt > > Gary > > On Oct 15, 2017 04:22, "Benedikt R

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Gilles
On Mon, 16 Oct 2017 12:09:27 +0200, Benedikt Ritter wrote: Hello Gilles, Am 16.10.2017 um 11:07 schrieb Gilles : On Mon, 16 Oct 2017 09:30:01 +0200, Benedikt Ritter wrote: Am 16.10.2017 um 00:34 schrieb Gilles : On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: Assertion classes are j

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Benedikt Ritter
Hello Gilles, > Am 16.10.2017 um 11:07 schrieb Gilles : > > On Mon, 16 Oct 2017 09:30:01 +0200, Benedikt Ritter wrote: >>> Am 16.10.2017 um 00:34 schrieb Gilles : >>> >>> On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: Assertion classes are just containers for static methods. Using "

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Gilles
On Mon, 16 Oct 2017 09:22:51 + (UTC), Bruno P. Kinoshita wrote: When you see "assertEquals", you cannot assume that it was>imported from the (Junit) "Assert" class. In CM for example, another "assertEquals" is defined in an internal "TestUtils" class. But the internal class could be named

Re: [LANG] Add module-info.java?

2017-10-16 Thread sebb
On 16 October 2017 at 10:34, Emmanuel Bourg wrote: > Le 14/10/2017 à 14:43, Benedikt Ritter a écrit : > >> I’d like to hear opinions on this change. > > I wonder if we could somehow write a module-info.java compiler that > works with older version of Java. The syntax doesn't look terribly > compli

Re: [LANG] Add module-info.java?

2017-10-16 Thread Emmanuel Bourg
Le 14/10/2017 à 14:43, Benedikt Ritter a écrit : > I’d like to hear opinions on this change. I wonder if we could somehow write a module-info.java compiler that works with older version of Java. The syntax doesn't look terribly complicated after all. It could be invoked from a plugin hooked to th

Re: [2/2] [lang] remove unused bcel test dependency

2017-10-16 Thread sebb
On 16 October 2017 at 08:54, Benedikt Ritter wrote: > Hi Chas, > >> Am 15.10.2017 um 20:29 schrieb Chas Honton : >> >> You can use dependency:analyze to find used and undeclared or unused and >> declared dependencies. Perhaps we should add dependency:analyze-only to >> release profile of parent

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Bruno P. Kinoshita
>When you see "assertEquals", you cannot assume that it was>imported from the >(Junit) "Assert" class. >In CM for example, another "assertEquals" is defined in an >internal "TestUtils" class. But the internal class could be named Assert. In that case you still wouldn't know if it was imported fr

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Gilles
On Mon, 16 Oct 2017 09:30:01 +0200, Benedikt Ritter wrote: Am 16.10.2017 um 00:34 schrieb Gilles : On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: Assertion classes are just containers for static methods. Using "import static" is the only way in Java to import the individual methods as

Re: [2/2] [lang] remove unused bcel test dependency

2017-10-16 Thread Benedikt Ritter
Hi Chas, > Am 15.10.2017 um 20:29 schrieb Chas Honton : > > You can use dependency:analyze to find used and undeclared or unused and > declared dependencies. Perhaps we should add dependency:analyze-only to > release profile of parent pom to make sure dependencies are clean. Good idea! We co

Re: [LANG] Add module-info.java?

2017-10-16 Thread Benedikt Ritter
Hi Ralph, > Am 15.10.2017 um 21:20 schrieb Ralph Goers : > > I should point out - just for reference - that Log4j has a maven module > dedicated to Java 9 and only that is built with the Java 9 compiler. > Everything else uses Java 7. We also use Java 7 when running the maven site > plugin. It

Re: [text] always use static imports for assertion methods

2017-10-16 Thread Benedikt Ritter
> Am 16.10.2017 um 00:34 schrieb Gilles : > > On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: >> Assertion classes are just containers for static methods. Using "import >> static" is the only way in Java to import the individual methods as if the >> class itself were a package. Also, doin