[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...

2017-10-01 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/67 Seems to break coverall somehow. (By now there should have been an comment from the coveralls bot concerning code coverage,) --- --

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Stephen Colebourne
On 1 October 2017 at 11:34, Stefan Bodewig wrote: > - only add the automatic module name to commons-logging and release api > and adapter as they are. Exactly. This is the right approach. Stephen - To unsubscribe, e-mail: dev-un

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
> Am 01.10.2017 um 19:00 schrieb Ralph Goers : > > That isn’t what I suggested. Release all 3 but only turn commons-logging.jar > into a module. Yes :o) I’ll go ahead with this approach as soon as I find the time for it. Cheers, Benedikt > > Ralph > >> On Oct 1, 2017, at 1:25 AM, Benedikt

Re: [VOTE] Release Apache Commons IO 2.6 based on RC1

2017-10-01 Thread Jochen Wiedmann
+1 On Sun, Oct 1, 2017 at 1:46 PM, Bruno P. Kinoshita wrote: > Build passing OK with > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-11T05:41:47+13:00)Maven home: /opt/mavenJava version: 1.8.0_144, > vendor: Oracle CorporationJava home: /usr/lib/jvm/java-8-oracle/jreDe

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Ralph Goers
> On Oct 1, 2017, at 2:48 AM, sebb wrote: > > On 1 October 2017 at 10:08, Pascal Schumacher > wrote: >> Looks like commons-logging-api is used by some popular projects (Hibernate, >> Hadoop, Camel): >> >> http://www.mvnrepository.com/artifact/commons-logging/co

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Ralph Goers
That isn’t what I suggested. Release all 3 but only turn commons-logging.jar into a module. Ralph > On Oct 1, 2017, at 1:25 AM, Benedikt Ritter wrote: > > Okay, so we agree to drop the api and adapters jars from the build and the > distribution? If that is the case, I think we are ready to rel

[GitHub] commons-text pull request #67: travis: remove travis profile from pom and us...

2017-10-01 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/67 travis: remove travis profile from pom and use travis-jacoco profile … …commons-parent You can merge this pull request into a Git repository by running: $ git pull https://git

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-10-01 Thread Gary Gregory
I also had not considered building on Java 9 since Java 9 has made such a mess with backward compatibility and a lot of Maven plugins fail on Java 9. Gary On Oct 1, 2017 04:12, "Benedikt Ritter" wrote: > Hello Gary, > > - signatures are good > - Release notes look good > - Website looks good >

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-10-01 Thread Gary Gregory
As Pascal noted on this thread, these test failures happen only on non-Windows systems and the tests have since been patched. I will wait until tomorrow to consider canceling this vote as I am AFK until then. Gary On Oct 1, 2017 04:12, "Benedikt Ritter" wrote: Hello Gary, - signatures are good

Re: Support Percent-Encoding (described in RFC3986 and RFC7578)

2017-10-01 Thread Bruno P. Kinoshita
Hi Giannis, Had a quick look at the ticket, but with limited Internet I can't really thoroughly read and comment about it. Sometimes it may be easier to review a proposal for a new feature like yours if there is some code somewhere. So if creating the pull request wouldn't take too long, it might

Re: [VOTE] Release Apache Commons IO 2.6 based on RC1

2017-10-01 Thread Bruno P. Kinoshita
Build passing OK with Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)Maven home: /opt/mavenJava version: 1.8.0_144, vendor: Oracle CorporationJava home: /usr/lib/jvm/java-8-oracle/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version

Re: [VOTE] Release Apache Commons IO 2.6 based on RC1

2017-10-01 Thread Pascal Schumacher
Sorry, the md5/sha1 output part should be: >md5sum -c commons-io-2.6-src.zip.md5 md5sum: commons-io-2.6-src.zip.md5: no properly formatted MD5 checksum lines found >sha1sum -c commons-io-2.6-src.zip.sha1 sha1sum: commons-io-2.6-src.zip.sha1: no properly formatted SHA1 checksum lines found A

Re: [VOTE] Release Apache Commons IO 2.6 based on RC1

2017-10-01 Thread Pascal Schumacher
+1 Build (mvn test apache-rat:check clirr:check javadoc:javadoc) from zip and tar.gz successful. One checkstyle error. Three findbugs errors, two look like they were already part of previous versions. PGP Signature checks successful. I was not able to check md5 and sha1 (probably doing it

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Stefan Bodewig
On 2017-10-01, Benedikt Ritter wrote: > So what options are we left with? > - Do nothing -> logging can’t be used as a Java 9 module > - Drop api and adapters -> users have to change their dependencies and get > more code than they want - only add the automatic module name to commons-logging and

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
> Am 01.10.2017 um 11:48 schrieb sebb : > > On 1 October 2017 at 10:08, Pascal Schumacher > wrote: >> Looks like commons-logging-api is used by some popular projects (Hibernate, >> Hadoop, Camel): >> >> http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages >> >> but

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-10-01 Thread Benedikt Ritter
Hello Gary, - signatures are good - Release notes look good - Website looks good With Java 7 and Java 8 I get these test failures: Results : Failed tests: ZipFileObjectTestCase.testReadingFilesInZipFile:98->readAndAssert:61 zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/ZipFileO

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread sebb
On 1 October 2017 at 10:08, Pascal Schumacher wrote: > Looks like commons-logging-api is used by some popular projects (Hibernate, > Hadoop, Camel): > > http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages > > but I guess they can easily switch to commons-logging. Not

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Pascal Schumacher
Looks like commons-logging-api is used by some popular projects (Hibernate, Hadoop, Camel): http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages but I guess they can easily switch to commons-logging. Commons-logging-adatper seem to be very rarely used: http://www.m

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
Okay, so we agree to drop the api and adapters jars from the build and the distribution? If that is the case, I think we are ready to release this. Benedikt Gary Gregory schrieb am So. 1. Okt. 2017 um 03:39: > On Sep 30, 2017 11:24, "Ralph Goers" wrote: > > Looking at the build script it appea