[GitHub] commons-imaging issue #27: Increase code coverage one

2017-07-14 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Did you try a build like "mvn clean verify"? This PR format seems bogus as it contains folders like "org.apache.commons.imaging.common.itu_t4" instead "org/apache/commons/imagin

[imgaing] Failing unit test

2017-07-14 Thread Gary Gregory
Hi All, Did you all know we have a failing unit test in git master? org.junit.experimental.theories.internal.ParameterizedAssertionError: testFullColorRoundtrip("BufferedImage@c32777a: type = 2 DirectColorModel: rmask=ff gmask=ff00 bmask=ff amask=ff00 IntegerInterleavedRaster: width = 300

[GitHub] commons-imaging issue #27: Increase code coverage one

2017-07-14 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just sent it to you via email. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] commons-imaging issue #27: Increase code coverage one

2017-07-14 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Under what name? Feel free to email me at ggreg...@apache.org if you do not want to state your name here. --- If your project is set up for it, you can reply to this email and have your

Re: PR Merge process lang vs text ?

2017-07-14 Thread Amey Jadiye
well It's still confusing... Example. https://github.com/apache/commons-lang/pull/270 Here in #270 asfgit merged the PR While https://github.com/apache/commons-lang/pull/274 Here in #274 asfgit closed PR. Regards, Amey On Sat, Jul 15, 2017, 2:07 AM Gary Gregory wrote: > If a Git commit

Re: PR Merge process lang vs text ?

2017-07-14 Thread Gary Gregory
If a Git commit comment says "Closes #" like "Closes #29", PR #29 will be closed. I forget to do that sometimes. Gary On Fri, Jul 14, 2017 at 1:29 PM, Amey Jadiye wrote: > I wonder is there different process for accepting PR in text and lang ? > > Whenever I open PR for text ,after acceptance i

PR Merge process lang vs text ?

2017-07-14 Thread Amey Jadiye
I wonder is there different process for accepting PR in text and lang ? Whenever I open PR for text ,after acceptance it says "asfgit merged branch" and it automatically shows pr status as #merged on github while for lang after merging my code PR stays open and I have to manually close it? Regard

[GitHub] commons-imaging issue #27: Increase code coverage one

2017-07-14 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just submitted my ICLA to secret...@apache.org. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: [lang] - Remove RandomStringUtils deprecation / move it to [text]?

2017-07-14 Thread Amey Jadiye
Hello Pascal, Thanks for putting this on table, I too think that users need some short code to show up output really quick. How about this plan :- 1. Keep RandomStringUtils deprecated in commons-lang. 2. Move RandomStringUtils class to commons-text. 3. Remove all existing code from methods of Ra