Re: Git/Github Access

2017-07-06 Thread Gary Gregory
I saw that. Cool. Gary On Thu, Jul 6, 2017 at 8:25 PM, Carl Hall wrote: > Thanks so much, Gary! Looks like the bits are flowing now. > > On Wed, Jul 5, 2017 at 9:46 AM, Gary Gregory > wrote: > > > Carl, > > > > You are now in the Commons group per Whimsy. > > > > Gary > > > > On Wed, Jul 5, 2

Re: Git/Github Access

2017-07-06 Thread Carl Hall
Thanks so much, Gary! Looks like the bits are flowing now. On Wed, Jul 5, 2017 at 9:46 AM, Gary Gregory wrote: > Carl, > > You are now in the Commons group per Whimsy. > > Gary > > On Wed, Jul 5, 2017 at 12:58 AM, sebb wrote: > > > In the long term, we should ask INFRA to ensure all Commons re

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread jbduncan
Github user jbduncan commented on the issue: https://github.com/apache/commons-text/pull/55 @ameyjadiye I don't know if there's a convention in Apache Commons for preferring `new X.Builder()` over static factory methods like `X.builder()`, but if there isn't, then I would encourage ch

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/55 Sure...I'll try to look at this in the coming day or so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/55 @chtompki , @PascalSchumacher , can you please express your opinion on this , please check JIRA for detail discussion. --- If your project is set up for it, you can reply to this email and h

[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...

2017-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

2017-07-06 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/48 ```isDelimiter``` is simply the method to identify if codePoint or char is present in given second parameter which is array. ofcource if array is empty it means first param is not present in

Re: [Graph] the future of commons-graph and modularization

2017-07-06 Thread Oliver Kopp
Hi, 2013-05-26 17:35 GMT+02:00 Simone Tripodi : > What I would like to propose to work _in a separated branch_, is > trying to split the big monolith in smaller modules and separate APIs > from related implementation as much as possible. I know, I am very late to rejoin the party. :) Here some p

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

2017-07-06 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/48 Should we add to `public static boolean isDelimiter(final char ch, final char[] delimiters)` or `isDelimiter` generally, documentation stating that if an empty array is passed in we always retu

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Efremov, Rodion
Having taking a closer look the way DualHashBidiMap and Java's HashMap are implemented, my implementation has only two advantages: (1) It maintains an additional list of entries. This allows faster iteration since it does not have to visit empty collision chain buckets. Also, it allows faster

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Javen O'Neal
It wasn't a rhetorical question. I wanted to open discussion on your contribution, and wanted to start with what folks on this mailing list are most familiar with. I'm not a Commons Collection maintainer, but I'm curious if you could describe your implementation in a few sentences and how it diffe

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Efremov, Rodion
From http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/DualHashBidiMap.java?view=markup "Commons Collections would welcome the addition of a direct hash-based implementation of the BidiMap interface" Guess I was wrong. __

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Javen O'Neal
How is this different from the existing DualHashBidiMap? https://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/bidimap/DualHashBidiMap.html On Jul 6, 2017 09:06, "Efremov, Rodion" wrote: > Hello, > > > I am working on a hash table based BidiM

[GitHub] commons-io pull request #40: IO-279: Added ignoreNew parameter on instantiat...

2017-07-06 Thread myyron
GitHub user myyron opened a pull request: https://github.com/apache/commons-io/pull/40 IO-279: Added ignoreNew parameter on instantiating Tailer. Encountered this bug today when we try to tail a file that is being modified even though there is no new content being added. You can me

[collections] How about a HashBidiMap?

2017-07-06 Thread Efremov, Rodion
Hello, I am working on a hash table based BidiMap at https://github.com/coderodde/BidirectionalHashMap/blob/master/src/net/coderodde/util/BidirectionalHashMap.java and would like to contribute it to Commons Collections. Could someone working on the project discuss my contribution attempt? Be