Re: [compress] HasCharset is a bad name

2017-07-05 Thread Stefan Bodewig
On 2017-07-05, Gary Gregory wrote: > The new interface name HasCharset is pretty bad IMO. fair enough. > CharsetProvider is the obvious (to me) better name even though there > already is a class called java.nio.charset.spi.CharsetProvider. I don't think so, this really is a marker interface for

JIRA Spam in Apache Commons

2017-07-05 Thread Gary Gregory
Hi, We are getting a lot of spam over in the JIRA project for Apache Commons Collections. For example https://issues.apache.org/jira/browse/COLLECTIONS-619 What can we do? Gary

Re: [jira] [Created] (COLLECTIONS-608-615)

2017-07-05 Thread Amey Jadiye
Raised Infra request, let's see if they have some permanent solution. https://issues.apache.org/jira/browse/INFRA-14517 Regards, Amey On Thu, Jul 6, 2017, 10:34 AM Amey Jadiye wrote: > This thing is really annoying now, someone is frequently attacking jira, > and now it seems not happening mis

Fwd: [jira] [Created] (COLLECTIONS-608-615)

2017-07-05 Thread Amey Jadiye
This thing is really annoying now, someone is frequently attacking jira, and now it seems not happening mistakenly. Infra should have some solution over this? Regards, Amey -- Forwarded message - From: ramsingh (JIRA) Date: Thu, Jul 6, 2017, 10:24 AM Subject: [jira] [Created] (CO

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Jonathan Bluett-Duncan
Okay, I don't intend to apply any `@SuppressWarnings` during my refactoring efforts - if IntelliJ still reports warnings after my efforts, then I can live with that. :) Jonathan On 6 July 2017 at 00:31, Matt Sicker wrote: > The only thing I can think of that conflicts sometimes with IDEA versus

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Matt Sicker
The only thing I can think of that conflicts sometimes with IDEA versus Eclipse are custom @SupressWarnings strings causing warnings in Eclipse. The default IntelliJ warnings tend to be simple things that wouldn't cause an issue, however, based in my experience. It's only some of the advanced inspe

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Jonathan Bluett-Duncan
Great! Sounds like there's general agreement on me pursuing at least some of these refactorings, right? On the subject of code style guidelines, AFAIK [lang] uses Checkstyle to check style adherence? So I assume that if the corresponding Maven goal passes after a refactoring, then it's okay to sub

[jelly] Build for tag libs

2017-07-05 Thread Oliver Heger
Hi, FYI, I started with the rework of the Jelly build regarding tag libraries. The goal is to have a single Maven 3 build which builds Jelly core and all tag libraries. (In the old build, tag libraries were stand-alone projects.) A common build is certainly useful, e.g. for the site build (althoug

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Gary Gregory
Keep in mind that not all of us use IDEA. For example, I am on Eclipse. I do not think this should be an issue for any of these changes thougg. I do not expect that changes from IDEA warnings would cause the Eclipse Java compiler to issue warnings, and vice-versa. Gary On Jul 5, 2017 12:23, "Allo

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Allon Mureinik
I've submitted several such cleanups over the past couple of month, and for the most part, they've been well received. I think the key here is to improve the codebase when possible but to leave room to deviate from IntelliJ's norms when there's a good reason to. Perhaps annotating such places with

Re: [compress] HasCharset is a bad name

2017-07-05 Thread Gary Gregory
Supplied and Provider are both good. Gary On Wed, Jul 5, 2017 at 10:22 AM, Jeremy Gustie < jgus...@blackducksoftware.com> wrote: > CharsetSupplier? > > -Jeremy > > > On Jul 5, 2017, at 1:14 PM, Gary Gregory wrote: > > > > Hi All, > > > > The new interface name HasCharset is pretty bad IMO. > >

Re: [compress] HasCharset is a bad name

2017-07-05 Thread Jeremy Gustie
CharsetSupplier? -Jeremy > On Jul 5, 2017, at 1:14 PM, Gary Gregory wrote: > > Hi All, > > The new interface name HasCharset is pretty bad IMO. > > CharsetProvider is the obvious (to me) better name even though there > already is a class called java.nio.charset.spi.CharsetProvider. > > Alter

[compress] HasCharset is a bad name

2017-07-05 Thread Gary Gregory
Hi All, The new interface name HasCharset is pretty bad IMO. CharsetProvider is the obvious (to me) better name even though there already is a class called java.nio.charset.spi.CharsetProvider. Alternatives could be CharsetContainer, CharsetAccessor, CharsetGetter, ? Gary

Re: Git/Github Access

2017-07-05 Thread Gary Gregory
Carl, You are now in the Commons group per Whimsy. Gary On Wed, Jul 5, 2017 at 12:58 AM, sebb wrote: > In the long term, we should ask INFRA to ensure all Commons repos are > open to all committers. > > In the short term, a work-round is to update the Commons committer list. > > This can be do

[GitHub] commons-codec pull request #8: Add methods to DigestUtils to generate hex fr...

2017-07-05 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-codec/pull/8 Add methods to DigestUtils to generate hex from MessageDigest et. al. *This PR replaces #7 which was associated with the wrong issue number* This PR adds methods to DigestUtils to make it

[GitHub] commons-codec pull request #7: CODEC-224 Add methods to DigestUtils to gener...

2017-07-05 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-codec/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [lang] Applying IntelliJ IDEA refactorings

2017-07-05 Thread Matt Sicker
I like the idea myself at least, though I'm not sure if it conflicts with any coding styleguides established. On 4 July 2017 at 18:18, Jonathan Bluett-Duncan wrote: > Hi all, > > I'm interested in going through commons-lang with IntelliJ IDEA and > applying small refactorings to make the code ba

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125656068 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125656068 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125655784 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125655784 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread rubin55
Github user rubin55 commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125648975 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread rubin55
Github user rubin55 commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125648975 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

Re: [compress] FW: Tika content detection and crawled "remote" content

2017-07-05 Thread Stefan Bodewig
This looks great, well done Tika! Thank you for sharing, Tim Cheers Stefan On 2017-07-05, Allison, Timothy B. wrote: > Fellow file-philes on [compress], > Sebastian Nagel has added file type id via Apache Tika to Common Crawl. > While Tika is not 100% accurate, this means that we have

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125636671 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-07-05 Thread chtompki
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125636671 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore -

[compress] FW: Tika content detection and crawled "remote" content

2017-07-05 Thread Allison, Timothy B.
Fellow file-philes on [compress], Sebastian Nagel has added file type id via Apache Tika to Common Crawl. While Tika is not 100% accurate, this means that we have far better clarity on mime type than relying on the http header+file suffix. So, for testing purposes, you (or we over on Tika)

Re: Fwd: [jira] [Created] (DISCOVERY-23)

2017-07-05 Thread Simon Spero
The clue is in the issue id. Disco-very. Disco-rdia. Part of commons, they share a common prefix. What is the prefix? Disco. How many letters in that prefix? 5 - 2 + 3 ! Disco →sf-raves →hyperreal →Apache. Coincidence? Then how do you explain the fnords? Or the Twitter? What better way to hi

Re: Git/Github Access

2017-07-05 Thread sebb
In the long term, we should ask INFRA to ensure all Commons repos are open to all committers. In the short term, a work-round is to update the Commons committer list. This can be done through Whimsy: https://whimsy.apache.org/roster/committee/commons I suspect only the chair can do so at presen

Re: Fwd: [jira] [Created] (DISCOVERY-23)

2017-07-05 Thread Stefan Bodewig
On 2017-07-05, Amey Jadiye wrote: > Looks very suspicious to me, like created with script / bot ? Maybe you shouldn't cite it completely, now the spam is part of all dev@commons archives as well :-) I've deleted the two issues and asked INFRA to deal with it as the same user has been hitting oth