[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...

2017-06-23 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/54 [![Coverage Status](https://:/builds/12108852/badge)](https://:/builds/12108852) Coverage decreased (-0.02%) to 97.305% when pulling **df30bf96856287478f3a7dfa7f017ca175bdd352 on

Re: [configuration] checkstyle fails build

2017-06-23 Thread Gary Gregory
I P.S. Agree P.P.S. With P.P.P.S. you! Gary On Jun 23, 2017 10:28, "Simon Spero" wrote: > On Jun 23, 2017 11:03 AM, "Oliver Heger" > wrote: > > However, letting the build fail because of checkstyle error is too > restrictive IMHO. My approach is to work through the errors before creating

Some ideas for improving Travis build performance improvements:

2017-06-23 Thread Simon Spero
COMPRESS-413 has some examples which include: - Switching to the trusty container, which doesn't require installing as many updates. - Use only two JDKs: openjdk7 and openjdk8. - JDK 7 is obsolete - - Oracle EOL'ed JDK7 over two years ago; openjdk7 occasionally gets pa

Re: [configuration] checkstyle fails build

2017-06-23 Thread Simon Spero
On Jun 23, 2017 11:03 AM, "Oliver Heger" wrote: However, letting the build fail because of checkstyle error is too restrictive IMHO. My approach is to work through the errors before creating a new release. This has the disadvantage that errors might accumulate; but from one release to the next on

Re: [configuration] checkstyle fails build

2017-06-23 Thread Gary Gregory
On Fri, Jun 23, 2017 at 9:35 AM, sebb wrote: > On 23 June 2017 at 17:29, Gary Gregory wrote: > > On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren wrote: > > > >> How about an eclipse format configuration that will correct the error on > >> demand. Granted you have to run eclipse but if such a fi

Re: [configuration] checkstyle fails build

2017-06-23 Thread Allon Mureinik
Instead of a per-IDE specific file, it may be useful to look into EditorConfig [1]. A lot of IDEs support it either natively or via plugin, and it may help having to replicate the same styling "logic" per IDE. [1] http://editorconfig.org/ On Fri, Jun 23, 2017 at 7:35 PM, sebb wrote: > On 23 Jun

Re: [configuration] checkstyle fails build

2017-06-23 Thread sebb
On 23 June 2017 at 17:29, Gary Gregory wrote: > On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren wrote: > >> How about an eclipse format configuration that will correct the error on >> demand. Granted you have to run eclipse but if such a file were created >> (and checked in) then it would be easy

Re: [configuration] checkstyle fails build

2017-06-23 Thread Gary Gregory
On Fri, Jun 23, 2017 at 8:24 AM, Allon Mureinik wrote: > On Fri, Jun 23, 2017 at 6:03 PM, Oliver Heger < > oliver.he...@oliver-heger.de> > wrote: > > > > > > > Am 23.06.2017 um 08:58 schrieb Allon Mureinik: > > > The root cause, IMHO, is having failValidation=false configured in the > > > pom.xml

Re: [configuration] checkstyle fails build

2017-06-23 Thread Gary Gregory
On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren wrote: > How about an eclipse format configuration that will correct the error on > demand. Granted you have to run eclipse but if such a file were created > (and checked in) then it would be easy for anyone running eclipse to fix > it. > I use Ecl

Re: [configuration] checkstyle fails build

2017-06-23 Thread Allon Mureinik
On Fri, Jun 23, 2017 at 6:03 PM, Oliver Heger wrote: > > > Am 23.06.2017 um 08:58 schrieb Allon Mureinik: > > The root cause, IMHO, is having failValidation=false configured in the > > pom.xml. This way, when you introduce a new problem your only option to > > notice it is if you visually scan mv

Re: [configuration] checkstyle fails build

2017-06-23 Thread Claude Warren
How about an eclipse format configuration that will correct the error on demand. Granted you have to run eclipse but if such a file were created (and checked in) then it would be easy for anyone running eclipse to fix it. Claude On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger wrote: > > > Am 23.

Re: [configuration] checkstyle fails build

2017-06-23 Thread Oliver Heger
Am 23.06.2017 um 08:58 schrieb Allon Mureinik: > The root cause, IMHO, is having failValidation=false configured in the > pom.xml. This way, when you introduce a new problem your only option to > notice it is if you visually scan mvn's output. As evident by the current > state of the build, not e

[GitHub] commons-rng issue #3: Rng 38

2017-06-23 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-rng/pull/3 [![Coverage Status](https://:/builds/12102911/badge)](https://:/builds/12102911) Coverage decreased (-0.02%) to 96.919% when pulling **3179fd6a6bbbdb3cd2fb492ad27b7dfadcb21fb4 on C

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-06-23 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/15 [![Coverage Status](https://:/builds/12101592/badge)](https://:/builds/12101592) Coverage decreased (-0.1%) to 96.122% when pulling **4f17a89ad04bcf718aeac43d202f8c261ce0b796 on r

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-06-23 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/15 [![Coverage Status](https://:/builds/12101592/badge)](https://:/builds/12101592) Coverage decreased (-0.1%) to 96.122% when pulling **4f17a89ad04bcf718aeac43d202f8c261ce0b796 on r

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

2017-06-23 Thread rubin55
GitHub user rubin55 opened a pull request: https://github.com/apache/commons-cli/pull/15 CLI-217: Optional partial matching At request of Gary, I (re)created an old patch against the current code base to enable partial matching to be set as optional. This fixes problems for people

Re: [RNG] Pending issues

2017-06-23 Thread Gilles
Hi Artem. On Fri, 23 Jun 2017 02:55:02 +0300, Artem Barger wrote: ​Hi, Can you please take a look on PRs which suppose to handle both issues? Please see my comments on the JIRA pages. Thanks for looking into this, Gilles ​ On Fri, Jun 23, 2017 at 1:35 AM, Gilles wrote: Github and Ma