Build passing with Oracle JDK 8 and IBM JDK 8. Successfully generated site,
reports look OK.
[X] +1 Release these artifacts
Cheers
Bruno
From: Benedikt Ritter
To: Commons Developers List
Sent: Friday, 9 June 2017 9:56 PM
Subject: [VOTE] Release Apache Commo
[x] +1 Release it.
Build passing for IBM JDK 8 and Oracle JDK 8. Site generated successfully,
reports look good too.
Cheers
Bruno
From: Rob Tompkins
To: Commons Developers List
Sent: Saturday, 10 June 2017 1:58 PM
Subject: [VOTE] Release Commons Fileupload 1
+1
Not a blocker: bin zip contains two copies of the Javadoc site, neither of
which load from their respective index.html; I get the three Javadoc frames
and an error icon in each frame.
>From src zip:
ASC, MD5, SHA1 OK
Build OK with 'mvn clean verify site'
The Javadoc site is fine there.
Repor
Hello all,
This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).
Tag name:
commons-fileupload-1.3.3-RC6 (signature can be checked from git using 'git
tag -v')
Tag URL:
https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=tag;h=refs/tags/commons-fileuploa
> On Jun 9, 2017, at 8:18 PM, Gary Gregory wrote:
>
>> On Fri, Jun 9, 2017 at 2:51 PM, Rob Tompkins wrote:
>>
>>
>> This time I mean it. Heh... :-)
>>
>> I agree on the items needing fixing. I'm a -1 now. Will get to it
>> Sunday/Monday. Thanks for the sets of eyes everyone.
>>
>
> Thank
On Fri, Jun 9, 2017 at 2:51 PM, Rob Tompkins wrote:
>
> This time I mean it. Heh... :-)
>
> I agree on the items needing fixing. I'm a -1 now. Will get to it
> Sunday/Monday. Thanks for the sets of eyes everyone.
>
Thank you for RM'ing!
Gary
>
> Cheers,
> -Rob
>
> > On Jun 9, 2017, at 3:08 PM
This time I mean it. Heh... :-)
I agree on the items needing fixing. I'm a -1 now. Will get to it
Sunday/Monday. Thanks for the sets of eyes everyone.
Cheers,
-Rob
> On Jun 9, 2017, at 3:08 PM, Gary Gregory wrote:
>
>> On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins wrote:
>>
>>
>>
>>> On
On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins wrote:
>
>
> > On Jun 9, 2017, at 12:17 PM, Oliver Heger
> wrote:
> >
> > Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
> >
> > Remarks:
> > - The NOTICE file has an incorrect copyright year (-2016).
>
That should be fixed IM
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
Created one image containing maven with ibmjava8, same can be pushed to
apache dockerhub repo
https://hub.docker.com/r/ameyjadiye/ibmjava8/
---
If your project is set up for it, you
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121188654
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_insta
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121184938
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_insta
Does Animal Sniffer check this? It wasn't clear from eyeballing the code if
it paid much attention to annotations apart from its own, but it all
depends on a possible twisty maze of delegation in as, so I'm uncertain.
On Jun 9, 2017 11:55 AM, "Gary Gregory" wrote:
> That would require that the
> On Jun 9, 2017, at 12:17 PM, Oliver Heger
> wrote:
>
> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
>
> Remarks:
> - The NOTICE file has an incorrect copyright year (-2016).
> - The binary distribution has a different structure than binaries
> released for other co
Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
Remarks:
- The NOTICE file has an incorrect copyright year (-2016).
- The binary distribution has a different structure than binaries
released for other components. For instance, it contains only the jar,
but no Javadoc or Sour
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162806
--- Diff: pom.xml ---
@@ -150,7 +150,7 @@
-clean test apache-rat:check clirr:check checkstyle:check
findbugs:check javadoc:
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162871
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_install
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162778
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_install
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162518
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_install
That would require that the animal sniffer plugin be setup for components
that do want to go that way. Doable if there is a sig file for the right
Java version for that component.
Gary
On Jun 9, 2017 8:13 AM, "Simon Spero" wrote:
> On Thu, Jun 8, 2017 at 12:19 PM, Gary Gregory
> wrote:
>
> > >
On Thu, Jun 8, 2017 at 12:19 PM, Gary Gregory
wrote:
> > 3. JDK9 adds some extra parameters to the Deprecated annotation (most
> notably forRemoval=true, which is used to indicate that the annotated item
> is really really deprecated.) It's not needed in this case, but is
> worth thinking abo
Hello Rob,
Here are my observations:
- link to the tag in the vote mail points to a commit, not a tag
- site looks good
- RELEASE-NOTES are missing in the dist area
- signatures look good
- build works with:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T21:39:06+02:00
Hello,
we have fixed quite a few bugs and added some nice new features since Commons
Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC4.
The only change compared to RC3 is a partial revert of LANG-1334: The compile
time constants in CharEncoding (which has also been
Hello,
> Am 09.06.2017 um 11:25 schrieb sebb :
>
> If the intention of the change was to ensure that the values were
> correct, then there are two alternative option:
>
> 1) add a test to check the values
I’ve implemented this proposal in 5ffb6620
> 2) add assertions in the class to check the
If the intention of the change was to ensure that the values were
correct, then there are two alternative option:
1) add a test to check the values
2) add assertions in the class to check the values
On 9 June 2017 at 08:07, Benedikt Ritter wrote:
>
>> Am 09.06.2017 um 08:44 schrieb Duncan Jone
Github user coveralls commented on the issue:
https://github.com/apache/commons-cli/pull/12
[](https://coveralls.io/builds/11900307)
Coverage increased (+0.009%) to 96.244% when pulling
**aea58f8677e55513ae281
GitHub user schaumb opened a pull request:
https://github.com/apache/commons-cli/pull/12
[CLI-274] implement EXISTING_FILE_VALUE type handler
when the user pass option type FileInputStream.class, I think the expected
behavior for the return value is the same type, which the user pas
Github user joehni commented on the issue:
https://github.com/apache/commons-text/pull/45
In Maven "verify" implies "test", since "verify" is a later step in the
Maven [build
lifecycle](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Build_Lifecycle_Basi
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
Hi @garydgregory , I think removing ``` test ``` is not good idea, better
we can have ```verify``` along with ```test```
---
If your project is set up for it, you can reply to this email and
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121062216
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
+
+before_insta
> Am 09.06.2017 um 08:44 schrieb Duncan Jones :
>
> On Fri, 9 Jun 2017 at 02:35, Gary Gregory wrote:
>
>> On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote:
>>
>>> There is a one other compatibility issue, which can be seen in the
>> attached
>>> code:
>>>
>>> import java.nio.charset.Standar
30 matches
Mail list logo
