Re: [math] Proposed resolution for MATH-1284

2017-05-08 Thread Matt Sicker
Oh, nevermind then. :) On 8 May 2017 at 09:21, Raymond DeCampo wrote: > On Sun, May 7, 2017 at 5:22 PM, Matt Sicker wrote: > > > I find using "tuples" here confusing since a tuple can have multiple > types, > > while a vector or point are all the same type (given the space it's in, > so > > rea

Re: [math] Proposed resolution for MATH-1284

2017-05-08 Thread Raymond DeCampo
On Sun, May 7, 2017 at 5:22 PM, Matt Sicker wrote: > I find using "tuples" here confusing since a tuple can have multiple types, > while a vector or point are all the same type (given the space it's in, so > reals -> doubles for example). > > There is no mention of tuples in the code, only in my

Re: [Numbers] NUMBERS-33

2017-05-08 Thread Gilles
Hello Stian. On Mon, 8 May 2017 10:01:48 +0100, Stian Soiland-Reyes wrote: Thanks! Thanks for taking the time to review. :-) Not being a mathematician I am afraid I have not been able to review the correctness of the equation use. I didn't either; I assumed to be correctness as per year

Re: [Numbers] NUMBERS-33

2017-05-08 Thread Stian Soiland-Reyes
Thanks! Not being a mathematician I am afraid I have not been able to review the correctness of the equation use. Overall the addition looks good and well commented. The javadoc is a bit sparse and could do with some more hyperlinks. I have some code design questions you may be able to clarify: