Github user garydgregory commented on the issue:
https://github.com/apache/commons-compress/pull/23
Thank you for your patch. The only thing missing at first glance is a patch
to `org.apache.commons.compress.compressors.CompressorStreamFactory`.
---
If your project is set up for it,
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257946
--- Diff: pom.xml ---
@@ -68,6 +68,12 @@ jar, tar, zip, dump, 7z, arj.
test
+ org.brotli
+ dec
+
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/23
Many thanks Philippe
see my comments on the test.
Also I haven't checked whether the brotli lib is an OSGi bundle, we may
need to update the bundle-plugin configuration.
-
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257473
--- Diff: pom.xml ---
@@ -85,6 +91,13 @@ jar, tar, zip, dump, 7z, arj.
${powermock.version}
test
+
+
Github user bindul commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257132
--- Diff: pom.xml ---
@@ -68,6 +68,12 @@ jar, tar, zip, dump, 7z, arj.
test
+ org.brotli
+ dec
+
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/23
[](https://coveralls.io/builds/11327289)
Coverage decreased (-0.09%) to 84.202% when pulling
**3763178324921dc41
GitHub user pmouawad opened a pull request:
https://github.com/apache/commons-compress/pull/23
Add Brotli Support
Fix for:
https://issues.apache.org/jira/browse/COMPRESS-392
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pmou
Hi, Gary,
On Mon, May 1, 2017 at 12:57 AM, Gary Evesson wrote:
> I have a potential bugfix/patch for DBCP but I cannot create a PR on the
> GitHub site because I cannot push a branch. Any ideas on how I can get it
> submitted?
there is no need to do that on Github. It's perfectly fine (or even
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/22
[](https://coveralls.io/builds/11326518)
Coverage increased (+0.04%) to 84.329% when pulling
**0f74248f5fcfdcc4f
Great idea!
Gary
On Mon, May 1, 2017 at 7:36 PM, Matt Sicker wrote:
> What about a fluent package for classes like this so you can still call it
> StopWatch?
>
> On 1 May 2017 at 21:02, Gary Gregory wrote:
>
> > I am down to copying StopWatch as FluentStopWatch and adding "return
> this;"
> >
What about a fluent package for classes like this so you can still call it
StopWatch?
On 1 May 2017 at 21:02, Gary Gregory wrote:
> I am down to copying StopWatch as FluentStopWatch and adding "return this;"
> to all the void methods.
>
> I can so that in my code base but does it induce vomiting
I am down to copying StopWatch as FluentStopWatch and adding "return this;"
to all the void methods.
I can so that in my code base but does it induce vomiting if Commons Lang
has both StopWatch AND FluentStopWatch?
Gary
On Sun, Apr 30, 2017 at 2:47 PM, Gary Gregory
wrote:
> Sorry, Commons Lang
> On May 1, 2017, at 8:25 PM, Stian Soiland-Reyes wrote:
>
> Adding a class with a plan to @deprecate it, something doesn't sound right.
> :)
>
> We should not be putting much effort (and future maintainability) into
> adding functionality in Lang that jdk8 already (easily) can do. The point
>
Adding a class with a plan to @deprecate it, something doesn't sound right.
:)
We should not be putting much effort (and future maintainability) into
adding functionality in Lang that jdk8 already (easily) can do. The point
of Lang is to complement JDK's Lang classes and friends, not to backport
w
> On May 1, 2017, at 7:44 PM, Gilles wrote:
>
> Hi.
>
> There are some issues reported that come with a proposed fix.
> If you think that the change is adequate, do not hesitate to
> apply it. E.g.:
> https://issues.apache.org/jira/browse/MATH-1381
> https://issues.apache.org/jira/browse/MATH-
On Tue, 02 May 2017 01:44:28 +0200, Gilles wrote:
Hi.
There are some issues reported that come with a proposed fix.
If you think that the change is adequate, do not hesitate to
apply it. E.g.:
https://issues.apache.org/jira/browse/MATH-1381
https://issues.apache.org/jira/browse/MATH-1400
Als
GitHub user anthonyraymond opened a pull request:
https://github.com/apache/commons-io/pull/36
FileAlternationMonitor#stop() not stop the thread
The thread if FileAlterationMonitor wasn't stopped by the `stop(int)`
method, which forbid application to shutdown unless all `Thread` are
Hi.
There are some issues reported that come with a proposed fix.
If you think that the change is adequate, do not hesitate to
apply it. E.g.:
https://issues.apache.org/jira/browse/MATH-1381
https://issues.apache.org/jira/browse/MATH-1400
Some may be fixed already. If you can confirm it, do no
In my mind, we target a given platform, in this case its Java 7. So the
proposal is valid IMO. Then when switch to Java 8, we can mark the class as
deprecated and remove it in 4.0. I'm not hard set on including this
specific class, it's just something I use.
Gary
On Mon, May 1, 2017 at 1:36 PM, R
> On May 1, 2017, at 4:33 PM, Gary Gregory wrote:
>
> True. I wonder if we need to make some kind of documented statement that we
> will not provide utils for things easily done in Java 8?
>
I wonder if we would want to wait until Java 9 general availability to make
such a statement. But tha
Github user pmouawad closed the pull request at:
https://github.com/apache/commons-codec/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
True. I wonder if we need to make some kind of documented statement that we
will not provide utils for things easily done in Java 8?
Gary
On Mon, May 1, 2017 at 1:13 PM, Matt Benson wrote:
> This is dead easy in Java 8:
>
> Comparator.comparing(Object::toString)
>
> Granted, you have to do a li
This is dead easy in Java 8:
Comparator.comparing(Object::toString)
Granted, you have to do a little more for null handling, but I'm not sure
it's worth writing out a class definition in this form. If we are intending
to cater to pre Java 8 clients, okay, but it seems a little late in the
game to
GitHub user pmouawad opened a pull request:
https://github.com/apache/commons-codec/pull/6
Add Brotli support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pmouawad/commons-codec BROTLI_SUPPORT
Alternatively you can review and
Hi All:
Do you think this is general enough for [lang]?
/**
* Implements {@code Comparator} using toString()s.
*
*/
public final class ObjectToStringComparator implements Comparator,
Serializable {
private static final long serialVersionUID = 1L;
@Override
public int compare(fina
Github user asfgit closed the pull request at:
https://github.com/apache/commons-io/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user asfgit closed the pull request at:
https://github.com/apache/commons-io/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
See https://github.com/apache/commons-dbcp/blob/master/CONTRIBUTING.md
for details
On 1 May 2017 at 00:17, Matt Sicker wrote:
> You can fork the repo and make a PR that way. The GitHub repos are
> read-only mirrors.
>
> On 30 April 2017 at 17:57, Gary Evesson wrote:
>
>> I have a potential bugf
On Mon, 1 May 2017 09:08:23 +1000, Peter Ansell wrote:
Jenkins now requires Java-8 as its base runtime environment on the
regular release channel, with its LTS channel moving to Java-8 in a
few weeks:
https://jenkins.io/blog/2017/04/10/jenkins-has-upgraded-to-java-8/
Thanks for the notice.
As
The purposed implementation at
https://github.com/apache/commons-lang/pull/223 returns false if the
string contains any non-alphabetic characters.
e.g.:
StringUtils.isMixedCase(null)= false
StringUtils.isMixedCase("") = false
StringUtils.isMixedCase("aBc") = true
StringUtils.isMixedC
O.k., I have just merged the pull request.
Am 29.04.2017 um 11:26 schrieb Benedikt Ritter:
+1, add it!
Am 28.04.2017 um 17:07 schrieb Matt Sicker :
This one I like. Could be handy in implementing things like permissive
configuration parsing and other similar things.
On 28 April 2017 at 09:57
31 matches
Mail list logo
