Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
On Mon, Apr 17, 2017 at 11:48 PM, Benedikt Ritter wrote: > Hello, > > > Am 18.04.2017 um 08:32 schrieb Gary Gregory : > > > > On Mon, Apr 17, 2017 at 11:23 PM, Benedikt Ritter > > > wrote: > > > >> Hello, > >> > >>> Am 17.04.2017 um 21:19 schrieb Gary Gregory : > >>> >

Re: [lang] new concurrency annotations

2017-04-17 Thread Benedikt Ritter
Hi, > Am 18.04.2017 um 08:36 schrieb Gary Gregory : > > Hi All: > > We have two styles for the new concurrency annotations in master: > > (1) JCIP > (2) Apache HttpComponents Core > > I would like to delete (1) in favor of (2). I started this discussion > inappropriately on a VOTE thread, sorr

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-17 Thread Benedikt Ritter
Hi, > Am 18.04.2017 um 08:46 schrieb Gary Gregory : > > Because if you use multiple annotations, you (or tools) can write silly > things like: > > @ThreadSafe > @NotThreadSafe > public class Foo { > … > } Thank you for the clarification. It makes complete sense to me. Given this reason I’m f

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Benedikt Ritter
Hello, > Am 18.04.2017 um 08:32 schrieb Gary Gregory : > > On Mon, Apr 17, 2017 at 11:23 PM, Benedikt Ritter > > wrote: > >> Hello, >> >>> Am 17.04.2017 um 21:19 schrieb Gary Gregory : >>> >>> On Mon, Apr 17, 2017 at 12:01 PM, Gary Gregory >

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-17 Thread Gary Gregory
Because if you use multiple annotations, you (or tools) can write silly things like: @ThreadSafe @NotThreadSafe public class Foo { ... } Gary On Mon, Apr 17, 2017 at 11:27 PM, Benedikt Ritter wrote: > Hello Gary, > > Can you please explain why you think it is better to use a single > parame

[lang] new concurrency annotations

2017-04-17 Thread Gary Gregory
Hi All: We have two styles for the new concurrency annotations in master: (1) JCIP (2) Apache HttpComponents Core I would like to delete (1) in favor of (2). I started this discussion inappropriately on a VOTE thread, sorry for the redo. Then we can proceed with another release candidate. Also

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
On Mon, Apr 17, 2017 at 11:23 PM, Benedikt Ritter wrote: > Hello, > > > Am 17.04.2017 um 21:19 schrieb Gary Gregory : > > > > On Mon, Apr 17, 2017 at 12:01 PM, Gary Gregory > > > wrote: > > > >> I am also wondering if the package should be the more > >> generic org

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-17 Thread Benedikt Ritter
Hello Gary, Can you please explain why you think it is better to use a single parameterized annotation over several individual annotations? Thank you! Benedikt > Am 17.04.2017 um 20:54 schrieb ggreg...@apache.org: > > Repository: commons-lang > Updated Branches: > refs/heads/master 5242157df

[CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Benedikt Ritter
Hello, > Am 17.04.2017 um 15:01 schrieb Benedikt Ritter : > > Hello, > > we have fixed quite a few bugs and added some nice new features since Commons > Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on > RC1. > > Commons Lang 3.6 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Benedikt Ritter
Hello, > Am 17.04.2017 um 21:19 schrieb Gary Gregory : > > On Mon, Apr 17, 2017 at 12:01 PM, Gary Gregory > > wrote: > >> I am also wondering if the package should be the more >> generic org.apache.commons.lang3.annotation instead >> of org.apache.commons.lang3.co

Re: [ALL] The Commons Math issue

2017-04-17 Thread Gary Gregory
On Apr 17, 2017 3:32 PM, "Gilles" wrote: Hi Ralph. On Sun, 16 Apr 2017 10:55:49 -0700, Ralph Goers wrote: > Gilles, > > What is your vision on where things should end up? Can you identify > what new commons sub-projects we will have? If it is just 3 or 4 I > have no problem with that. > We

Re: [ALL] The Commons Math issue

2017-04-17 Thread Gilles
Hi Ralph. On Sun, 16 Apr 2017 10:55:49 -0700, Ralph Goers wrote: Gilles, What is your vision on where things should end up? Can you identify what new commons sub-projects we will have? If it is just 3 or 4 I have no problem with that. We have * RNG We will have * Numbers We might have

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
On Mon, Apr 17, 2017 at 12:01 PM, Gary Gregory wrote: > I am also wondering if the package should be the more > generic org.apache.commons.lang3.annotation instead > of org.apache.commons.lang3.concurrent.annotation. > > Thoughts? > Resending, I am getting a weird bounce back saying: *newmx101.

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
I am also wondering if the package should be the more generic org.apache.commons.lang3.annotation instead of org.apache.commons.lang3.concurrent.annotation. Thoughts? Gary On Mon, Apr 17, 2017 at 11:55 AM, Gary Gregory wrote: > I've added the two types needed for HC style annotations. I think

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
I've added the two types needed for HC style annotations. I think I should wait until this VOTE in canceled (if it is) before removing the current code. Gary On Mon, Apr 17, 2017 at 11:32 AM, Oliver Heger wrote: > > > Am 17.04.2017 um 18:45 schrieb Matt Sicker: > > I prefer the annotations in H

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Oliver Heger
Am 17.04.2017 um 18:45 schrieb Matt Sicker: > I prefer the annotations in HC, too. +1 Oliver > > On 17 April 2017 at 11:25, Gary Gregory wrote: > >> On Mon, Apr 17, 2017 at 9:22 AM, Gary Gregory >> wrote: >> >>> I wish we had a heads up email on cutting an RC or maybe I missed it >> since >

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Matt Sicker
I prefer the annotations in HC, too. On 17 April 2017 at 11:25, Gary Gregory wrote: > On Mon, Apr 17, 2017 at 9:22 AM, Gary Gregory > wrote: > > > I wish we had a heads up email on cutting an RC or maybe I missed it > since > > I moved house starting Friday (I must have missed it). > > > > Whil

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
On Mon, Apr 17, 2017 at 9:22 AM, Gary Gregory wrote: > I wish we had a heads up email on cutting an RC or maybe I missed it since > I moved house starting Friday (I must have missed it). > > While I promoted the new annotations for thread safety, I am not happy > with them at all since you can sa

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Gary Gregory
I wish we had a heads up email on cutting an RC or maybe I missed it since I moved house starting Friday (I must have missed it). While I promoted the new annotations for thread safety, I am not happy with them at all since you can say nonesensical things like "@ThreadSafe @NotThreadSafe". I menti

[VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-17 Thread Benedikt Ritter
Hello, we have fixed quite a few bugs and added some nice new features since Commons Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC1. Commons Lang 3.6 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/lang (svn revision 19171) The

[GitHub] commons-cli pull request #10: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-04-17 Thread schaumb
GitHub user schaumb opened a pull request: https://github.com/apache/commons-cli/pull/10 [CLI-274] implement EXISTING_FILE_VALUE type handler when the user pass option type FileInputStream.class, I think the expected behavior for the return value is the same type, which the user pas