Re: Immutable builder pattern for parsers?

2017-02-08 Thread Matt Sicker
Looking more closely, why not use CompleteableFuture instead of Future since this is Java 8? Also, the gist of the configuration API you're looking for sounds like a way to emulate closures in Java. :) You could also add a freeze method to switch between mutable and immutable views of the factory

Re: Immutable builder pattern for parsers?

2017-02-08 Thread Matt Sicker
I'm not familiar with the code, but it sounds like you're in the early stages of a plugin system. The good old BeanFactory. Another possible way to go about untying thread safe and not thread safe parser factory builders would be using naming conventions like setters for mutable and withers for im

Re: Immutable builder pattern for parsers?

2017-02-08 Thread Gary Gregory
On Wed, Feb 8, 2017 at 7:27 PM, Matt Sicker wrote: > I've always considered builders to be mutable, thread unsafe objects used > to create immutable, thread safe objects. +1 Gary > If these builders cause GC > pressure to go too high, then I'd turn to object pooling or per-thread > reusable

Re: Immutable builder pattern for parsers?

2017-02-08 Thread Peter Ansell
Not all fluent configuration APIs are "builder patterns". By that I mean that you can have a "return this" convention for the builder with mutable fields without it building or cloning new objects. A builder pattern is characterised by a terminal method returning a new instance of an object, avoid

Re: Immutable builder pattern for parsers?

2017-02-08 Thread Matt Sicker
I've always considered builders to be mutable, thread unsafe objects used to create immutable, thread safe objects. If these builders cause GC pressure to go too high, then I'd turn to object pooling or per-thread reusable objects depending on how the code is used. On 8 February 2017 at 20:38, Sti

Immutable builder pattern for parsers?

2017-02-08 Thread Stian Soiland-Reyes
Peter Ansell raised a valid question about why in Commons RDF I made the RDFParser interface as an immutable factory-like builder pattern. https://commons.apache.org/proper/commons-rdf/apidocs/org/apache/commons/rdf/experimental/RDFParser.html Here is how it can be used today: RDF rdf = new J

[GitHub] commons-rdf issue #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread ansell
Github user ansell commented on the issue: https://github.com/apache/commons-rdf/pull/27 Service discovery for other instances of RDFSyntax/Parsers can be done separately. The main objection was for users of the RDFSyntax interface to be able to offer multiple content types

[GitHub] commons-rdf issue #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on the issue: https://github.com/apache/commons-rdf/pull/27 Let's discuss the mutability etc. of the `RDFParser` factory separate on dev@commons - that's a general thing which anyway should not affect this pull request on `RDFSyntax`. This pull req

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100211712 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100209281 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -91,7 +148,30 @@ * Datasets. */ public boolean sup

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100208441 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -178,17 +206,62 @@ private RDFSyntax(final String name, final String mediaType

Re: [RESULT][VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread Rob Tompkins
> On Feb 8, 2017, at 7:17 PM, sebb wrote: > >> On 8 February 2017 at 17:51, Rob Tompkins wrote: >> Hello, >> >> This vote passes with (in order of appearance): >> >> Oliver Heger: +1 >> Benedikt Ritter: +1 >> Thomas Vandahl: +1 >> Rob Tompkins: +1 > > Sorry to be picky, but only the PMC vot

Re: [RESULT][VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread sebb
On 8 February 2017 at 17:51, Rob Tompkins wrote: > Hello, > > This vote passes with (in order of appearance): > > Oliver Heger: +1 > Benedikt Ritter: +1 > Thomas Vandahl: +1 > Rob Tompkins: +1 Sorry to be picky, but only the PMC votes are binding, i.e. the first 3. This is still OK for the vote

[RESULT][VOTE] Release Apache Commons JCS 2.1 based on RC1

2017-02-08 Thread Thomas Vandahl
On 05.02.17 18:24, Thomas Vandahl wrote: > I would like to release the [jcs] component to resolve some bugs > > Apache Commons JCS 2.1 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/jcs/ (r18146). Time to wrap up. The following votes were cast (in order of appe

Re: [VOTE] Release Apache Commons JCS 2.1 based on RC1

2017-02-08 Thread Thomas Vandahl
Hi Oliver, On 07.02.17 21:42, Oliver Heger wrote: > I noticed that OSGi manifests of jars use the same symbolic bundle name, > e.g. for commons-jcs-core-2.1.jar and > commons-jcs-jcache-openjpa-2.1.jar. This is likely to cause problems in > an OSGi container. Thanks for the hint. I didn't know th

Re: [VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread Bruno P. Kinoshita
Hi Romain, With LC_ALL=en_US.UTF-8 it works for me. Results : Tests run: 476, Failures: 0, Errors: 0, Skipped: 0 Cheers Bruno From: Romain Manni-Bucau To: Commons Developers List ; Bruno P. Kinoshita Sent: Tuesday, 7 February 2017 6:43 AM Subject: Re: [VO

[RESULT][VOTE] Release Apache Commons Configuration 2.1.1 based on RC1

2017-02-08 Thread Benedikt Ritter
Hi, > Am 05.02.2017 um 15:23 schrieb Benedikt Ritter : > > Hi, > > we’ve fixed some bugs since the release of Commons Configuration 2.1 so I’d > like to call a vote to release Commons Configuration 2.1.1 based on RC1. > > Commons Configuration 2.1.1 RC1 is available for review here: > https:/

[RESULT][VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread Rob Tompkins
Hello, This vote passes with (in order of appearance): Oliver Heger: +1 Benedikt Ritter: +1 Thomas Vandahl: +1 Rob Tompkins: +1 I'll proceed with the release procedure. Thanks to all who reviewed this and the last RC. -Rob > On Jan 30, 2017, at 9:14 AM, Rob Tompkins wrote: > > Hello all, >

Re: [VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread Rob Tompkins
Here’s my +1. -Rob > On Feb 8, 2017, at 2:54 AM, Benedikt Ritter wrote: > > >> Am 07.02.2017 um 14:21 schrieb Rob Tompkins : >> >>> >>> On Feb 7, 2017, at 7:20 AM, Benedikt Ritter wrote: >>> >>> Hi, >>> Am 07.02.2017 um 13:04 schrieb Rob Tompkins : > > On Feb 7, 2017,

[GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #32: COMMONSRDF-55: Handle Jena's urn:x-arq:Default...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf issue #32: COMMONSRDF-55: Handle Jena's urn:x-arq:DefaultGraph a...

2017-02-08 Thread stain
Github user stain commented on the issue: https://github.com/apache/commons-rdf/pull/32 I've added javadoc to this effect (commit 7bbff25) and will merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

FINAL REMINDER: CFP for ApacheCon closes February 11th

2017-02-08 Thread Rich Bowen
Dear Apache Enthusiast, This is your FINAL reminder that the Call for Papers (CFP) for ApacheCon Miami is closing this weekend - February 11th. This is your final opportunity to submit a talk for consideration at this event. This year, we are running several mini conferences in conjunction with t

Re: [VOTE] Release Apache Commons Configuration 2.1.1 based on RC1

2017-02-08 Thread Rob Tompkins
Build works fine with Java 1.6, 1.7, and 1.8 on Mac OS X 10.12.3. Artifacts and site look good. +1 -Rob > On Feb 5, 2017, at 9:23 AM, Benedikt Ritter wrote: > > Hi, > > we’ve fixed some bugs since the release of Commons Configuration 2.1 so I’d > like to call a vote to release Commons Confi

Re: [VOTE] Release Apache Commons JCS 2.1 based on RC1

2017-02-08 Thread Rob Tompkins
Build works on Mac, Java 6, 7, 8. Site seems to only work on 7 (but that’s been mentioned already). Artifacts look good, site looks good. +1 > On Feb 5, 2017, at 12:24 PM, Thomas Vandahl wrote: > > I would like to release the [jcs] component to resolve some bugs > > Apache Commons JCS 2.1 RC

Re: [VOTE] Release Commons Text 1.0-beta-1 based on RC4

2017-02-08 Thread Rob Tompkins
> On Feb 8, 2017, at 2:54 AM, Benedikt Ritter wrote: > > >> Am 07.02.2017 um 14:21 schrieb Rob Tompkins : >> >>> >>> On Feb 7, 2017, at 7:20 AM, Benedikt Ritter wrote: >>> >>> Hi, >>> Am 07.02.2017 um 13:04 schrieb Rob Tompkins : > > On Feb 7, 2017, at 6:23 AM, sebb wr