Re: RDF commons testing

2017-01-28 Thread Peter Ansell
On 28 January 2017 at 21:08, Claude Warren wrote: > I see that RDF Commons is listed as a set of interfaces to be implemented > on top of various RDF implementations. I also see that there are abstract > tests for the interfaces. > > I would like to suggest that RDF commons look at using Junit Co

Re: [Numbers] Further work on NUMBERS-6

2017-01-28 Thread Gilles
Hi. On Sat, 28 Jan 2017 14:38:21 -0500, Raymond DeCampo wrote: [...] Now, for the contents of the "fraction" module. (1) My main current concern is the formatting-related classes; as for "complex", I think that 1. formatting (and I/O) is out of scope, and 2. the implementation were problemat

Re: StringUtils.isEmpty() family of methods on Objects

2017-01-28 Thread Stian Soiland-Reyes
Agree with Benedikt here, if it's only the .toString() that is important, then "string" should appear in the method name; otherwise we need to do Commons Collections style handling of anything that can be empty or not. To support null (which isn't really "empty" but missing), perhaps just have the

Re: StringUtils.isEmpty() family of methods on Objects

2017-01-28 Thread Matt Benson
Like Bene, this feels a little off to me. Just for argument's sake, let's look at: Optional.ofNullable(foo).map(Object::toString).filter(StringUtils::isNotBlank).isPresent(); Assuming you're on Java 8, of course. It's a bit long, but not horrible. What about, in a Java 8-compatible version of [la

Re: [Numbers] Further work on NUMBERS-6 (Was: [5/5] Add maven module for fractions [...])

2017-01-28 Thread Raymond DeCampo
On Sat, Jan 28, 2017 at 10:48 AM, Gilles wrote: > On Sat, 28 Jan 2017 09:00:52 -0500, Raymond DeCampo wrote: > >> Thanks for the feedback Gilles. >> > > Thanks for helping with the project! > > I generally prefer to work in smaller increments so that suits me fine. >> >> Re working on an outdated

Re: StringUtils.isEmpty() family of methods on Objects

2017-01-28 Thread Gary Gregory
If you look at the link Matt provided, that handles arrays and collection, but not Object.toString() Gary On Jan 28, 2017 1:13 AM, "Benedikt Ritter" wrote: > Am 28.01.2017 um 02:53 schrieb Gary Gregory : > > The simplest examples I have on hand are instances of Path and URI which > can be buil

[Numbers] Further work on NUMBERS-6 (Was: [5/5] Add maven module for fractions [...])

2017-01-28 Thread Gilles
On Sat, 28 Jan 2017 09:00:52 -0500, Raymond DeCampo wrote: Thanks for the feedback Gilles. Thanks for helping with the project! I generally prefer to work in smaller increments so that suits me fine. Re working on an outdated branch, I'm not sure I completely understand what you want plus

Re: [5/5] commons-numbers git commit: Add maven module for fractions package from commons-math Resolves pull request #4

2017-01-28 Thread Raymond DeCampo
Thanks for the feedback Gilles. I generally prefer to work in smaller increments so that suits me fine. Re working on an outdated branch, I'm not sure I completely understand what you want plus I am not a git expert by any stretch. Are you suggesting I back out the changes on the multimodule bra

Re: [5/5] commons-numbers git commit: Add maven module for fractions package from commons-math Resolves pull request #4

2017-01-28 Thread Gilles
Hi Ray. On Sat, 28 Jan 2017 12:44:27 -, raydeca...@apache.org wrote: Add maven module for fractions package from commons-math Resolves pull request #4 Whenever possible, we aim at small commits (unless they are all of the same kind, and it is obvious what is being done repeatedly). In par

RDF commons testing

2017-01-28 Thread Claude Warren
I see that RDF Commons is listed as a set of interfaces to be implemented on top of various RDF implementations. I also see that there are abstract tests for the interfaces. I would like to suggest that RDF commons look at using Junit Contract tests (https://github.com/Claudenw/junit-contracts) w

Re: StringUtils.isEmpty() family of methods on Objects

2017-01-28 Thread Benedikt Ritter
> Am 28.01.2017 um 02:53 schrieb Gary Gregory : > > The simplest examples I have on hand are instances of Path and URI which > can be built with an empty string. I want to know if these are "empty". For > the app I am now on for example, a Path or null and "" should be treated > the same. Same fo