Re: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

2016-08-23 Thread Gary Gregory
On Tue, Aug 23, 2016 at 2:36 PM, sebb wrote: > On 23 August 2016 at 22:17, Gary Gregory wrote: > > I was thinking of keeping the list in a text file and sorting it manually > > at dev time when it needs to be updated. I'm sure there's some command > line > > to do that... Then it's just the cost

Re: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

2016-08-23 Thread sebb
On 23 August 2016 at 22:17, Gary Gregory wrote: > I was thinking of keeping the list in a text file and sorting it manually > at dev time when it needs to be updated. I'm sure there's some command line > to do that... Then it's just the cost of reading the file. Which is still an unnecessary cost

Re: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

2016-08-23 Thread Gary Gregory
I was thinking of keeping the list in a text file and sorting it manually at dev time when it needs to be updated. I'm sure there's some command line to do that... Then it's just the cost of reading the file. Gary On Tue, Aug 23, 2016 at 1:54 PM, sebb wrote: > This was discussed at length some

Re: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

2016-08-23 Thread sebb
This was discussed at length some time ago. Yes, it would be possible to read the information in and sort it at run-time, however that would increase the startup time. It's a bit more effort to pre-sort the entries in the code, but that only has to be done when the list is updated (i.e. at least

Re: [VOTE][RESULT] Migrate Apache Commons DBCP to Git

2016-08-23 Thread Matt Sicker
Infra ticket: https://issues.apache.org/jira/browse/INFRA-12482 On 23 August 2016 at 14:36, Matt Sicker wrote: > The vote has passed by lazy consensus. > > +1 Gary Gregory > +1 Jochen Wiedmann > > I will notify infra about the repository. I'm not sure on the specifics, > but I believe we should

[VOTE][RESULT] Migrate Apache Commons DBCP to Git

2016-08-23 Thread Matt Sicker
The vote has passed by lazy consensus. +1 Gary Gregory +1 Jochen Wiedmann I will notify infra about the repository. I'm not sure on the specifics, but I believe we should avoid committing to dbcp via svn until it's been migrated. -- Matt Sicker

Fwd: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

2016-08-23 Thread Gary Gregory
I wonder if we should have these in a text file that is read in from a static block? It would be easier to sort at least. Gary -- Forwarded message -- From: Date: Tue, Aug 23, 2016 at 11:27 AM Subject: svn commit: r1757416 - /commons/proper/validator/trunk/src/main/java/org/apach

Re: [rng] Coveralls ? (Was: Travis ?)

2016-08-23 Thread Rob Tompkins
> On Aug 23, 2016, at 6:06 AM, Gilles wrote: > > On Mon, 22 Aug 2016 20:24:15 -0400, Rob Tompkins wrote: >>> On Aug 21, 2016, at 4:11 PM, Gilles wrote: >>> On Sat, 20 Aug 2016 16:02:50 +0200, Sergio Fernández wrote: Just add the build configuration (.travis.yml) to the repo and ask

[rng] Coveralls ? (Was: Travis ?)

2016-08-23 Thread Gilles
On Mon, 22 Aug 2016 20:24:15 -0400, Rob Tompkins wrote: On Aug 21, 2016, at 4:11 PM, Gilles wrote: On Sat, 20 Aug 2016 16:02:50 +0200, Sergio Fernández wrote: Just add the build configuration (.travis.yml) to the repo and ask INFRA to enable it. Issue filed: https://issues.apache.org/jir

[GitHub] commons-validator pull request #7: Validating ISIN codes

2016-08-23 Thread raupachz
GitHub user raupachz opened a pull request: https://github.com/apache/commons-validator/pull/7 Validating ISIN codes An International Securities Identification Number (ISIN) uniquely identifies a security. Its structure is defined in ISO 6166. The isin uses country codes and Luhn a

Re: Moving components to git - what to do with the SVN tree

2016-08-23 Thread Jochen Wiedmann
On Thu, Aug 18, 2016 at 4:27 PM, sebb wrote: > Note that this leaves all the _moved_to_git files writable by the PMC. I fail to consider that a problem. It is SVN, after all, so the initial state will always be restorable. Jochen -- The next time you hear: "Don't reinvent the wheel!" http:/