RE: [CRYPTO] JIRA fix comments should please link to the Git change

2016-06-16 Thread Sun, Dapeng
+1, thank Sebb for adding these comments. Regards Dapeng -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Thursday, June 16, 2016 9:40 PM To: CommonsDev Subject: [CRYPTO] JIRA fix comments should please link to the Git change When fixing a JIRA issue, it's very helpful if t

Re: [dbcp] Bad method name

2016-06-16 Thread sebb
On 16 June 2016 at 10:58, Marc Doberva wrote: > Hi > > > > I am using DBCP2-2.1.1 and there is a little bug in class > org.apache.commons.dbcp2.PoolableConnectionFactory : > > > > The name of the setter is setMaxOpenPrepatedStatements : a 'T' instead of a > 'R' in .prepared.. > > > > So to set the

[dbcp] Bad method name

2016-06-16 Thread Marc Doberva
Hi I am using DBCP2-2.1.1 and there is a little bug in class org.apache.commons.dbcp2.PoolableConnectionFactory : The name of the setter is setMaxOpenPrepatedStatements : a 'T' instead of a 'R' in .prepared.. So to set the maxOpenPreparedStatements parameter you must define the maxOpenP

[CRYPTO] JIRA fix comments should please link to the Git change

2016-06-16 Thread sebb
When fixing a JIRA issue, it's very helpful if the details of the commit are added as part of the comment. I've done this for some recent commits. Thanks. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For addition

[CRYPTO] Possible new method for CryptoCipher interface; API evolution

2016-06-16 Thread sebb
I have been looking at creating examples for Crypto. It occurred to me that a common use case is encryption/decryption of small chunks of data that can readily be stored in a local byte array. For such cases, there is no need to use both update() and doFinal(). Having to provide the input array o