> On Dec 26, 2015, at 4:07 PM, Gilles wrote:
>
>> On Sat, 26 Dec 2015 15:32:04 -0700, Phil Steitz wrote:
>>> On 12/26/15 10:52 AM, Gilles wrote:
>>> Hi.
>>>
>>> There are currently two RNG hierarchies: "AbstractRandomGenerator"
>>> and
>>> "BitsStreamGenerator". They both implement the "Random
On 12/26/2015 05:22 PM, Gilles wrote:
On Sat, 26 Dec 2015 16:21:04 -0600, Ole Ersoy wrote:
Hi,
What do you think of removing iterator(), Entry, and Iterator() from
RealVector? ArrayRealVector can replace these with Vector...I
think...Still need to attempt it. Vector is synchronized so it ma
On Sat, 26 Dec 2015 15:32:04 -0700, Phil Steitz wrote:
On 12/26/15 10:52 AM, Gilles wrote:
Hi.
There are currently two RNG hierarchies: "AbstractRandomGenerator"
and
"BitsStreamGenerator". They both implement the "RandomGenerator"
interface.
In both classes, the "nextBytes(byte[])" method gene
On Sat, 26 Dec 2015 16:21:04 -0600, Ole Ersoy wrote:
Hi,
What do you think of removing iterator(), Entry, and Iterator() from
RealVector? ArrayRealVector can replace these with Vector...I
think...Still need to attempt it. Vector is synchronized so it makes
it easier to make ArrayRealVector thr
On Sat, 26 Dec 2015 15:32:04 -0700, Phil Steitz wrote:
On 12/26/15 10:52 AM, Gilles wrote:
Hi.
There are currently two RNG hierarchies: "AbstractRandomGenerator"
and
"BitsStreamGenerator". They both implement the "RandomGenerator"
interface.
In both classes, the "nextBytes(byte[])" method gene
On 12/26/15 10:52 AM, Gilles wrote:
> Hi.
>
> There are currently two RNG hierarchies: "AbstractRandomGenerator"
> and
> "BitsStreamGenerator". They both implement the "RandomGenerator"
> interface.
>
> In both classes, the "nextBytes(byte[])" method generates 4 bytes
> at a time.
> Thus, functiona
Hi,
What do you think of removing iterator(), Entry, and Iterator() from
RealVector? ArrayRealVector can replace these with Vector...I think...Still
need to attempt it. Vector is synchronized so it makes it easier to make
ArrayRealVector thread safe.
Cheers,
Ole
--
On 12/26/2015 02:41 PM, Phil Steitz wrote:
On 12/26/15 11:12 AM, Gilles wrote:
On Sat, 26 Dec 2015 10:21:30 -0600, Ole Ersoy wrote:
In RealVector there is an isInfinite() method that checks for
isInfinite() and isNan() at the same time. If any coordinate is
infinite, it will return true...un
On 12/26/15 10:52 AM, Gilles wrote:
> Hi.
>
> There are currently two RNG hierarchies: "AbstractRandomGenerator"
> and
> "BitsStreamGenerator". They both implement the "RandomGenerator"
> interface.
>
> In both classes, the "nextBytes(byte[])" method generates 4 bytes
> at a time.
> Thus, functiona
On 12/26/15 11:12 AM, Gilles wrote:
> On Sat, 26 Dec 2015 10:21:30 -0600, Ole Ersoy wrote:
>> In RealVector there is an isInfinite() method that checks for
>> isInfinite() and isNan() at the same time. If any coordinate is
>> infinite, it will return true...unless a value is Nan...then it will
>>
Thanks a lot for a thorough review ! This vote is cancelled for an
immedieate respin.
Kristian
2015-12-26 18:34 GMT+01:00 Phil Steitz :
> Sigs and hashes are good.
>
> Release contents are good.
>
> Ant and maven builds both tested on 1.7, 1.8.
>
> Coburta disease has been cured - tests run cle
Le 26/12/2015 18:52, Gilles a écrit :
> Hi.
>
> There are currently two RNG hierarchies: "AbstractRandomGenerator" and
> "BitsStreamGenerator". They both implement the "RandomGenerator" interface.
>
> In both classes, the "nextBytes(byte[])" method generates 4 bytes at a
> time.
> Thus, functiona
On 12/26/2015 12:12 PM, Gilles wrote:
On Sat, 26 Dec 2015 10:21:30 -0600, Ole Ersoy wrote:
In RealVector there is an isInfinite() method that checks for
isInfinite() and isNan() at the same time. If any coordinate is
infinite, it will return true...unless a value is Nan...then it will
return
On Sat, 26 Dec 2015 10:21:30 -0600, Ole Ersoy wrote:
In RealVector there is an isInfinite() method that checks for
isInfinite() and isNan() at the same time. If any coordinate is
infinite, it will return true...unless a value is Nan...then it will
return false. I'm probably missing something...
Hi.
There are currently two RNG hierarchies: "AbstractRandomGenerator" and
"BitsStreamGenerator". They both implement the "RandomGenerator"
interface.
In both classes, the "nextBytes(byte[])" method generates 4 bytes at a
time.
Thus, functionally the code is the same, even though one calls
"
Sigs and hashes are good.
Release contents are good.
Ant and maven builds both tested on 1.7, 1.8.
Coburta disease has been cured - tests run cleanly against the
release jar.
Unfortunately, the NOTICE file still has not had the copyright date
updated.
I think that is a blocker, so -1 from me.
On 12/26/15 9:54 AM, Gilles wrote:
> On Sat, 26 Dec 2015 16:51:40 + (UTC), pste...@apache.org wrote:
>> Repository: commons-math
>> Updated Branches:
>> refs/heads/MATH_3_X 41642 -> cc893e499
>>
>>
>> Reverted unecessary escapes.
>
> Wow, that was fast!
>
> Gilles (happy again).
He he.
On Sat, 26 Dec 2015 16:51:40 + (UTC), pste...@apache.org wrote:
Repository: commons-math
Updated Branches:
refs/heads/MATH_3_X 41642 -> cc893e499
Reverted unecessary escapes.
Wow, that was fast!
Gilles (happy again).
[...]
--
Hi Phil.
I'm opposed to changing the likes of
{@code n <= 0}
into
{@code n ≤ 0}
on the ground that for a _source_ code reader it is obviously less
readable.
I tried to clean up the Javadoc from such HTML entities... :-/
Thanks,
Gilles
On Sat, 26 Dec 2015 16:38:38 + (UTC), pste...@apache.
In RealVector there is an isInfinite() method that checks for isInfinite() and
isNan() at the same time. If any coordinate is infinite, it will return
true...unless a value is Nan...then it will return false. I'm probably missing
something...but it seems like isInfinite() should return true i
20 matches
Mail list logo
