Re: [LANG] Adding null safe compare methods in StringUtils

2015-10-20 Thread Benedikt Ritter
Hello Loic, looks good to me, but you should remove the System.out.println calls. Regards, Benedikt 2015-10-20 17:28 GMT+02:00 Loic Guibert : > I've updated my pull request if you want to look at what I plan to do > concerning methods exclusion in > StringUtilsTest.testStringUtilsCharSequenceCo

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Benedikt Ritter
Hello Loic, sounds good to me. Go for it. Benedikt 2015-10-20 9:52 GMT+02:00 Loïc Guibert : > Hello, > I proposed some time ago to add in StringUtils 2 null safe methods > to replace into a String with regular expression > and I'd like to hear opinions about that. > > I opened a JIRA ticket (LA

Write access for ASF committers to our git repositories

2015-10-20 Thread Benedikt Ritter
Hello, Sergio has indicated, that he can not push to the Commons Lang git repository [1]. Since we decided to grant write access to our repositories to all ASF committers [2], I had expected that this would apply to the git repositories as well. Does this need any special set up? Regards, Benedik

Re: [LANG] Adding null safe compare methods in StringUtils

2015-10-20 Thread Loic Guibert
I've updated my pull request if you want to look at what I plan to do concerning methods exclusion in StringUtilsTest.testStringUtilsCharSequenceContract() https://github.com/apache/commons-lang/pull/110 https://github.com/apache/commons-lang/commit/131917a0d3303ca2c38fd1d6765b9bed2c23ff89 Loic

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Loïc Guibert
Hello, I proposed some time ago to add in StringUtils 2 null safe methods to replace into a String with regular expression and I'd like to hear opinions about that. I opened a JIRA ticket (LANG-1139) : https://issues.apache.org/jira/browse/LANG-1139 and an associated Pull Request (#92) : https://

Re: [LANG] Adding null safe compare methods in StringUtils

2015-10-20 Thread Loic Guibert
Hi Benedikt, There are exactly the two options I was considering. If nobody objects, I'll go on the second way and exclude those methods in StringUtilsTest.testStringUtilsCharSequenceContract(). This is closer to Java conception where CharSequence are not comparable and comparing two CharSequence

Re: [LANG] Drop Ant build?

2015-10-20 Thread Emmanuel Bourg
Le 20/10/2015 08:32, Sergio Fernández a écrit : > Double check would be good, since I could missed any. I think most are old > versions, and given the package naming in Debian are still there. How many > components do actually still use Ant as build system? Another way to find the source packages

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Loic Guibert
Hello, I proposed some time ago to add in StringUtils 2 null safe methods to replace into a String with regular expression and I'd like to hear opinions about that. I opened a JIRA ticket (LANG-1139) : https://issues.apache.org/jira/browse/LANG-1139 and an associated Pull Request (#92) : https://