Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

On 10 September 2015 at 01:07, Dave Brosius wrote: > Revert if you like. Thanks! > I'm not sure how it breaks anything. The return type is > not part of a method signature, so it doesn't break reflection. The return type *is* part of the method signature. You cannot for example replace "int fil

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

Revert if you like. I'm not sure how it breaks anything. The return type is not part of a method signature, so it doesn't break reflection. You can override with a method that returns Object. You can assign to object. so not sure the issue. But it's not a big deal so, whatever. On 09/09/2015 0

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

Revert if you like. I'm not sure how it breaks anything. On 09/09/2015 01:41 PM, sebb wrote: On 9 September 2015 at 17:57, Gary Gregory wrote: On Wed, Sep 9, 2015 at 1:19 AM, sebb wrote: PING. If I don't hear any response in the next few days I will revert. Would it be helpful to post a

Refresher on -1 on code mods

Hi All: Since we just had a -1 on a code modification recently, I want to post a reminder of what a -1 means in this case, for new committers please read https://www.apache.org/foundation/voting.html, specifically: "For code-modification votes, +1 votes are in favour of the proposal, but -1 votes

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

As a reminder of what a -1 means on a commit, please see https://www.apache.org/foundation/voting.html, specifically: "For code-modification votes, +1 votes are in favour of the proposal, but -1 votes are vetos and kill the proposal dead until all vetoers withdraw their -1 votes." and: "A code-m

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

On 9 September 2015 at 17:57, Gary Gregory wrote: > On Wed, Sep 9, 2015 at 1:19 AM, sebb wrote: > >> PING. >> >> If I don't hear any response in the next few days I will revert. >> > > Would it be helpful to post a link to what a -1 on a commit means as a > refresher? By all means. > Gary > > >

Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

Hi Benedikt, Early-access builds of JDK 9 with Project Jigsaw are available for download at jdk9.java.net/jigsaw . The EA builds contain the latest prototype implementation of JSR 376 , the Java Platform Module Syste

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

On Wed, Sep 9, 2015 at 1:19 AM, sebb wrote: > PING. > > If I don't hear any response in the next few days I will revert. > Would it be helpful to post a link to what a -1 on a commit means as a refresher? Gary > On 3 September 2015 at 14:43, sebb wrote: > > @dbros...@apache.org > > > > This

[DRAFT] Report from the Apache Commons committee [Gary Gregory]

Sorry for the late post. This is what I plan on sending the board, it is due today. I can update it if you find any issues or want any changes. Thank you! Report from the Apache Commons committee [Gary Gregory] ## Description: The Apache Commons project focuses on all aspects of reusable Ja

[RESULT][VOTE][ALL] (lazy consensus) Commons Parent 39 based on RC1

Hello, there have been no objections, so I released commons-parent based on 39-RC1. The next iteration is also opened on the trunk (and I bumped ASF parent to version 17 as discussed) Gruss Bernd Am Thu, 27 Aug 2015 15:34:52 +0200 schrieb Bernd Eckenfels : > Hello All, > > > The Apache Comm

Re: svn commit: r1695425 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: generic/FieldOrMethod.java verifier/statics/Pass3aVerifier.java verifier/structurals/InstConstraintVisi

Will work in this evening. (GMT-8). Chas > On Sep 9, 2015, at 2:07 AM, sebb wrote: > > PING > > I am -1 on the commit as it stands; please revert or fix > >> On 28 August 2015 at 01:43, sebb wrote: >>> On 12 August 2015 at 07:32, wrote: >>> Author: chas >>> Date: Wed Aug 12 06:32:41 2015

Re: [BCEL] deprecation of getClassName in generic/FieldOrMethod

On 9 September 2015 at 11:11, sebb wrote: > On 4 September 2015 at 18:46, Mark Roberts wrote: >> I read and understood the comment as to the reasoning, but the problem is >> the shared code nature of FieldOrMethod. > > What comment was that? I see now, you meant the comment against the method g

Re: [BCEL] deprecation of getClassName in generic/FieldOrMethod

On 4 September 2015 at 18:46, Mark Roberts wrote: > I read and understood the comment as to the reasoning, but the problem is the > shared code nature of FieldOrMethod. What comment was that? > When dealing with a method you know a priori that the object cannot be an > array. Now to get the C

Re: svn commit: r1695425 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: generic/FieldOrMethod.java verifier/statics/Pass3aVerifier.java verifier/structurals/InstConstraintVisi

PING I am -1 on the commit as it stands; please revert or fix On 28 August 2015 at 01:43, sebb wrote: > On 12 August 2015 at 07:32, wrote: >> Author: chas >> Date: Wed Aug 12 06:32:41 2015 >> New Revision: 1695425 >> >> URL: http://svn.apache.org/r1695425 >> Log: >> BCEL-236: remove deprecated

Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/

PING. If I don't hear any response in the next few days I will revert. On 3 September 2015 at 14:43, sebb wrote: > @dbros...@apache.org > > This commit still needs to be reverted please. > > Whilst it makes calling clone slightly easier, it breaks binary and > source compatibility. > The downsid