Re: [BCEL] Java version

2015-08-13 Thread Gary Gregory
Done in SVN and already using Java features :-) Gary On Thu, Aug 13, 2015 at 11:55 AM, Mark Roberts wrote: > I think 7 is fine. I would be hesitant to go all the way to 8 at this > time. > > Thanks, > Mark > > > -Original Message- > From: sebb [mailto:seb...@gmail.com] > Sent: Thursday

Re: svn commit: r1695785 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

2015-08-13 Thread Gary Gregory
That was some wacky code you just fixed up! Gary On Thu, Aug 13, 2015 at 2:54 PM, wrote: > Author: sebb > Date: Thu Aug 13 21:54:22 2015 > New Revision: 1695785 > > URL: http://svn.apache.org/r1695785 > Log: > BCEL-197 Fix typo > > Modified: > > commons/proper/bcel/trunk/src/main/java/org/apach

Fwd: svn commit: r1695768 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier: VerifierAppFrame.java VerifierFactoryListModel.java

2015-08-13 Thread Gary Gregory
With Java 7, you can just say: JList pass3bJList = new JList<>(); instead of: JList pass3bJList = new JList(); Gary -- Forwarded message -- From: Date: Thu, Aug 13, 2015 at 12:51 PM Subject: svn commit: r1695768 - in /commons/proper/bcel/trunk/src/main/java/org/apache/

RE: [BCEL] Java version

2015-08-13 Thread Mark Roberts
I think 7 is fine. I would be hesitant to go all the way to 8 at this time. Thanks, Mark -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Thursday, August 13, 2015 11:48 AM To: Commons Developers List Subject: Re: [BCEL] Java version On 13 August 2015 at 17:58, Gary Grego

Re: [BCEL] 6.0 RC4

2015-08-13 Thread Gary Gregory
Hi Mark, We all work here as volunteers, and as such, time and interest can be limited or focused on specific Commons components and areas. It's really just up to one of us (any Apache committer or a PMC member) to put in the time. In general, providing patches with unit tests is the best way to

Re: [BCEL] Java version

2015-08-13 Thread Gary Gregory
OK, I'll bump it up to Java 7. Gary On Thu, Aug 13, 2015 at 11:47 AM, sebb wrote: > On 13 August 2015 at 17:58, Gary Gregory wrote: > > The POM sets the source version to Java 1.5 but the code does not compile > > on Java 1.5. > > > > I say we just move the req to java 7 or 8 and move on. > >

Re: [BCEL] Java version

2015-08-13 Thread sebb
On 13 August 2015 at 17:58, Gary Gregory wrote: > The POM sets the source version to Java 1.5 but the code does not compile > on Java 1.5. > > I say we just move the req to java 7 or 8 and move on. I would be OK with Java 7 as a minimum. I realise that I normally argue for the minimum Java versi

[BCEL] Java version

2015-08-13 Thread Gary Gregory
The POM sets the source version to Java 1.5 but the code does not compile on Java 1.5. I say we just move the req to java 7 or 8 and move on. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Ac

RE: [BCEL] 6.0 RC4

2015-08-13 Thread Mark Roberts
(Thank you - I will use the trunk.) I have about 10 open issues that have received no comments or attention (that I am aware of) in the last 6 months or so. As I noted in my introduction (attached) several of our release tools use the BCEL library for class file manipulation. We continue to r

Re: [BCEL] 6.0 RC4

2015-08-13 Thread Gary Gregory
I would work against the latest from trunk. Gary On Wed, Aug 12, 2015 at 2:43 PM, Mark Roberts wrote: > I would like to update some of my proposed fixes and lobby for their > inclusion in the next release of BCEL. To that end I presume I should be > comparing my changes with the source in the

RE: [BCEL] 6.0 RC4

2015-08-13 Thread Mark Roberts
I would like to update some of my proposed fixes and lobby for their inclusion in the next release of BCEL. To that end I presume I should be comparing my changes with the source in the RC4 tag as opposed to the trunk. Is that correct? Thank you, Mark Roberts ---

[BCEL] Visitor interfaces

2015-08-13 Thread sebb
BCEL has two Visitor interfaces, in the packages bcel6.classfile and bcel6.generic. This is somewhat confusing, and the Javadoc does not really help to distinguish them. Any info on this? Both of them have an EmptyVisitor implementation that does nothing. However one is abstract and the other is

visitNameSignatureInstruction (was: [VOTE] Release BCEL 6.0 based on RC4)

2015-08-13 Thread sebb
On 11 August 2015 at 05:52, wrote: > > For those asking for a CLIRR, I have created one base upon RC3: > > https://people.apache.org/~chas/bcel-6.0-RC3/clirr-report.html This says that visitNameSignatureInstruction has been added to the generic Visitor interface. However, I cannot find it in the

Re: svn commit: r1695556 - in /commons/proper/bcel/trunk/src: changes/ main/java/org/apache/commons/bcel6/ main/java/org/apache/commons/bcel6/classfile/ main/java/org/apache/commons/bcel6/util/ main/j

2015-08-13 Thread sebb
On 12 August 2015 at 19:20, Dave Brosius wrote: > The Constants class is used by 3rdparty clients to access fields. I suppose > this change is ok, given that they need to recompile anyway, but just > mentioning it. OK, thanks. It's quite easy now that there are static imports. Just replace imp

Re: svn commit: r1695642 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile: LocalVariableTable.java Utility.java

2015-08-13 Thread sebb
On 13 August 2015 at 02:36, wrote: > Author: chas > Date: Thu Aug 13 01:36:31 2015 > New Revision: 1695642 > > URL: http://svn.apache.org/r1695642 > Log: > BCEL-231 > Remove deprecated methods and classes > > Modified: > > commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/clas