Re: Apache Commons Configuration & Bean Scripting Framework (BSF) - dependencies on JDK-Internal APIs

2015-06-21 Thread Rory O'Donnell
Hi Rony, Thanks for that! Rgds,Rory On 20/06/2015 17:27, Rony G. Flatscher (Apache) wrote: Hi Rory, just ran "jdeps -jdkinternals" on both, BSF 2.4.0 and BSF 3.1, both have no internal dependencies. Best regards, ---rony On 15.06.2015 14:19, Rony G. Flatscher (Apache) wrote: On 15.06.2

Re: svn commit: r1686747 [1/3] - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/ main/java/org/apache/commons/io/filefilter/ main/java/org/apache/commons/io/input/ main/java/org/apac

2015-06-21 Thread Kristian Rosenvold
2015-06-22 2:53 GMT+02:00 sebb : > >What was the Findbugs error? > > Best not to mix these in a single commit. > Sorry about that. org.apache.commons.io.output.DeferredFileOutputStream#thresholdReached possible file handle leak upon exception > > Also looks like many of the checkstyle fixes ar

RE: [ALL] re-organise dist directory layout?

2015-06-21 Thread Gary Gregory
I'm OK with a different layout. Gary  Original message From: sebb Date: 06/21/2015 17:09 (GMT-08:00) To: dev@commons.apache.org Subject: [ALL] re-organise dist directory layout? I wonder whether the current directory layout is the most convenient. At present, binaries an

[MATH] Is Math 2.2 still current?

2015-06-21 Thread sebb
The Math download page still lists 2.2 (Java 1.5+) However it also lists 3.5 (Java 1.5+) Do we really still intend to develop the 2.x line? If not, it ought to be removed from the download page and the mirrors. There are also a lot of other old Math3 versions on the mirrors. The Math RMs have n

Re: svn commit: r1686747 [1/3] - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/ main/java/org/apache/commons/io/filefilter/ main/java/org/apache/commons/io/input/ main/java/org/apac

2015-06-21 Thread sebb
On 21 June 2015 at 19:44, wrote: > Author: krosenvold > Date: Sun Jun 21 18:44:49 2015 > New Revision: 1686747 > > URL: http://svn.apache.org/r1686747 > Log: > Fixed all checkstyle errors and a findbugs error > What was the Findbugs error? Best not to mix these in a single commit. Also looks l

[ALL] re-organise dist directory layout?

2015-06-21 Thread sebb
I wonder whether the current directory layout is the most convenient. At present, binaries and source are held in separate areas, and all versions of each type are combined. I think it might simplify matters to use a single directory per version, with both source and binary together. The current

Need permissions to make release....

2015-06-21 Thread Kristian Rosenvold
As already mentioned, I'm missing jira permissions. I'm also missing permissions to add my key to the KEYS file (my key is in https://dist.apache.org/repos/dist/release/maven/KEYS is someone wants to do this) I also suspect that I'll fully be lacking any permissions to publish to repository.apache

VOTE (lazy consensus) Commons Parent 38 from RC2

2015-06-21 Thread sebb
Hello All, The Apache Commons Parent POM provides common settings for all Apache Commons components. This is a VOTE to release Commons Parent 38 from RC2. The main reason for this release is to fix the bug in site.xml discovered recently. This VOTE by LAZY-CONSENSUS is open for at least 72 hou

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread Kristian Rosenvold
2015-06-21 16:14 GMT+02:00 sebb : > > > But there is no unnecessary unboxing here, hence no bug. > > >Exactly, so the IntelliJ warning is wrong. > > No. I added the redundant call back since that's the way you seem to prefer round here. Kristian

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread sebb
On 21 June 2015 at 14:16, Kristian Rosenvold wrote: > 2015-06-21 14:53 GMT+02:00 sebb : > >> On 21 June 2015 at 13:24, Kristian Rosenvold >> wrote: >> > 2015-06-21 13:43 GMT+02:00 sebb : >> > >> >> >> >> > I'm not sure I understand; the equivalent of >> >> > >> >> > Boolean result = (Boolean) isS

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread Kristian Rosenvold
2015-06-21 14:53 GMT+02:00 sebb : > On 21 June 2015 at 13:24, Kristian Rosenvold > wrote: > > 2015-06-21 13:43 GMT+02:00 sebb : > > > >> > >> > I'm not sure I understand; the equivalent of > >> > > >> > Boolean result = (Boolean) isSymbolicLink.invoke(null, path); > >> > return result.booleanValu

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread sebb
On 21 June 2015 at 13:24, Kristian Rosenvold wrote: > 2015-06-21 13:43 GMT+02:00 sebb : > >> >> > I'm not sure I understand; the equivalent of >> > >> > Boolean result = (Boolean) isSymbolicLink.invoke(null, path); >> > return result.booleanValue(); >> > >> > Gives a style warning (uneccssary unbo

Re: [io] How picky about backward compatibility ?

2015-06-21 Thread Kristian Rosenvold
2015-06-21 14:16 GMT+02:00 sebb : > > > Is there a genuine use-case which requires that the same IOE instance > be used? (Other than the unit tests!) > If not, then we could look into relaxing the behaviour (and fixing the > Javadoc) for a future release. > If there is a use-case for always using t

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread Kristian Rosenvold
2015-06-21 13:43 GMT+02:00 sebb : > > > I'm not sure I understand; the equivalent of > > > > Boolean result = (Boolean) isSymbolicLink.invoke(null, path); > > return result.booleanValue(); > > > > Gives a style warning (uneccssary unboxing) in IntelliJ. > > That warning is wrong. > > Unboxing is c

Re: [io] How picky about backward compatibility ?

2015-06-21 Thread sebb
The Javadoc for the two constructors says: >> org.apache.commons.io.input.BrokenInputStream.BrokenInputStream(IOException exception) Creates a new stream that always throws the given exception. Parameters: exception the exception to be thrown << and >> org.apache.commons.io.input.BrokenInputSt

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread Kristian Rosenvold
2015-06-21 13:43 GMT+02:00 sebb : > > Final variables are guaranteed to be safely published across threads. > Is that true for non-final variables if they are established in a static > block? > Yes. All static blocks are guranteed to be visible (all class initialization is basically a synchronized

Re: [io] svn commit r1686512

2015-06-21 Thread sebb
Oops, sorry about that. Not sure why I overlooked that the test code needs package access. On 20 June 2015 at 09:36, Kristian Rosenvold wrote: > I reverted some of the package protected -> private changes, since the > tests did not even compile with this change. > > Kristian ---

Re: porting fixes to v 3.2.X

2015-06-21 Thread Marc-Andre Chartrand
Thanks. I was wondering why the package names changed. I guess you just gave 1 reason. Marc > On Jun 21, 2015, at 4:55 AM, Thomas Neidhart > wrote: > >> On 06/19/2015 05:41 PM, Marc-André Chartrand wrote: >> Can bug fixes from version 4.0 be ported to v 3.2.X ? and also, when is >> the

Re: svn commit: r1686472 - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/FileUtils.java main/java/org/apache/commons/io/Java7Support.java test/java/org/apache/commons/io/FileUtilsCl

2015-06-21 Thread sebb
On 20 June 2015 at 06:39, Kristian Rosenvold wrote: > 2015-06-19 21:01 GMT+02:00 sebb : > >> On 19 June 2015 at 19:00, wrote: >> > +class Java7Support >> > +{ >> > + >> > +private static final boolean IS_JAVA7; >> > + >> > +private static Method isSymbolicLink; >> > + >> > +private s

Re: porting fixes to v 3.2.X

2015-06-21 Thread Thomas Neidhart
On 06/19/2015 05:41 PM, Marc-André Chartrand wrote: > Can bug fixes from version 4.0 be ported to v 3.2.X ? and also, when is > the next 3.2.X version coming out ? > > The fix I'm looking at in particular is : > > https://issues.apache.org/jira/browse/COLLECTIONS-294 > > Which is only fixed in