Re: [TEXT] Review of the code base

2015-04-29 Thread Benedikt Ritter
2015-04-27 8:10 GMT+02:00 Benedikt Ritter : > Hello Phil, > > 2015-04-27 4:56 GMT+02:00 Phil Steitz : > >> On 4/26/15 3:14 AM, Benedikt Ritter wrote: >> > 2015-04-26 11:52 GMT+02:00 Benedikt Ritter : >> > >> >> >> >> 2015-04-19 17:29 GMT+02:00 Benedikt Ritter : >> >> >> >>> >> >>> 2015-04-19 17:24

Re: [2/3] [text] SANDBOX-497 IP clearance for the names package

2015-04-29 Thread Benedikt Ritter
2015-04-24 17:17 GMT+02:00 sebb : > On 20 April 2015 at 04:25, Phil Steitz wrote: > > On 4/19/15 6:52 AM, brit...@apache.org wrote: > >> SANDBOX-497 IP clearance for the names package > >> > >> Make clear that Commons Text only includes ported code from the > >> HumanNameParser PHP library. > >>

Re: [lang] Apache at Github

2015-04-29 Thread Bernd Eckenfels
Am Thu, 30 Apr 2015 09:18:43 +1000 schrieb Peter Ansell : > I looked through all of the commit messages just now again and I can't > see "closes #1" on them, but the pull request was quite promptly > closed automatically by GitHub when I pushed the merge commit to > git-wip-us. I think it detects

Re: [lang] Apache at Github

2015-04-29 Thread Jörg Schaible
Bernd Eckenfels wrote: [snip] > Maybe someone more knowledgable could add something about batches and > CI hooks (and does somebody remeber the URL to the info which describes > how to get added to the ASF commiter team, it was in the developer > documentation somewhere but I cant find it). Than

Re: [lang] Apache at Github

2015-04-29 Thread Peter Ansell
On 29 April 2015 at 23:51, Mark Thomas wrote: > On 29/04/2015 14:18, Benedikt Ritter wrote: >> 2015-04-29 15:00 GMT+02:00 Peter Ansell : >> >>> Hi, >>> >>> All pull requests are manually merged by a committer and then pushed >>> to git-wip-us. The git-wip-us repository is then automatically >>> mi

[Commons Wiki] Update of "UsingGIT" by BenediktRitter

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BenediktRitter: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=17&rev2=18 Comment: Add pointer to GitHub plain text views for pull re

[Commons Wiki] Update of "UsingGIT" by BenediktRitter

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BenediktRitter: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=16&rev2=17 Comment: Add missing push to origin step == Applying

Re: [lang] Apache at Github

2015-04-29 Thread Benedikt Ritter
2015-04-29 16:13 GMT+02:00 Bernd Eckenfels : > Hello, > > I added the following text to the Wiki page: > > = GitHub Integration = > > GitHub is a popular commercial Git hosting service. The ASF GIT > repositories are mirrored there to increase visibility and to encourage > more collaborators. The

[Commons Wiki] Update of "UsingGIT" by BenediktRitter

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BenediktRitter: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=15&rev2=16 Comment: Document how to integrate pull requests from githu

Re: [lang] Apache at Github

2015-04-29 Thread Bernd Eckenfels
Hello, I added the following text to the Wiki page: = GitHub Integration = GitHub is a popular commercial Git hosting service. The ASF GIT repositories are mirrored there to increase visibility and to encourage more collaborators. The Infra team is responsible for maintaining the [[https://githu

[Commons Wiki] Update of "UsingGIT" by BerndEckenfels

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BerndEckenfels: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=14&rev2=15 = GitHub Integration = - GitHub is a popular commer

[Commons Wiki] Update of "UsingGIT" by BerndEckenfels

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BerndEckenfels: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=13&rev2=14 * `svn help `''sub-command'' `git` ''sub-command''

[Commons Wiki] Update of "UsingGIT" by BerndEckenfels

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BerndEckenfels: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=12&rev2=13 * `svn help `''sub-command'' `git` ''sub-command''

[Commons Wiki] Update of "UsingGIT" by BerndEckenfels

2015-04-29 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "UsingGIT" page has been changed by BerndEckenfels: https://wiki.apache.org/commons/UsingGIT?action=diff&rev1=11&rev2=12 Comment: added Github info * `svn help `''sub-command''

Re: [lang] Apache at Github

2015-04-29 Thread Mark Thomas
On 29/04/2015 14:18, Benedikt Ritter wrote: > 2015-04-29 15:00 GMT+02:00 Peter Ansell : > >> Hi, >> >> All pull requests are manually merged by a committer and then pushed >> to git-wip-us. The git-wip-us repository is then automatically >> mirrored back to GitHub. GitHub will then automatically c

Re: [lang] Apache at Github

2015-04-29 Thread James Carman
On Wed, Apr 29, 2015 at 9:18 AM Benedikt Ritter wrote: > > > I haven't found out how to get this right. Do we have documentation at the > ASF hwo to do this right? I've only managed to mark PRs as closed when > merging them back by adding "This closes #61" to the merge commit message. > Is it poss

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread James Carman
On Wed, Apr 29, 2015 at 9:14 AM Benedikt Ritter wrote: > > > I'm not saying we should remove the file. :-) > > I think we're mainly responding to Bruno's comment: "This way we don't have to include other IDE specific entries in the code repository anymore."

Re: [lang] Apache at Github

2015-04-29 Thread Benedikt Ritter
2015-04-29 15:00 GMT+02:00 Peter Ansell : > Hi, > > All pull requests are manually merged by a committer and then pushed > to git-wip-us. The git-wip-us repository is then automatically > mirrored back to GitHub. GitHub will then automatically close the Pull > Request when they see that there is a

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread Benedikt Ritter
2015-04-29 15:09 GMT+02:00 Peter Ansell : > On 29 April 2015 at 22:52, James Carman > wrote: > > On Wed, Apr 29, 2015 at 7:37 AM Jörg Schaible > >> > >> > >> But then you rely on the fact, that everyone has such a setting. I've > >> already seen pull requests containing such files. It does not ha

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread Peter Ansell
On 29 April 2015 at 22:52, James Carman wrote: > On Wed, Apr 29, 2015 at 7:37 AM Jörg Schaible >> >> >> But then you rely on the fact, that everyone has such a setting. I've >> already seen pull requests containing such files. It does not happen if the >> .gitignore is local. >> >> > I'm with Jörg

Re: [lang] Apache at Github

2015-04-29 Thread Peter Ansell
Hi, All pull requests are manually merged by a committer and then pushed to git-wip-us. The git-wip-us repository is then automatically mirrored back to GitHub. GitHub will then automatically close the Pull Request when they see that there is a merge commit that combines the commits from the Pull

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread James Carman
On Wed, Apr 29, 2015 at 7:37 AM Jörg Schaible > > > But then you rely on the fact, that everyone has such a setting. I've > already seen pull requests containing such files. It does not happen if the > .gitignore is local. > > I'm with Jörg on this one. Having a .gitignore file in the repo is the

Re: [lang] Apache at Github

2015-04-29 Thread James Carman
The mirror is read-only, so you will apply the pull requests to the main repository On Wed, Apr 29, 2015 at 7:27 AM Jörg Schaible wrote: > Hi mates, > > OK, lang is now using Git. I've cloned the repo from > git-wip-us.apache.org, setup local user name and mail address, committed a > minimal chan

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread Jörg Schaible
Bruno P. Kinoshita wrote: > Or you can use a global .gitignore [1] file. > > This way we don't have to include other IDE specific entries in the code > repository anymore. But then you rely on the fact, that everyone has such a setting. I've already seen pull requests containing such files. It

[lang] Apache at Github

2015-04-29 Thread Jörg Schaible
Hi mates, OK, lang is now using Git. I've cloned the repo from git-wip-us.apache.org, setup local user name and mail address, committed a minimal change to .gitignore and pushed. Fine. At least for a Git n00b. I am curious about the relationship to the Apache organization at Github though. It

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread Benedikt Ritter
2015-04-29 12:27 GMT+02:00 Bruno P. Kinoshita : > Or you can use a global .gitignore [1] file. > > This way we don't have to include other IDE specific entries in the code > repository anymore. > +1 > > Bruno > > [1] http://stackoverflow.com/questions/7335420/global-git-ignore > > > From:

Re: [lang] Ignore more Eclipse cruft.

2015-04-29 Thread Bruno P. Kinoshita
Or you can use a global .gitignore [1] file. This way we don't have to include other IDE specific entries in the code repository anymore. Bruno [1] http://stackoverflow.com/questions/7335420/global-git-ignore From: "joe...@apache.org" To: comm...@commons.apache.org Sent: Wednesday,