Committing Code, JIRA Gardening

2015-01-01 Thread Carl Hall
Hi all, Per the recent announcement granting commit access to all ASF committers, I'd like to take you up on that. Can I work directly with the Git repo or should I commit to svn? Can I get some JIRA karma to assign and update things? Thanks! I'll likely start with this one: https://issues.apac

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread sebb
Sorry, the mistake is mine entirely. The code to download the file was wrong - it was not checking the length of the buffer when writing the output. The 9C entry is obviously wrong, as is the code in DomainValidatorTest. On 2 January 2015 at 00:06, sebb wrote: > Just noticed that the IANA TLD li

Re: svn commit: r1648642 - /commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java

2015-01-01 Thread sebb
On 31 December 2014 at 13:02, sebb wrote: > On 31 December 2014 at 04:42, Adrian Crum > wrote: >> Be aware that the file contains encoded Chinese TLDs (XN--*). So, it needs >> additional parsing. > > Oops. > > These entries use PunyCode. This is available in Java 6 onwards (java.net.IDN) > > Ther

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread sebb
Just noticed that the IANA TLD list has changed. This should not matter, except that it has dropped "9C" and replaced it by -3DS443G XN--3E0B707E XN--45BRJ9C Looks like the "9C" entry was a mistake. Unfortunately that is now included in the internal database. I don't know how serious an issue

[continuum] BUILD FAILURE: Apache Commons Compress - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2015-01-01 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39067&projectId=64 Build statistics: State: Failed Previous State: Ok Started at: Thu 1 Jan 2015 20:20:10 + Finished at: Thu 1 Jan 2015 20:20:54 + Total time: 44s Build Trigger: Schedule Bui

[GitHub] commons-lang pull request: added the new JsonToStringStyle

2015-01-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-01 Thread Benedikt Ritter
Hi all, we have fixed the issues which where found in RC1 so I'd like to call a new vote to release Apache Commons Validator based on RC2. Changes from RC1: - [VALIDATOR-307] - isValid checks if the given address is only IPV4 address and not IPV6 - [VALIDATOR-347] - toLowerCase() method is Locale

Re: [VALIDATOR] Fix pending for CUSIP checking

2015-01-01 Thread Benedikt Ritter
Thanks, for the reminder. I was just about to tag the release when I saw your mail. I've applied those fixes as well. 2015-01-01 17:01 GMT+01:00 sebb : > Hold on - there were two other check digit patches mentioned earlier > in the thread: > > https://issues.apache.org/jira/browse/VALIDATOR-345 -

[continuum] BUILD FAILURE: Apache Commons Collections - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2015-01-01 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39062&projectId=71 Build statistics: State: Failed Previous State: Failed Started at: Thu 1 Jan 2015 16:31:45 + Finished at: Thu 1 Jan 2015 16:32:03 + Total time: 18s Build Trigger: Forced B

Re: [VALIDATOR] Fix pending for CUSIP checking

2015-01-01 Thread sebb
Hold on - there were two other check digit patches mentioned earlier in the thread: https://issues.apache.org/jira/browse/VALIDATOR-345 - ISIN https://issues.apache.org/jira/browse/VALIDATOR-346 - SEDOL Once these are done, AbstractCheckDigitTestCase can be updated to use a wider range of invalid

Re: [VALIDATOR] Fix pending for CUSIP checking

2015-01-01 Thread Benedikt Ritter
I have applied the fix with slight changes (an additional test and some variable renaming in the test). I'm going to cut RC2 now. 2014-12-31 18:07 GMT+01:00 Benedikt Ritter : > Oh sorry, I tought you already committed the fix. I'll review and commit > it tomorrow. > > Benedikt > > Send from my mo

[continuum] BUILD FAILURE: Apache Commons Collections - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2015-01-01 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39060&projectId=71 Build statistics: State: Failed Previous State: Ok Started at: Thu 1 Jan 2015 14:20:18 + Finished at: Thu 1 Jan 2015 14:20:41 + Total time: 22s Build Trigger: Schedule Bui