Re: svn commit: r1639021 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/utils/BitInputStream.java test/java/org/apache/commons/compress/utils/BitInputStreamTest.java

2014-11-13 Thread Stefan Bodewig
On 2014-11-14, sebb wrote: > On 12 November 2014 20:40, Emmanuel Bourg wrote: >> Le 12/11/2014 21:02, bode...@apache.org a écrit : >>> public int readBits(final int count) throws IOException { >>> -if (count < 0 || count > 32) { if (count < 0 || count > 31) { >>>

[VFS] DefaultFileManager state after close() (also please look at VFS-544)

2014-11-13 Thread Bernd Eckenfels
Hello, while working on the leak bugs I did some cleanup to the fields of DefaultFileManager. I noticed not all get nulled/cleared at close. Now it should be clean what gets set up and tiered down. However I hope nobody uses such a scheme: when you close a manager, just throw it away. I redid th

Re: svn commit: r1639021 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/utils/BitInputStream.java test/java/org/apache/commons/compress/utils/BitInputStreamTest.java

2014-11-13 Thread sebb
On 12 November 2014 20:40, Emmanuel Bourg wrote: > Le 12/11/2014 21:02, bode...@apache.org a écrit : > >> public int readBits(final int count) throws IOException { >> -if (count < 0 || count > 32) { >> +if (count < 0 || count > 31) { >> throw new IllegalArgumentEx

Re: [VOTE] (JCS) release [jcs] 2.0-RC1

2014-11-13 Thread Romain Manni-Bucau
No idea, inheritance from previou sstructure surely Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2014-11-13 16:58 GMT+01:00 Gary Gregory : > Why is the xdocs folder not under src/site? > > Gary > > On Wed, Nov 12, 2014

Re: [VOTE] (JCS) release [jcs] 2.0-RC1

2014-11-13 Thread Gary Gregory
Why is the xdocs folder not under src/site? Gary On Wed, Nov 12, 2014 at 4:23 AM, Romain Manni-Bucau wrote: > Hi > > I'm trying to align on commons standards this time. > > - here is the maven repo: > https://repository.apache.org/content/repositories/orgapachecommons-1061/ > - assemblies can b

Re: [VOTE] (JCS) release [jcs] 2.0-RC1

2014-11-13 Thread Romain Manni-Bucau
Le 13 nov. 2014 10:51, "Johannes Weberhofer" a écrit : > > Dear Romain, > > the packages are build nicely at my platform, here is my non-binding +1. > > Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100) > Maven home: /home.local/java/apache-maven-3 > Java ver

Re: [VOTE] (JCS) release [jcs] 2.0-RC1

2014-11-13 Thread Johannes Weberhofer
Dear Romain, the packages are build nicely at my platform, here is my non-binding +1. Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100) Maven home: /home.local/java/apache-maven-3 Java version: 1.7.0_71, vendor: Oracle Corporation Java home: /usr/lib64/jvm

Re: [compress] BitInputStream

2014-11-13 Thread Stefan Bodewig
On 2014-11-13, Damjan Jovanovic wrote: > On Wed, Nov 12, 2014 at 8:51 PM, Stefan Bodewig wrote: >> One thing BitStream and BitInputStream have in common is what happens >> when I request more bits than are available from the underlying stream, >> both will signal an EOF and discard the cached bi

Re: [compress] BitInputStream

2014-11-13 Thread Stefan Bodewig
On 2014-11-12, Emmanuel Bourg wrote: > Le 12/11/2014 19:51, Stefan Bodewig a écrit : >> A while ago I had already added a guard to ensure nobody tried to read >> more than 32 bits since bits are accumulated inside an int - but >> actually we can't do that as readBits returns -1 on EOF, so we can'