Re: [VOTE] Release Commons CSV 1.0 based on RC3

2014-08-10 Thread Benedikt Ritter
Hello Bernd, thanks for the review. See my comments inline. 2014-08-10 18:58 GMT+02:00 Bernd Eckenfels : > Hello, > > +0 (non-binding if you like :) > the sandbox should really be removed (see below) > > checked out tag (rev matches) > > - build with 3.2.1/7u65/Win7: install and site ok > - bui

Re: [VOTE] Release Commons CSV 1.0 based on RC3

2014-08-10 Thread Bernd Eckenfels
Hello, +0 (non-binding if you like :) the sandbox should really be removed (see below) checked out tag (rev matches) - build with 3.2.1/7u65/Win7: install and site ok - build with 3.0.5/6u38/Win7: install ok (site fails with findbugs class version problem) - build with 3.2.1/8u11/Win7: instal

Re: [VOTE] Release Commons CSV 1.0 based on RC3

2014-08-10 Thread Gary Gregory
Also builds like a champ with: Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 2014-06-17T09:51:42-04:00) Maven home: C:\Java\apache-maven-3.2.2 Java version: 1.8.0_11, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_11\jre Default locale: en_US, platform encodin

Re: [VOTE] Release Commons CSV 1.0 based on RC3

2014-08-10 Thread Gary Gregory
+1 with: Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 2014-06-17T09:51:42-04:00) Maven home: C:\Java\apache-maven-3.2.2 Java version: 1.7.0_60, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_60\jre Default locale: en_US, platform encoding: Cp1252 OS name: "w

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread sebb
On 10 August 2014 15:53, Gary Gregory wrote: > On Sun, Aug 10, 2014 at 9:44 AM, sebb wrote: > >> On 10 August 2014 13:07, Benedikt Ritter wrote: >> > okay, do you have a problem with leaving the pom the way I've checked it >> > in? Otherwise CSV is not buildable with JDK 8... OTOH the build will

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Gary Gregory
On Sun, Aug 10, 2014 at 9:44 AM, sebb wrote: > On 10 August 2014 13:07, Benedikt Ritter wrote: > > okay, do you have a problem with leaving the pom the way I've checked it > > in? Otherwise CSV is not buildable with JDK 8... OTOH the build will fail > > until infra has figured out what is going

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread sebb
On 10 August 2014 13:07, Benedikt Ritter wrote: > okay, do you have a problem with leaving the pom the way I've checked it > in? Otherwise CSV is not buildable with JDK 8... OTOH the build will fail > until infra has figured out what is going on. I suspect the build will fail even if you revert t

[VOTE] Release Commons CSV 1.0 based on RC3

2014-08-10 Thread Benedikt Ritter
Hi all, we have further refined the API and I'd like to finally release Commons CSV based on RC3. Changes between RC2 and RC3 are: - reverted to Java 6 as language level requirement - updated dependencies to the latest versions - refined the API of CSVFormat some more Changes between RC1 und RC

Re: svn commit: r1617081 - /commons/proper/csv/trunk/pom.xml

2014-08-10 Thread Benedikt Ritter
Looks like a known issue, at least that's what has been documented in our release description... 2014-08-10 14:17 GMT+02:00 Gary Gregory : > Nasty! Did you file a bug report? > > Gary > > Original message From: brit...@apache.org > Date:08/10/2014 05:56 (GMT-05:00) To: > comm.

Re: svn commit: r1617074 - /commons/proper/csv/trunk/pom.xml

2014-08-10 Thread Benedikt Ritter
Yes, but we should figure out how we want to handle the dependency information report. If we include it in the build, publishing the site from trunk will add the dependency information report for the snapshot. we probably can configure it to reuse the commons.release.version property that we're usi

Re: svn commit: r1617072 - /commons/proper/csv/trunk/RELEASE-NOTES.txt

2014-08-10 Thread Benedikt Ritter
They are :) but this was the only ticket that was fixed since I generated them for RC2 2014-08-10 14:06 GMT+02:00 Gary Gregory : > Release notes should be generated by Maven... check the wiki for details. > > Gary > > Original message From: brit...@apache.org > Date:08/10/2014

[continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35440&projectId=68 Build statistics: State: Failed Previous State: Failed Started at: Sun 10 Aug 2014 12:20:06 + Finished at: Sun 10 Aug 2014 12:20:11 + Total time: 5s Build Trigger: Schedule

Fwd: svn commit: r1617081 - /commons/proper/csv/trunk/pom.xml

2014-08-10 Thread Gary Gregory
Nasty! Did you file a bug report? Gary Original message From: brit...@apache.org Date:08/10/2014 05:56 (GMT-05:00) To: comm...@commons.apache.org Subject: svn commit: r1617081 - /commons/proper/csv/trunk/pom.xml Author: britter Date: Sun Aug 10 09:56:49 2014 New Revision: 1

Fwd: svn commit: r1617074 - /commons/proper/csv/trunk/pom.xml

2014-08-10 Thread Gary Gregory
How about pushing out commons-parent 35? Gary Original message From: brit...@apache.org Date:08/10/2014 05:11 (GMT-05:00) To: comm...@commons.apache.org Subject: svn commit: r1617074 - /commons/proper/csv/trunk/pom.xml Author: britter Date: Sun Aug 10 09:11:58 2014 New Revi

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Benedikt Ritter
okay, do you have a problem with leaving the pom the way I've checked it in? Otherwise CSV is not buildable with JDK 8... OTOH the build will fail until infra has figured out what is going on. 2014-08-10 13:49 GMT+02:00 sebb : > I think the problem is more widespread than just Jacoco; I recently

Fwd: svn commit: r1617072 - /commons/proper/csv/trunk/RELEASE-NOTES.txt

2014-08-10 Thread Gary Gregory
Release notes should be generated by Maven... check the wiki for details.  Gary Original message From: brit...@apache.org Date:08/10/2014 05:01 (GMT-05:00) To: comm...@commons.apache.org Subject: svn commit: r1617072 - /commons/proper/csv/trunk/RELEASE-NOTES.txt Author: bri

Re: [lang] Fully recursive equals methods

2014-08-10 Thread venkatesha m
I would like to add that lombok annotations have a good implementations on equals and hash code using annotations for an inspiration. there i can clearly call out which fields of the class are of interest in hashcode and equals method. On Thursday, 7 August 2014 6:17 PM, Yair Zaslavsky wrot

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread sebb
I think the problem is more widespread than just Jacoco; I recently reported the following on the Infra list: "Continuum is failing builds because the Archiva instance is returning 503 The host is OK: https://archiva-repository.apache.org/ - returns 200 But the archiva instance is not: https:

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Benedikt Ritter
Infra ticket is https://issues.apache.org/jira/browse/INFRA-8165 2014-08-10 13:13 GMT+02:00 Apache Continuum : > Online report : > https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35435&projectId=68 > > Build statistics: > State: Failed > Previous State: Failed > Starte

[continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35435&projectId=68 Build statistics: State: Failed Previous State: Failed Started at: Sun 10 Aug 2014 11:13:03 + Finished at: Sun 10 Aug 2014 11:13:08 + Total time: 5s Build Trigger: Forced

Re: [continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Benedikt Ritter
I'm in touch with infra about this. Looks like a problem with resolving the jacoco maven plugin. 2014-08-10 12:20 GMT+02:00 Apache Continuum : > Online report : > https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35432&projectId=68 > > Build statistics: > State: Failed > P

[continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35432&projectId=68 Build statistics: State: Failed Previous State: Failed Started at: Sun 10 Aug 2014 10:20:09 + Finished at: Sun 10 Aug 2014 10:20:16 + Total time: 6s Build Trigger: Schedule

[continuum] BUILD FAILURE: Apache Commons CSV - Apache Commons (Local Java 7 build)

2014-08-10 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=35429&projectId=68 Build statistics: State: Failed Previous State: Ok Started at: Sun 10 Aug 2014 09:20:11 + Finished at: Sun 10 Aug 2014 09:20:17 + Total time: 6s Build Trigger: Schedule Bu