[continuum] BUILD FAILURE: Apache Commons Math - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.7))

2014-07-18 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=34253&projectId=97 Build statistics: State: Failed Previous Build: No previous build. Started at: Sat 19 Jul 2014 06:20:25 + Finished at: Sat 19 Jul 2014 06:25:55 + Total time: 5m 30s Build Tr

[pool] Usage of logging API in common-pool ?

2014-07-18 Thread Anthony Communier
Hello, There are some parts of the code that use printStackTrace in order to show errors. It means that it's difficult to have control on how log will be produced. Those stacks will mainly go to application server logs and not directly into application logs if an application server is used (like t

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
On Fri, Jul 18, 2014 at 4:36 PM, Emmanuel Bourg wrote: > Le 18/07/2014 22:17, Benedikt Ritter a écrit : > > Just to make it clear... We're happy with: > > - boolean isIgnoringSurroundingSpaces() > > - withIgnoreSurroundingSpaces(boolean) > > > > So nothing has to change? > > Not sure, I find the

Re: [ALL] Logo contest for Commons?

2014-07-18 Thread Phil Steitz
On 7/18/14, 1:55 AM, Benedikt Ritter wrote: > Hi all, > > the Apache Commons project currently does not have it's own logo! We are > simply reusing the Apache logo with the feather. I even remember a guy from > legal say, that they don't like it very much when projects reuse the Apache > feather fo

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Le 18/07/2014 22:17, Benedikt Ritter a écrit : > Just to make it clear... We're happy with: > - boolean isIgnoringSurroundingSpaces() > - withIgnoreSurroundingSpaces(boolean) > > So nothing has to change? Not sure, I find the asymmetry a bit disturbing, but if I'm the only one I can pass on that.

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
On Fri, Jul 18, 2014 at 4:01 PM, Benedikt Ritter wrote: > I think "isAllowingMissingColumnNames" is a good name. > That does not real well at all unfortunately. Gary > > Send from my mobile device > > > Am 18.07.2014 um 17:43 schrieb Emmanuel Bourg : > > > > Le 18/07/2014 17:37, Gary Gregory

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Le 18/07/2014 22:05, Benedikt Ritter a écrit : > While looking at CSVFormat again, I noticed that the methods currently are > withQuotePolicy and getQuotePolicy. Now I'm feeling we should go with the > more verbose but more explicit name for that enum. Ok. We could use QuoteMode instead of Quot

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Benedikt Ritter
Just to make it clear... We're happy with: - boolean isIgnoringSurroundingSpaces() - withIgnoreSurroundingSpaces(boolean) So nothing has to change? Benedikt Send from my mobile device > Am 18.07.2014 um 16:12 schrieb Gary Gregory : > > There is a nice pattern now with ivar and method names whe

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Benedikt Ritter
Send from my mobile device > Am 15.07.2014 um 20:07 schrieb Benedikt Ritter : > > Hello Emmanuel, > > thanks for your thorough review. I've worked through your list. Here are my > comments: > > > 2014-07-12 19:02 GMT+02:00 Emmanuel Bourg : >> I took a fresh look at the API and here is my re

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Benedikt Ritter
I think "isAllowingMissingColumnNames" is a good name. Send from my mobile device > Am 18.07.2014 um 17:43 schrieb Emmanuel Bourg : > > Le 18/07/2014 17:37, Gary Gregory a écrit : > >> So what do you call the individual names in a header record? > > A column name. That's the term used in CSVRe

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Le 18/07/2014 17:37, Gary Gregory a écrit : > So what do you call the individual names in a header record? A column name. That's the term used in CSVRecord. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apac

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
On Fri, Jul 18, 2014 at 11:35 AM, Emmanuel Bourg wrote: > Le 18/07/2014 17:29, Gary Gregory a écrit : > > > There is indeed one header record. But that record contains one header > per > > column, so one could conceivably says that there are one or more headers > > per record, just like there is

Re: [ALL] Logo contest for Commons?

2014-07-18 Thread Gary Gregory
Nice idea. I sketched out some attempts a while back, I'll have to look for those... Gary On Fri, Jul 18, 2014 at 4:55 AM, Benedikt Ritter wrote: > Hi all, > > the Apache Commons project currently does not have it's own logo! We are > simply reusing the Apache logo with the feather. I even rem

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Le 18/07/2014 17:29, Gary Gregory a écrit : > There is indeed one header record. But that record contains one header per > column, so one could conceivably says that there are one or more headers > per record, just like there is one or more value per data record. That's what I found confusing. Fr

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
On Fri, Jul 18, 2014 at 11:20 AM, Emmanuel Bourg wrote: > Le 18/07/2014 16:13, Gary Gregory a écrit : > > Would using "Headers" (plural) be better: withSkipHeadersRecord(boolean) > ? > > Isn't the plural form withSkipHeaderRecords() instead? > > But since there is only one header record I'd keep

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Le 18/07/2014 16:13, Gary Gregory a écrit : > Would using "Headers" (plural) be better: withSkipHeadersRecord(boolean) ? Isn't the plural form withSkipHeaderRecords() instead? But since there is only one header record I'd keep the singular form. Emmanuel Bourg -

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
Would using "Headers" (plural) be better: withSkipHeadersRecord(boolean) ? Gary On Fri, Jul 18, 2014 at 7:54 AM, Emmanuel Bourg wrote: > Thank you for the fixes Benedikt. > > Le 15/07/2014 20:07, Benedikt Ritter a écrit : > > > skipHeaderRecord refers to the header records as a whole (so it's

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Gary Gregory
There is a nice pattern now with ivar and method names where we have the ivar ignoreSomething (note that it is verb first in the active void) and withIgnoreSomething. It is important IMO to use the active void instead of passive (somethingIgnored) to make it clear who performs the action. It's wi

Re: [VOTE] Release Commons CSV 1.0 based on RC1

2014-07-18 Thread Emmanuel Bourg
Thank you for the fixes Benedikt. Le 15/07/2014 20:07, Benedikt Ritter a écrit : > skipHeaderRecord refers to the header records as a whole (so it's > singular). ignore empty headers refers to header column values, so it's > plural. I guess that makes sense. Ok, I misunderstood the intent then.

Re: [SITE] Add automatic generation of maven coords to site build?

2014-07-18 Thread Gary Gregory
This looks good too: http://search.maven.org/#artifactdetails|org.apache.commons|commons-lang3|3.3.2|jar Tabs or any other widget will be fine, even a plain page would good to start, as long as the information is there. Gary On Fri, Jul 18, 2014 at 3:54 AM, Benedikt Ritter wrote: > Should be

[ALL] Logo contest for Commons?

2014-07-18 Thread Benedikt Ritter
Hi all, the Apache Commons project currently does not have it's own logo! We are simply reusing the Apache logo with the feather. I even remember a guy from legal say, that they don't like it very much when projects reuse the Apache feather for their logo. The log4j2 project did a very successful

Re: [SITE] Add automatic generation of maven coords to site build?

2014-07-18 Thread Benedikt Ritter
Should be no problem. What may be hard, is making it look good :o) I'd like to have it look like tabs, like on mavenrepository.com. That should be possible with the bootstrap skin we're using, since it has a tab javascript plugin [1]. I try to find a solution and then upload a demo to my apache spa