On 4/13/14, 4:21 PM, sebb wrote:
> I added some debug to DelegatingStatement and it appears that
> isClosed() is sometimes being called from a different thread than the
> one used to create the instance.
>
> I'm not sure why this should be, because the statements are created in
> the TestConnection
See comments in DBCP-415. I think the problem is the finalizer.
> On Apr 13, 2014, at 4:21 PM, sebb wrote:
>
> I added some debug to DelegatingStatement and it appears that
> isClosed() is sometimes being called from a different thread than the
> one used to create the instance.
>
> I'm not su
I added some debug to DelegatingStatement and it appears that
isClosed() is sometimes being called from a different thread than the
one used to create the instance.
I'm not sure why this should be, because the statements are created in
the TestConnectionPool.PoolTest.run() method and as far as I k
On Sun, Apr 13, 2014 at 11:30 PM, Phil Steitz wrote:
> On 4/13/14, 3:21 PM, Niall Pemberton wrote:
> > I don't see any value in test Javadocs and IMO they should be removed.
> You mean from the website, right?
>
Yes, sorry - I meant generating the test javadocs.
Niall
I think there is a lot o
On 4/13/14, 3:21 PM, Niall Pemberton wrote:
> I don't see any value in test Javadocs and IMO they should be removed.
You mean from the website, right?
I think there is a lot of value in adding docs to the tests - like
the ones complained about here - that explain how the tests operate,
what the pa
I don't see any value in test Javadocs and IMO they should be removed.
Niall
On Sun, Apr 13, 2014 at 10:47 PM, sebb wrote:
> On 13 April 2014 18:38, Phil Steitz wrote:
> > On 4/13/14, 10:33 AM, sebb wrote:
> >> Agreed; will cause Java 8 Javadoc to report errors.
> >>
> >> If you don't want t
On 13 April 2014 18:38, Phil Steitz wrote:
> On 4/13/14, 10:33 AM, sebb wrote:
>> Agreed; will cause Java 8 Javadoc to report errors.
>>
>> If you don't want to use @code, one can always use {name} or [name] instead.
>> Just don't use HTML tag delimiters ...
>
> Makes no difference to me, as we d
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29288&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 18:51:08 +
Finished at: Sun 13 Apr 2014 18:51:57 +
Total time: 49s
Build Trigger: Forced
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29287&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 18:27:49 +
Finished at: Sun 13 Apr 2014 18:28:34 +
Total time: 45s
Build Trigger: Forced
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29286&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 18:20:50 +
Finished at: Sun 13 Apr 2014 18:22:18 +
Total time: 1m 28s
Build Trigger: Sche
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29283&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 17:38:11 +
Finished at: Sun 13 Apr 2014 17:39:14 +
Total time: 1m 2s
Build Trigger: Force
On 4/13/14, 10:33 AM, sebb wrote:
> Agreed; will cause Java 8 Javadoc to report errors.
>
> If you don't want to use @code, one can always use {name} or [name] instead.
> Just don't use HTML tag delimiters ...
Makes no difference to me, as we don't generate html javadoc for
test code. Change it
On 4/13/14, 10:21 AM, Gary Gregory wrote:
> -1 to using <> instead of {@code}
Feel free to change this. It was copied from the previous code.
Phil
>
> Gary
>
> Original message From: Bernd
> Date:04/13/2014 10:50 (GMT-05:00)
> To: Commons Developers List
> Subject: Re: sv
Agreed; will cause Java 8 Javadoc to report errors.
If you don't want to use @code, one can always use {name} or [name] instead.
Just don't use HTML tag delimiters ...
On 13 April 2014 18:21, Gary Gregory wrote:
> -1 to using <> instead of {@code}
>
> Gary
>
> Original message
-1 to using <> instead of {@code}
Gary
Original message From: Bernd
Date:04/13/2014 10:50 (GMT-05:00)
To: Commons Developers List
Subject: Re: svn commit: r1586926 - in
/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2:
TestConnectionPool.java TestPStmtPo
Hello,
Am 13.04.2014 08:11 schrieb :
>
> Author: psteitz
> Date: Sun Apr 13 06:10:44 2014
> New Revision: 1586926
>
> URL: http://svn.apache.org/r1586926
> Log:
> Added test (commented out) to illustrate DBCP-415.
>
> Modified:
>
commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/Tes
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29276&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 14:21:11 +
Finished at: Sun 13 Apr 2014 14:23:39 +
Total time: 2m 28s
Build Trigger: Sche
GitHub user Andrey-Khobnya opened a pull request:
https://github.com/apache/commons-lang/pull/19
Fix LANG-948
Hi all!
This is fix for bug LANG-948.
Changes with explanations:
1) Method ```ExtendedMessageFormat.appendQuotedString()``` returned when
finds first quote
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29273&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 13:43:55 +
Finished at: Sun 13 Apr 2014 13:45:48 +
Total time: 1m 53s
Build Trigger: Forc
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29272&projectId=107
Build statistics:
State: Failed
Previous State: Failed
Started at: Sun 13 Apr 2014 13:09:40 +
Finished at: Sun 13 Apr 2014 13:11:57 +
Total time: 2m 17s
Build Trigger: Forc
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29266&projectId=107
Build statistics:
State: Failed
Previous State: Ok
Started at: Sun 13 Apr 2014 11:58:54 +
Finished at: Sun 13 Apr 2014 12:00:56 +
Total time: 2m 1s
Build Trigger: Forced
Does not work for JUnit3 tests, but one can just rename the method so
it does not start with test.
I use something like:
IGNOREDtest
But I agree that commenting out is as good (more work to install and remove)
On 13 April 2014 11:38, Gary Gregory wrote:
> I use @Ignore instead of comments.
This is a VOTE to publish Commons Parent 34 based on RC1
Main changes:
- added Enforcer to force use of Maven 3.0 or later
- added Java 1.8 profile
- updated surefire and scm-publish versions
The RELEASE-NOTES.txt contains the full list of changes:
https://svn.apache.org/repos/asf/commons/proper
I use @Ignore instead of comments.
Gary
Original message From: pste...@apache.org
Date:04/13/2014 02:10 (GMT-05:00) To:
comm...@commons.apache.org Subject: svn commit: r1586926 - in
/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2:
TestConnectionPool.java
24 matches
Mail list logo
