Thinking about this some more, I take that back. I don't need to do
anything here and the idiom is OK. Sorry for the noise.
Phil
On 4/12/14, 10:31 AM, Phil Steitz wrote:
> The changes to TestConnectionPool to make findbugs happy in r
> 1572068 [1] eliminated the explicit close of resources, whi
On Sat, Apr 12, 2014 at 3:18 PM, Thomas Neidhart
wrote:
> On 04/12/2014 08:41 AM, Dipanjan Laha wrote:
> > On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart
> > wrote:
> >
> >> On 04/11/2014 05:52 AM, Dipanjan Laha wrote:
> >>> Hi,
> >>>
> >>> The only issue here is then Collection's equals impleme
Go for it.
Gary
Original message From: Phil Steitz
Date:04/12/2014 13:31 (GMT-05:00)
To: Commons Developers List
Subject: [DBCP] changes in r
The changes to TestConnectionPool to make findbugs happy in r
1572068 [1] eliminated the explicit close of resources, which I
thin
The changes to TestConnectionPool to make findbugs happy in r
1572068 [1] eliminated the explicit close of resources, which I
think is not a good practice to promote in the unit tests and it
also makes the test harder to follow / modify. Sorry I missed this
when the commit was made. Any objections
On 04/12/2014 08:41 AM, Dipanjan Laha wrote:
> On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart
> wrote:
>
>> On 04/11/2014 05:52 AM, Dipanjan Laha wrote:
>>> Hi,
>>>
>>> The only issue here is then Collection's equals implementation would need
>>> to check individually whether the Collection also
