Re: [collections] MultiValuedMap interface discussion

2014-03-27 Thread Ted Dunning
Following Guava on this has something to be said for it. https://code.google.com/p/guava-libraries/wiki/NewCollectionTypesExplained Their decision is that Multimap#get returns a collection always. If there are no values, then an empty collection is returned so that you can always do m.get

Re: [collections] MultiValuedMap interface discussion

2014-03-27 Thread Paul Benedict
The downside of it returning an empty collection is you either have (1) to instantiate a collection just to say you have nothing or (2) you use an immutable collection. #1 is bad in itself and #2 is only as bad if the collection is otherwise writable. For example, it would be really strange for the

[collections] MultiValuedMap interface discussion

2014-03-27 Thread Thomas Neidhart
Hi, we are currently working on a new MultiValuedMap interface for collections, see https://issues.apache.org/jira/browse/COLLECTIONS-508. During the work we stumbled across an issue we would like to discuss. The MultiValuedMap is basically a Map that can hold multiple values associated to a give

Re: [CSV] ASCII Delimited Text – Not CSV or TAB delimited text

2014-03-27 Thread Hasan Diwan
Greg, I misunderstood the thrust of your question. I disagree we need a specialised format for this, as the first I've heard of these codes was in your initial email. I've not seen them used "in the wild", as it were, either. However, if there's enough pushback in the other direction, I'll keep my

Re: [PROXY] @since markers

2014-03-27 Thread Paul Benedict
I think starting the classes should be @since tagged; that's standard procedure in the javadoc world, as far as i know. Regarding what's forgotten, I never worried about that and fixing it is easy. On Thu, Mar 27, 2014 at 11:18 AM, sebb wrote: > On 27 March 2014 15:47, Paul Benedict wrote: > >

Re: [CSV] ASCII Delimited Text – Not CSV or TAB delimited text

2014-03-27 Thread Gary Gregory
On Thu, Mar 27, 2014 at 11:58 AM, Hasan Diwan wrote: > Python (at least, maybe Ruby/perl as well) has a csv class whose > constructor takes a delimiter, defaulting to ","; R accomplishes the same > using read.table's sep parameter. OpenCSV, a Java class for manipulating > CSVs, also has a notion

Re: [CSV] ASCII Delimited Text - Not CSV or TAB delimited text

2014-03-27 Thread sebb
On 27 March 2014 15:49, Gary Gregory wrote: > FYI: > > Has anyone seen this? > > https://ronaldduncan.wordpress.com/2009/10/31/text-file-formats-ascii-delimited-text-not-csv-or-tab-delimited-text/ > > It actually makes sense. Good luck editing such files though... Yes, how is one supposed to crea

Re: [PROXY] @since markers

2014-03-27 Thread sebb
On 27 March 2014 15:47, Paul Benedict wrote: > Sebb, maybe I missed the context of the proposal. If the @since 1.0 is on > the class, there's no need for it to be on methods unless the methods are > of another version. I think that's the standard javadoc way from Oracle > anyway. Yes. But the on

Re: [CSV] ASCII Delimited Text – Not CSV or TAB delimited text

2014-03-27 Thread Hasan Diwan
Python (at least, maybe Ruby/perl as well) has a csv class whose constructor takes a delimiter, defaulting to ","; R accomplishes the same using read.table's sep parameter. OpenCSV, a Java class for manipulating CSVs, also has a notion of a separator. It's not too difficult to add, I'd be willing t

[CSV] ASCII Delimited Text – Not CSV or TAB delimited text

2014-03-27 Thread Gary Gregory
FYI: Has anyone seen this? https://ronaldduncan.wordpress.com/2009/10/31/text-file-formats-ascii-delimited-text-not-csv-or-tab-delimited-text/ It actually makes sense. Good luck editing such files though... I wonder if we should add a built-in format for this format? Gary -- E-Mail: garydgreg

Re: [PROXY] @since markers

2014-03-27 Thread Paul Benedict
Sebb, maybe I missed the context of the proposal. If the @since 1.0 is on the class, there's no need for it to be on methods unless the methods are of another version. I think that's the standard javadoc way from Oracle anyway. On Thu, Mar 27, 2014 at 10:35 AM, sebb wrote: > Indeed. > > The poi

Re: [PROXY] @since markers

2014-03-27 Thread sebb
Indeed. The point about not knowing where a missing annotation means it was forgotten or whether it means ab initio may perhaps work with classes. However once a class has an @since marker, there's no way of telling whether its method and field @since markers are deliberately or accidentally omit

Re: [PROXY] @since markers

2014-03-27 Thread Matt Benson
+1. Due to the package change and fundamental shift from ProxyFactory as abstract class to interface, arguably everything (or very nearly so) is @since 2.0 anyway. Matt On Thu, Mar 27, 2014 at 10:22 AM, sebb wrote: > Whilst removing the @author tags I noticed that there are 39 @since > markers,

Re: [PROXY] @since markers

2014-03-27 Thread Paul Benedict
I don't know if removing @since 1.0 should be pursued. Coming from a research perspective, the lack of them either indicates (1) since 1.0 or (2) an omission. There's no way to know how someone would interpret their omission so I would recommend keeping them so it's clear which methods existed sinc

[PROXY] @since markers

2014-03-27 Thread sebb
Whilst removing the @author tags I noticed that there are 39 @since markers, all are @since 1.0. I think we should remove these. If not, then we need to add @since markers to identify what has been added since. - To unsubscribe,

Re: [proxy] @author tags

2014-03-27 Thread Matt Benson
Thanks, James! Take care, Matt and Commons On Thu, Mar 27, 2014 at 10:12 AM, sebb wrote: > On 27 March 2014 14:58, James Carman wrote: >> Of course not. Feel free. > > Thanks, will do! > >> Sorry for including them. I guess I didn't realize I did it or something. > > Possibly your IDE did it

Re: [proxy] @author tags

2014-03-27 Thread sebb
On 27 March 2014 14:58, James Carman wrote: > Of course not. Feel free. Thanks, will do! > Sorry for including them. I guess I didn't realize I did it or something. Possibly your IDE did it for you. > On Thu, Mar 27, 2014 at 10:57 AM, Matt Benson wrote: >> James: >> As you are no doubt aw

Re: [PROXY] Dependency updates

2014-03-27 Thread Matt Benson
Probably so. My intent is to rename the asm stuff from ASM4* to ASM*. Matt On Thu, Mar 27, 2014 at 9:53 AM, sebb wrote: > There are newer versions of the following: > > cglib:cglib-nodep ... 2.1_3 -> 3.1 > > org.ow2.asm:asm-commons ...

Re: [proxy] @author tags

2014-03-27 Thread James Carman
Of course not. Feel free. Sorry for including them. I guess I didn't realize I did it or something. On Thu, Mar 27, 2014 at 10:57 AM, Matt Benson wrote: > James: > As you are no doubt aware, the recommended practice in ASF Java code > is to dispense with @author tags. You are, of course, lis

[proxy] @author tags

2014-03-27 Thread Matt Benson
James: As you are no doubt aware, the recommended practice in ASF Java code is to dispense with @author tags. You are, of course, listed in the Commons Proxy POM with the roles of admin/designer/developer. Do you take issue with the removal of your @author tags from the source code? br, Matt --

Re: [PROXY] Dependency updates

2014-03-27 Thread Gary Gregory
I'm always for living in the present ;) +1. Gary On Thu, Mar 27, 2014 at 10:53 AM, sebb wrote: > There are newer versions of the following: > > cglib:cglib-nodep ... 2.1_3 -> 3.1 > > org.ow2.asm:asm-commons . 4.2 -> 5.0.1 >

[PROXY] Dependency updates

2014-03-27 Thread sebb
There are newer versions of the following: cglib:cglib-nodep ... 2.1_3 -> 3.1 org.ow2.asm:asm-commons . 4.2 -> 5.0.1 org.ow2.asm:asm . 4.2 -> 5.0.1 jmock:jmock ..

[Math] MATH-1114

2014-03-27 Thread Gilles
On Thu, 27 Mar 2014 13:42:14 + (UTC), Gilles (JIRA) wrote: Gilles created MATH-1114: Summary: Accuracy of "FastMath" and "Math" Key: MATH-1114 URL: https://issues.apache.org/jira/browse/MATH-1114 Project

Re: [proxy] toward a v2.0 release

2014-03-27 Thread Matt Benson
FTR, I agree these should be removed, but out of common courtesy we should probably seek James's acquiescence. Matt On Mar 27, 2014 9:43 AM, "sebb" wrote: > Also just noticed that there are a lot of @author tags. > These are deprecated, and should ideally be removed (the authors can > be credite

Re: [proxy] toward a v2.0 release

2014-03-27 Thread sebb
Also just noticed that there are a lot of @author tags. These are deprecated, and should ideally be removed (the authors can be credited elsewhere). One is yours, the rest are James Carman. On 27 March 2014 14:13, sebb wrote: > On 27 March 2014 13:16, Matt Benson wrote: >> On Mar 27, 2014 6:43

Re: [proxy] toward a v2.0 release

2014-03-27 Thread sebb
On 27 March 2014 13:16, Matt Benson wrote: > On Mar 27, 2014 6:43 AM, "sebb" wrote: >> >> On 27 March 2014 04:29, Matt Benson wrote: >> > This is the notice that I intend to serve as release manager and begin >> > cutting release candidates in the very near future after a very small >> > amount

Re: [proxy] toward a v2.0 release

2014-03-27 Thread Matt Benson
On Mar 27, 2014 6:43 AM, "sebb" wrote: > > On 27 March 2014 04:29, Matt Benson wrote: > > This is the notice that I intend to serve as release manager and begin > > cutting release candidates in the very near future after a very small > > amount of remaining cleanup. Those of you who wish to form

Re: [proxy] toward a v2.0 release

2014-03-27 Thread sebb
On 27 March 2014 04:29, Matt Benson wrote: > This is the notice that I intend to serve as release manager and begin > cutting release candidates in the very near future after a very small > amount of remaining cleanup. Those of you who wish to formulate and express > opinions on the state of the c