Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 1:40 PM, Emmanuel Bourg wrote: > Le 26/11/2013 19:18, Gary Gregory a écrit : > > > I disagree, final everywhere is a good thing, please see > > http://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ > > Well, I guess we agree to disagree then :) Final everywhe

Re: [pool] 2.0.1?

2013-11-26 Thread Gary Gregory
I would. Release early, release often! :) Gary On Tue, Nov 26, 2013 at 5:54 PM, Phil Steitz wrote: > Should we cut a 2.0.1 now just to patch POOL-240? > > Phil > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[pool] 2.0.1?

2013-11-26 Thread Phil Steitz
Should we cut a 2.0.1 now just to patch POOL-240? Phil - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [jira] [Commented] (POOL-240) GKOP: invalidateObject does not unblock threads waiting in borrowObject

2013-11-26 Thread Phil Steitz
On 11/26/13, 12:40 PM, Mark Thomas wrote: > On 26/11/2013 16:17, Phil Steitz wrote: >> On 11/26/13, 4:09 AM, Mark Thomas wrote: >>> On 25/11/2013 23:30, Phil Steitz wrote: On 11/25/13, 3:17 PM, Gary Gregory wrote: > Are we getting a 2.0.1 for this fix? GKOP still needs to be fixed to

Re: [jira] [Commented] (POOL-240) GKOP: invalidateObject does not unblock threads waiting in borrowObject

2013-11-26 Thread Mark Thomas
On 26/11/2013 16:17, Phil Steitz wrote: > On 11/26/13, 4:09 AM, Mark Thomas wrote: >> On 25/11/2013 23:30, Phil Steitz wrote: >>> On 11/25/13, 3:17 PM, Gary Gregory wrote: Are we getting a 2.0.1 for this fix? >>> GKOP still needs to be fixed to resolve this and the GOP fix needs >>> the "TR" p

Re: [beanutils] Preparing next release

2013-11-26 Thread Oliver Heger
Am 26.11.2013 08:40, schrieb Benedikt Ritter: > 2013/11/25 Oliver Heger > >> Any updates here? Also, I would like to hear what others think about >> BEANUTILS-454 [1]. >> > > Sorry Oliver, I'm busy at the moment. I will not have time much time until > mid december. And then there is christmas.

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Jörg Schaible
Hi Damjan, it seems that we have already some changes and get a new RC, but I've tested the source tarball with my complete compiler zoo (incl. Java 8) without any problems. At least that looks great ;-) Cheers, Jörg Damjan Jovanovic wrote: > Please vote on releasing commons-imaging 1.0 from

Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Emmanuel Bourg
Le 26/11/2013 19:18, Gary Gregory a écrit : > I disagree, final everywhere is a good thing, please see > http://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ Well, I guess we agree to disagree then :) Final everywhere is absurd imho, there are many cases where it's useless and incr

Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 12:58 PM, Emmanuel Bourg wrote: > Le 26/11/2013 17:48, Damjan Jovanovic a écrit : > > > Why are we excluding those? Final variables are a good thing. > > Yes but final everywhere is a bit extreme and makes the code too verbose. > I disagree, final everywhere is a good thi

Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Emmanuel Bourg
Le 26/11/2013 17:48, Damjan Jovanovic a écrit : > Why are we excluding those? Final variables are a good thing. Yes but final everywhere is a bit extreme and makes the code too verbose. Emmanuel Bourg - To unsubscribe, e-mail:

Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 6:18 PM, wrote: > Author: ebourg > Date: Tue Nov 26 16:18:58 2013 > New Revision: 1545710 > > URL: http://svn.apache.org/r1545710 > Log: > Adjust PMD rules > > Copied: commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml (from r1545174, > commons/proper/imaging/trunk/pm

Re: [cli] Moving to Git?

2013-11-26 Thread Torsten Curdt
Trying hard not to get sucked into the git debate again but I am almost offended to be offered this ridiculously simplified argument: > For reminder, the argument was that it is quite easy to provide a > contribution with Subversion: > $ svn co "" > $ cd trunk > $ mvn test > $ svn diff > "issue.

Re: [jira] [Commented] (POOL-240) GKOP: invalidateObject does not unblock threads waiting in borrowObject

2013-11-26 Thread Phil Steitz
On 11/26/13, 4:09 AM, Mark Thomas wrote: > On 25/11/2013 23:30, Phil Steitz wrote: >> On 11/25/13, 3:17 PM, Gary Gregory wrote: >>> Are we getting a 2.0.1 for this fix? >> GKOP still needs to be fixed to resolve this and the GOP fix needs >> the "TR" part of "CTR" done carefully ;). > The GOP fix l

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 4:32 PM, Gary Gregory wrote: > On Tue, Nov 26, 2013 at 12:31 AM, Damjan Jovanovic wrote: > >> On Mon, Nov 25, 2013 at 1:50 PM, Emmanuel Bourg wrote: >> > Hi Damjan, >> >> Hi Emmanuel >> >> > I reviewed the API, here are my observations: >> >> Thank you. >> >> Firstly, we d

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 12:31 AM, Damjan Jovanovic wrote: > On Mon, Nov 25, 2013 at 1:50 PM, Emmanuel Bourg wrote: > > Hi Damjan, > > Hi Emmanuel > > > I reviewed the API, here are my observations: > > Thank you. > > Firstly, we discussed several options before for the 1.0 release, and > agreed t

Re: [cli] Moving to Git?

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 8:56 AM, Gilles wrote: > On Tue, 26 Nov 2013 14:47:09 +0100, Emmanuel Bourg wrote: > >> Le 26/11/2013 14:42, Benedikt Ritter a écrit : >> >> What's the point of using git then? >>> >> >> To provide a better collaboration tool for the external contributors, >> and thus incr

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 8:50 AM, Damjan Jovanovic wrote: > On Tue, Nov 26, 2013 at 3:47 PM, Gary Gregory > wrote: > > On Tue, Nov 26, 2013 at 4:05 AM, Emmanuel Bourg > wrote: > > > >> Hi Damjan, > >> > >> Le 26/11/2013 06:31, Damjan Jovanovic a écrit : > >> > >> > Firstly, we discussed several

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 12:31 AM, Damjan Jovanovic wrote: > On Mon, Nov 25, 2013 at 1:50 PM, Emmanuel Bourg wrote: > > Hi Damjan, > > Hi Emmanuel > > > I reviewed the API, here are my observations: > > Thank you. > > Firstly, we discussed several options before for the 1.0 release, and > agreed t

Re: [cli] Moving to Git?

2013-11-26 Thread Gilles
On Tue, 26 Nov 2013 14:47:09 +0100, Emmanuel Bourg wrote: Le 26/11/2013 14:42, Benedikt Ritter a écrit : What's the point of using git then? To provide a better collaboration tool for the external contributors, and thus increasing the external contributions? Unless I missed some of the rece

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
In the site's "Latest Sanselan Release" section, this link is broken: https://people.apache.org/~damjan/imaging-1.0-RC7/release-history.html It should be https://people.apache.org/~damjan/imaging-1.0-RC7/history.html Gary On Sun, Nov 24, 2013 at 11:54 AM, Damjan Jovanovic wrote: > Please vote o

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 3:47 PM, Gary Gregory wrote: > On Tue, Nov 26, 2013 at 4:05 AM, Emmanuel Bourg wrote: > >> Hi Damjan, >> >> Le 26/11/2013 06:31, Damjan Jovanovic a écrit : >> >> > Firstly, we discussed several options before for the 1.0 release, and >> > agreed that the contents of trunk

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 4:05 AM, Emmanuel Bourg wrote: > Hi Damjan, > > Le 26/11/2013 06:31, Damjan Jovanovic a écrit : > > > Firstly, we discussed several options before for the 1.0 release, and > > agreed that the contents of trunk would be quickly pushed out as 1.0 > > with minimal changes (ma

Re: [cli] Moving to Git?

2013-11-26 Thread Emmanuel Bourg
Le 26/11/2013 14:42, Benedikt Ritter a écrit : > What's the point of using git then? To provide a better collaboration tool for the external contributors, and thus increasing the external contributions? Emmanuel Bourg - To un

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 12:31 AM, Damjan Jovanovic wrote: > On Mon, Nov 25, 2013 at 1:50 PM, Emmanuel Bourg wrote: > > [Snip] > > > - The PixelParser classes in > > org.apache.commons.imaging.formats.bmp.pixelparsers seems to be used > > only internally by BmpImageParser. They can't be made pack

Re: [cli] Moving to Git?

2013-11-26 Thread Benedikt Ritter
2013/11/26 Gary Gregory > On Tue, Nov 26, 2013 at 3:52 AM, Emmanuel Bourg wrote: > > > Le 26/11/2013 08:43, Benedikt Ritter a écrit : > > > I propose [1] as branching model. It looks very complicated at first, > but > > > I've found it very useful to always have a release ready version of the >

Re: [cli] Moving to Git?

2013-11-26 Thread Gary Gregory
On Tue, Nov 26, 2013 at 3:52 AM, Emmanuel Bourg wrote: > Le 26/11/2013 08:43, Benedikt Ritter a écrit : > > I propose [1] as branching model. It looks very complicated at first, but > > I've found it very useful to always have a release ready version of the > > code in master. > > > > [1] http://

Re: [jira] [Commented] (POOL-240) GKOP: invalidateObject does not unblock threads waiting in borrowObject

2013-11-26 Thread Mark Thomas
On 25/11/2013 23:30, Phil Steitz wrote: > On 11/25/13, 3:17 PM, Gary Gregory wrote: >> Are we getting a 2.0.1 for this fix? > > GKOP still needs to be fixed to resolve this and the GOP fix needs > the "TR" part of "CTR" done carefully ;). The GOP fix looks OK to me. Good catch with invalidateObj

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Emmanuel Bourg
Hi Damjan, Le 26/11/2013 06:31, Damjan Jovanovic a écrit : > Firstly, we discussed several options before for the 1.0 release, and > agreed that the contents of trunk would be quickly pushed out as 1.0 > with minimal changes (many/most users are using 1.0-SNAPSHOT), and > then the big API redesig

Re: [cli] Moving to Git?

2013-11-26 Thread Emmanuel Bourg
Le 26/11/2013 08:43, Benedikt Ritter a écrit : > I propose [1] as branching model. It looks very complicated at first, but > I've found it very useful to always have a release ready version of the > code in master. > > [1] http://nvie.com/posts/a-successful-git-branching-model/ It looks complicat