Benedikt Ritter wrote:
> Actually I wanted to vte but will nt have the time until friday. So I've
> no problem with another RC :-)
Same for me ... however, I really appreciate all the work you did for
collections-4, Thomas!
Cheers,
Jörg
Actually I wanted to vte but will nt have the time until friday. So I've no
problem with another RC :-)
2013/11/20 Gary Gregory
> On Wed, Nov 20, 2013 at 3:22 PM, Thomas Neidhart
> wrote:
>
> > On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> > > Hi,
> > >
> > > I'd like to call a vote for relea
Hi,
I'd like to call a vote for releasing Commons Collections 4.0 based on
RC5 and hope that people are still willing to review and vote for this RC.
Changes since RC4:
* [COLLECTIONS-502] Resolved generic parameter inconsistency for
various static fields, e.g. BagUtils.EMPTY_BAG,
Tru
On Wed, Nov 20, 2013 at 3:22 PM, Thomas Neidhart
wrote:
> On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> > Hi,
> >
> > I'd like to call a vote for releasing Commons Collections 4.0 based on
> > RC4 and I am quite confident with this RC after all the valuable
> > feedback from the previous RCs ha
On 11/17/2013 08:22 PM, Thomas Neidhart wrote:
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on
> RC4 and I am quite confident with this RC after all the valuable
> feedback from the previous RCs has been integrated.
>
> Changes since RC3:
>
> * [COLLECTIONS-50
On 11/20/2013 07:16 PM, Thomas Neidhart wrote:
> On 11/20/2013 05:43 PM, Renato Cherullo wrote:
>> Ok, I just pushed my code to the fork at
>> https://github.com/cherullo/commons-math.
>> Merging with SolutionCallback was straightforward, and the standard tests
>> passed.
>> I already saw issues in
I found this .gitignore info helpful when I first started with git:
http://www.vogella.com/articles/Git/article.html#d264321e1029
On 11/20/2013 12:16 PM, Thomas Neidhart wrote:
On 11/20/2013 05:43 PM, Renato Cherullo wrote:
Ok, I just pushed my code to the fork at
https://github.com/cherullo/co
On 11/20/2013 05:43 PM, Renato Cherullo wrote:
> Ok, I just pushed my code to the fork at
> https://github.com/cherullo/commons-math.
> Merging with SolutionCallback was straightforward, and the standard tests
> passed.
> I already saw issues in the new code, but right now I'd like your opinion
> o
Ok, I just pushed my code to the fork at
https://github.com/cherullo/commons-math.
Merging with SolutionCallback was straightforward, and the standard tests
passed.
I already saw issues in the new code, but right now I'd like your opinion
on the current interface (ie. public SimplexSolution
optimiz
yep but this is not enough, almost each "component" is doing n++. This
is fast but since done under a lock if it can be removed it should.
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rman
On 11/20/13, 7:26 AM, Romain Manni-Bucau wrote:
> next version (rewrite/fork):
> https://svn.apache.org/repos/asf/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/counters/OptimizedStatistics.java
>
> was easier to centralize everything in a single class
That is exactly what I meant abo
next version (rewrite/fork):
https://svn.apache.org/repos/asf/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/counters/OptimizedStatistics.java
was easier to centralize everything in a single class
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedI
Hi guys,
It's been a while since I raised this issue. I actually solved this and I
want to contribute it back.
I implemented a new public method in SimplexSolver called optimizeExtra,
that returns a SimplexSolution containing:
1) PointValuePair solution;
The optimal solution.
2) HashMap extra
On 11/20/13, 12:43 AM, Romain Manni-Bucau wrote:
> Hi
>
> A quick mail to give some feedbacks of my tests.
>
> I started to hack a bit to get rid of not used stats by sirona,
> typically I do ATM:
>
> setSumsqImpl(NoopStat.INSTANCE);
> setSumLogImpl(NoopStat.INSTANCE);
> set
Hi Gary,
thanks for your review and all the changes.
Would you mind updating the checkstyle configuration with your local
settings if possible, so that everybody working on the project has the same
baseline for warnings/errors.
I mainly focus on these warnings (enabled checkstyle plugin) together
+1
Note that I've made a lot of polish commits over the last three days after
reviewing various reports and IDE warnings; these would be nice to have in
a major release like 4.0 but they are not blockers.
Tested with:
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
11:22
+1 for the release
Thanks for your patience
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Hi Emmanuel,
thanks for your review and the tests that you added!
For the FalsePredicate: this must have slipped through, in fact I would
even consider to remove the instance objects, but as you suggest this can
be easily fixed in the next point release.
Users should be anyway using the factory m
Also, I'm +1 for the release if this can be fixed later without breaking
the compatibility.
Emmanuel Bourg
Le 20/11/2013 10:45, Emmanuel Bourg a écrit :
> After an ultimate round of code review I have another observation
> regarding the functor API.
>
> In FalsePredicate the INSTANCE singleton
After an ultimate round of code review I have another observation
regarding the functor API.
In FalsePredicate the INSTANCE singleton is defined as
Predicate. In other predicates such as TruePredicate it's
defined as Predicate. In both cases this prevents the declaration of:
Predicate predicat
Hi
A quick mail to give some feedbacks of my tests.
I started to hack a bit to get rid of not used stats by sirona,
typically I do ATM:
setSumsqImpl(NoopStat.INSTANCE);
setSumLogImpl(NoopStat.INSTANCE);
setGeoMeanImpl(NoopStat.INSTANCE);
(NoopStat is a mock of StorelessU
21 matches
Mail list logo
