Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread Henning Schmiedehausen
On Mon, Oct 21, 2013 at 7:33 AM, sebb wrote: [...] source-release.zip may be spurious. > These files get created when running mvn -DdryRun release:prepare instead of mvn -Prelease -DdryRun release:prepare The first one picks up the sourceReleaseAssemblyDescriptor from the apache parent. (

Re: [CONFIGURATION] trying an RC release

2013-10-21 Thread Henning Schmiedehausen
On Mon, Oct 21, 2013 at 4:20 PM, sebb wrote: [...] > I don't like the release plugin; I think it is badly designed [1] so I > don't use it; so I cannot help with it. > > [1] https://jira.codehaus.org/browse/MRELEASE-845 If that bothers you, use a modern SCM and set false. This addresses all of

Re: svn commit: r1534322 - in /commons/proper/imaging/trunk/src: changes/changes.xml main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java main/java/org/apache/commons/imaging/formats

2013-10-21 Thread Damjan Jovanovic
On Tue, Oct 22, 2013 at 3:02 AM, sebb wrote: >> + >> +public byte[] getComment() { >> +return comment; > > This is better, but the array can still be modified externally. > > Might make more sense to convert the array to a String and return that > instead - Strings are immutable, but a

Re: [CONFIGURATION] trying an RC release

2013-10-21 Thread sebb
On 22 October 2013 03:12, Henning Schmiedehausen wrote: > Hi, > > so I was trying to cut an RC for config but it fails with > > Failed to execute goal > org.apache.maven.plugins:maven-assembly-plugin:2.4:single > (source-release-assembly) on project commons-configuration: site did not > exist in t

[CONFIGURATION] trying an RC release

2013-10-21 Thread Henning Schmiedehausen
Hi, so I was trying to cut an RC for config but it fails with Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (source-release-assembly) on project commons-configuration: site did not exist in the target directory - please run site:site before creating the assembly

Re: svn commit: r1534458 - /commons/proper/configuration/branches/RELEASE_1_10_BRANCH/NOTICE.txt

2013-10-21 Thread sebb
On 22 October 2013 02:41, wrote: > Author: henning > Date: Tue Oct 22 01:41:27 2013 > New Revision: 1534458 > > URL: http://svn.apache.org/r1534458 > Log: > it is 2013 already > > Modified: > commons/proper/configuration/branches/RELEASE_1_10_BRANCH/NOTICE.txt > > Modified: commons/proper/con

Re: svn commit: r1534322 - in /commons/proper/imaging/trunk/src: changes/changes.xml main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java main/java/org/apache/commons/imaging/formats

2013-10-21 Thread sebb
On 21 October 2013 19:59, wrote: > Author: damjan > Date: Mon Oct 21 18:59:04 2013 > New Revision: 1534322 > > URL: http://svn.apache.org/r1534322 > Log: > Encapsulate public field. > > Jira issue key: IMAGING-114 > > > Modified: > commons/proper/imaging/trunk/src/changes/changes.xml > >

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread sebb
On 21 October 2013 18:49, Andreas Lehmkuehler wrote: > Hi, > > Am 21.10.2013 19:33, schrieb sebb: > >> On 21 October 2013 18:27, Andreas Lehmkuehler wrote: >>> >>> Hi, >>> >>> Am 21.10.2013 16:25, schrieb Damjan Jovanovic: On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory wrote:

Re: svn commit: r1534254 - /commons/proper/scxml/trunk/pom.xml

2013-10-21 Thread sebb AT ASF
On 21 October 2013 21:23, Ate Douma wrote: > Sebb, > > Was the bump to commons-el 1.0.1-SNAPSHOT intentional, and if so can you > explain why? No. Sorry, not sure how that happened. > In general I prefer not depending on external SNAPSHOT dependencies if not > absolutely needed. And in this cas

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread Mark Thomas
On 21/10/2013 23:31, Emmanuel Bourg wrote: > Le 22/10/2013 00:21, Mark Thomas a écrit : > >> "The Fileupload component is ideal for ..." is fine. >> "Fileupload is ideal for ..." is not. > > Ok, but my suggestion was: > > "Apache Commons FileUpload provides a simple yet flexible..." Thatis usin

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread Emmanuel Bourg
Le 22/10/2013 00:21, Mark Thomas a écrit : > "The Fileupload component is ideal for ..." is fine. > "Fileupload is ideal for ..." is not. Ok, but my suggestion was: "Apache Commons FileUpload provides a simple yet flexible..." instead of: "The Apache Commons FileUpload component provides a si

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread Mark Thomas
On 21/10/2013 23:13, Emmanuel Bourg wrote: > Le 21/10/2013 19:37, sebb a écrit : > >> the component name must not be used as a noun. > > Must not? Why that? Trademark law. We have to use our trademarks correctly in order to be able defend them should someone attempt to abuse them. > It is a nou

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread Emmanuel Bourg
Le 21/10/2013 19:37, sebb a écrit : > the component name must not be used as a noun. Must not? Why that? It is a noun, that's how people name it. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

Re: svn commit: r1534389 - in /commons/proper/math/trunk/src/test: R/zipfTestCases java/org/apache/commons/math3/distribution/ZipfDistributionTest.java

2013-10-21 Thread Thomas Neidhart
On 10/21/2013 11:56 PM, Phil Steitz wrote: > On 10/21/13 2:36 PM, t...@apache.org wrote: >> Author: tn >> Date: Mon Oct 21 21:36:37 2013 >> New Revision: 1534389 >> >> URL: http://svn.apache.org/r1534389 >> Log: >> Add reference test values for ZipfDistribution.logProbability. >> >> Added: >> c

Re: svn commit: r1534389 - in /commons/proper/math/trunk/src/test: R/zipfTestCases java/org/apache/commons/math3/distribution/ZipfDistributionTest.java

2013-10-21 Thread Phil Steitz
On 10/21/13 2:36 PM, t...@apache.org wrote: > Author: tn > Date: Mon Oct 21 21:36:37 2013 > New Revision: 1534389 > > URL: http://svn.apache.org/r1534389 > Log: > Add reference test values for ZipfDistribution.logProbability. > > Added: > commons/proper/math/trunk/src/test/R/zipfTestCases > Mod

Re: [math] MathIllegalArgumentException

2013-10-21 Thread Ted Dunning
+1 The overwhelming standard practice is to use a plausible exception type (such as some form of IllegalArgumentException) with a message. On Mon, Oct 21, 2013 at 5:24 PM, Phil Steitz wrote: > I hate to open this can of worms again, but the following is just > too painful for me to ignore.

Re: svn commit: r1533990 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/BetaDistribution.java

2013-10-21 Thread Ted Dunning
Thread issue. Off topic for this thread. No idea how this happened. On Mon, Oct 21, 2013 at 3:25 PM, Phil Steitz wrote: > Was this maybe to the wrong thread, or is there a doco issue here? > > Phil > > > On Oct 20, 2013, at 10:42 PM, Ted Dunning wrote: > > > > This makes it somewhat harder t

Re: svn commit: r1534254 - /commons/proper/scxml/trunk/pom.xml

2013-10-21 Thread Ate Douma
Sebb, Was the bump to commons-el 1.0.1-SNAPSHOT intentional, and if so can you explain why? In general I prefer not depending on external SNAPSHOT dependencies if not absolutely needed. And in this case it actually caused the tests to fail. For now I've reverted back to commons-el 1.0. Regar

Re: [math] failing distribution tests: logDensity / logProbability

2013-10-21 Thread Phil Steitz
On 10/21/13 12:51 PM, Thomas Neidhart wrote: > Hi, > > there are now 3 failing unit tests related to the recently added > logDensity / logProbability methods. > > I guess this is because the original patch was created before we > increased the tolerance values for several tests. > > Imho, we should

Re: [VOTE] Release of Commons Email 1.3.2 based on RC2

2013-10-21 Thread Oliver Heger
+1 Found no problems! Oliver Am 20.10.2013 18:51, schrieb Thomas Neidhart: > Hi, > > I'd like to call a vote for releasing Commons Email 1.3.2 based on RC2. > > Changes since RC1: > - fixed unit test SimpleHtmlEmail.testDefaultMimeCharset which > failed in certain environments > > Emai

[math] failing distribution tests: logDensity / logProbability

2013-10-21 Thread Thomas Neidhart
Hi, there are now 3 failing unit tests related to the recently added logDensity / logProbability methods. I guess this is because the original patch was created before we increased the tolerance values for several tests. Imho, we should regenerate the test values for higher precision. Thomas -

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Henri Yandell
On Mon, Oct 21, 2013 at 12:28 PM, Henri Yandell wrote: > > > > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > >> On 21 October 2013 11:52, Benedikt Ritter wrote: >> > >> > >> > Send from my mobile device >> > >> >> Am 21.10.2013 um 03:46 schrieb sebb : >> >> >> >>> On 20 October 2013 15:03, Ben

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Henri Yandell
On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > On 21 October 2013 11:52, Benedikt Ritter wrote: > > > > > > Send from my mobile device > > > >> Am 21.10.2013 um 03:46 schrieb sebb : > >> > >>> On 20 October 2013 15:03, Benedikt Ritter wrote: > >>> I agree. If we don't deprecate it now, and agre

Re: [LANG] constants (static final fields) defined using wrapper types (for example, in org.apache.commons.lang.math.NumberUtils)

2013-10-21 Thread Jens Dietrich
Hi, Thanks for all your comments. I think this answers my question. BTW, I am aware of http://wiki.eclipse.org/Evolving_Java-based_APIs - this is actually the starting point of our work. It turns out that some of the inlining rules used by the compiler are rather surprising (see below), and I

Re: [math] documentation for what pseudo-inverse means in decomp solvers

2013-10-21 Thread Phil Steitz
On 10/21/13 9:19 AM, Sean Owen wrote: > On Sat, Oct 19, 2013 at 5:51 PM, Phil Steitz wrote: >> Investigation / tests / documentation much appreciated. >> >> Thanks for looking into this! > OK Phil I'll have another go. I would like to propose three patches > (three JIRAs?) > > 1. The javadoc updat

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread Andreas Lehmkuehler
Hi, Am 21.10.2013 19:33, schrieb sebb: On 21 October 2013 18:27, Andreas Lehmkuehler wrote: Hi, Am 21.10.2013 16:25, schrieb Damjan Jovanovic: On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory wrote: Hi All, I happy to see another RC come along! :) This is large code base so I appreciate th

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread sebb
On 21 October 2013 18:17, Emmanuel Bourg wrote: > Le 21/10/2013 17:26, s...@apache.org a écrit : > >> -The FileUpload component provides a simple yet flexible means of adding >> support for multipart >> +The Apache Commons FileUpload component provides a simple yet flexible >> means of a

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread sebb
On 21 October 2013 18:27, Andreas Lehmkuehler wrote: > Hi, > > Am 21.10.2013 16:25, schrieb Damjan Jovanovic: >> >> On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory >> wrote: >>> >>> Hi All, >>> >>> I happy to see another RC come along! :) This is large code base so I >>> appreciate that the reports

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread Andreas Lehmkuehler
Hi, Am 21.10.2013 16:25, schrieb Damjan Jovanovic: On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory wrote: Hi All, I happy to see another RC come along! :) This is large code base so I appreciate that the reports generate a lot of potential work. I planned to send this email out just over a ye

Re: svn commit: r1534216 - /commons/proper/fileupload/trunk/pom.xml

2013-10-21 Thread Emmanuel Bourg
Le 21/10/2013 17:26, s...@apache.org a écrit : > -The FileUpload component provides a simple yet flexible means of adding > support for multipart > +The Apache Commons FileUpload component provides a simple yet flexible > means of adding support for multipart > file upload functiona

[math] MathIllegalArgumentException

2013-10-21 Thread Phil Steitz
I hate to open this can of worms again, but the following is just too painful for me to ignore. From recent mods to BinomialConfidenceInterval javadoc: * @throws NumberIsTooLargeException if {@code numberOfSuccesses > numberOfTrials}. The "NumberIsTooLarge" exception adds exactly zero to w

Re: [math] documentation for what pseudo-inverse means in decomp solvers

2013-10-21 Thread Sean Owen
On Sat, Oct 19, 2013 at 5:51 PM, Phil Steitz wrote: > Investigation / tests / documentation much appreciated. > > Thanks for looking into this! OK Phil I'll have another go. I would like to propose three patches (three JIRAs?) 1. The javadoc updates discussed on this thread, which I really would

Re: [CANCELLED VOTE] Release Compress 1.6 based on RC2

2013-10-21 Thread Gary Gregory
On Mon, Oct 21, 2013 at 11:11 AM, Stefan Bodewig wrote: > Hi, > > while writing additional tests I found SevenZOutFile wasn't handling > directories correctly - or rather its handling of anything empty isn't > correct. > > I'll add new tests, fix the implementation and re-roll another RC - > at t

[CANCELLED VOTE] Release Compress 1.6 based on RC2

2013-10-21 Thread Stefan Bodewig
Hi, while writing additional tests I found SevenZOutFile wasn't handling directories correctly - or rather its handling of anything empty isn't correct. I'll add new tests, fix the implementation and re-roll another RC - at the same time I'll update the release notes to reflect the potential back

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread sebb
On 21 October 2013 11:52, Benedikt Ritter wrote: > > > Send from my mobile device > >> Am 21.10.2013 um 03:46 schrieb sebb : >> >>> On 20 October 2013 15:03, Benedikt Ritter wrote: >>> I agree. If we don't deprecate it now, and agree to release the next major >>> version targeting Java 7, we woul

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread Damjan Jovanovic
On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory wrote: > Hi All, > > I happy to see another RC come along! :) This is large code base so I > appreciate that the reports generate a lot of potential work. I planned to send this email out just over a year ago, shortly after yours, but since we might a

Re: [VOTE] Release Compress 1.6 based on RC2

2013-10-21 Thread Gary Gregory
On Mon, Oct 21, 2013 at 12:16 AM, Stefan Bodewig wrote: > On 2013-10-16, Gary Gregory wrote: > > > Now that we have a new cleaned up RC, I want to make sure that we > > understand that, strictly speaking and while unlikely in practice, > > 1.6-RC2 breaks binary compatibility with 1.5 (see Clirr).

Re: svn commit: r1533990 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/BetaDistribution.java

2013-10-21 Thread Phil Steitz
Was this maybe to the wrong thread, or is there a doco issue here? Phil > On Oct 20, 2013, at 10:42 PM, Ted Dunning wrote: > > This makes it somewhat harder to read the docs code which is where I read > docs 90+% of the time. > > On the other hand my IDE will do the right thing if I ask it

Re: svn commit: r1533990 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/BetaDistribution.java

2013-10-21 Thread Thomas Neidhart
Ok np, there are other cases where the code could be simplified, I will do the necessary changes. Thomas On Mon, Oct 21, 2013 at 12:05 AM, Phil Steitz wrote: > On 10/20/13 2:27 PM, Thomas Neidhart wrote: > > On 10/20/2013 11:24 PM, t...@apache.org wrote: > >> Author: tn > >> Date: Sun Oct 20 2

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Benedikt Ritter
Send from my mobile device > Am 21.10.2013 um 03:46 schrieb sebb : > >> On 20 October 2013 15:03, Benedikt Ritter wrote: >> I agree. If we don't deprecate it now, and agree to release the next major >> version targeting Java 7, we would remove those methods without ever >> mentioning it before

Re: [lang] Issue focus

2013-10-21 Thread Benedikt Ritter
Hi Hen, thanks for the update. I'll have a look tonight. I've been working on the checkstyle violations. There is still a lot to in FieldUtils. FindBugs and PMD also show violations. Some of them I'm not sure how to handle. Benedikt Send from my mobile device > Am 21.10.2013 um 07:49 schrieb