On 4 October 2013 23:23, James Carman wrote:
> On Fri, Oct 4, 2013 at 6:11 PM, sebb wrote:
>>
>> Back to the case in point: why is the string ".activate" and not anything
>> else?
>>
>
> Why not just extract a constant and name it something logical like
> "ACTIVATED_INDICATOR"? Then, the actual
Also, since when did we start nit-picking code in the sandbox? Why
not leave these folks alone and let them work out their ideas? The
sandbox should be an area where folks can play around with stuff and
share new ideas without being hassled by folks. If we make it a pain
in the butt, then people
On Fri, Oct 4, 2013 at 6:11 PM, sebb wrote:
>
> Back to the case in point: why is the string ".activate" and not anything
> else?
>
Why not just extract a constant and name it something logical like
"ACTIVATED_INDICATOR"? Then, the actual value of the constant can be
whatever you want. The val
On 4 October 2013 21:09, Romain Manni-Bucau wrote:
> Hi
>
> It should be done in the doc iirc. Having a constant would just mean
> loosing a line with no benefit excepted needing to browse code instead of
> reading it inline in this case cause the prop will not be used in the code
> at all so id s
I meant conceptually. I see no reason we wouldn't let sandbox
projects use Sonar also. It would help us understand how ready the
code is for "prime time" before we promote it to "proper." I was
trying to find a link to our Sonar installation, but my google-fu is
failing me at the moment.
On Fri
I thought sandbox projects were not included, any link on it?
Le 4 oct. 2013 23:02, "James Carman" a écrit :
> Sure, why not?
>
> On Fri, Oct 4, 2013 at 4:58 PM, Romain Manni-Bucau
> wrote:
> > Even for sandbox?
> > Le 4 oct. 2013 22:12, "James Carman" a
> écrit :
> >
> >> This really is somet
Sure, why not?
On Fri, Oct 4, 2013 at 4:58 PM, Romain Manni-Bucau
wrote:
> Even for sandbox?
> Le 4 oct. 2013 22:12, "James Carman" a écrit :
>
>> This really is something that Sonar should catch for us. I thought we
>> had that turned on somewhere, right?
>>
>> On Fri, Oct 4, 2013 at 2:29 PM,
Even for sandbox?
Le 4 oct. 2013 22:12, "James Carman" a écrit :
> This really is something that Sonar should catch for us. I thought we
> had that turned on somewhere, right?
>
> On Fri, Oct 4, 2013 at 2:29 PM, sebb wrote:
> > On 4 October 2013 18:04, Jean-Louis MONTEIRO wrote:
> >> Apologiz
This really is something that Sonar should catch for us. I thought we
had that turned on somewhere, right?
On Fri, Oct 4, 2013 at 2:29 PM, sebb wrote:
> On 4 October 2013 18:04, Jean-Louis MONTEIRO wrote:
>> Apologize for the late answer.
>> Not sure to understand the purpose of the request.
>>
Hi
It should be done in the doc iirc. Having a constant would just mean
loosing a line with no benefit excepted needing to browse code instead of
reading it inline in this case cause the prop will not be used in the code
at all so id stay it like it...moreover thats really a detail for the
product
On 4 October 2013 18:04, Jean-Louis MONTEIRO wrote:
> Apologize for the late answer.
> Not sure to understand the purpose of the request.
> Could you detail cause it's not used anywhere else?
The code should not contain 'magic' strings (or numbers for that matter).
All fixed strings should be do
Apologize for the late answer.
Not sure to understand the purpose of the request.
Could you detail cause it's not used anywhere else?
JLouis
2013/10/3 sebb
> On 2 October 2013 21:12, wrote:
> > Author: jlmonteiro
> > Date: Wed Oct 2 20:12:29 2013
> > New Revision: 1528612
> >
> > URL: http:
12 matches
Mail list logo
