Re: [OGNL] Make use of logging?

2013-09-03 Thread Lukasz Lenart
2013/9/3 Christian Grobmeier : > I found 11 uses of e.printStackTrace and think its pretty bad. > Including OgnlException overwrites printStackTrace and writes to > System.err for some reason. > > In addition there are a lot of System.out's, but those are all commented > and seem to have served deb

Re: [OGNL] checkstyle for maven styled code...

2013-09-03 Thread Lukasz Lenart
2013/9/3 Christian Grobmeier : > I found this in ognl pom: > > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.7 > > config/maven_checks.xml > config/maven-header.txt > > > > I thought I

[OGNL] checkstyle for maven styled code...

2013-09-03 Thread Christian Grobmeier
I found this in ognl pom: org.apache.maven.plugins maven-checkstyle-plugin 2.7 config/maven_checks.xml config/maven-header.txt I thought I would remember there is something going on with these m

[OGNL] Make use of logging?

2013-09-03 Thread Christian Grobmeier
I found 11 uses of e.printStackTrace and think its pretty bad. Including OgnlException overwrites printStackTrace and writes to System.err for some reason. In addition there are a lot of System.out's, but those are all commented and seem to have served debugging purposes. I believe small libs lik

[OGNL] Dropped JDK 1.3 Support

2013-09-03 Thread Christian Grobmeier
Please note, there was code in ognl.ASTMap to support jdk1.3. Considering maven aims at jdk 5, i removed this code. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.a

commons-lang pull request: Hash code builder

2013-09-03 Thread mureinik
GitHub user mureinik opened a pull request: https://github.com/apache/commons-lang/pull/10 Hash code builder Solution for LANG-804: Redundant check for zero in HashCodeBuilder ctor You can merge this pull request into a Git repository by running: $ git pull https://github.com/m

commons-lang pull request: Adding .gitignore to commons-lang

2013-09-03 Thread mureinik
Github user mureinik closed the pull request at: https://github.com/apache/commons-lang/pull/8 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org