Re: svn commit: r1509328 - /commons/proper/csv/trunk/NOTICE.txt

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 8:00 PM, sebb wrote: > On 1 August 2013 17:58, wrote: > > Author: ggregory > > Date: Thu Aug 1 16:58:31 2013 > > New Revision: 1509328 > > > > URL: http://svn.apache.org/r1509328 > > Log: > > [LEGAL-175] Distribute sample files from www.ferc.gov for unit tests. > > I'm n

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread James Carman
Okay, totally forgot we had ConvertUtils in BeanUtils. So, since we have the functionality, especially for Strings, and it's extensible, we could recommend that in the Javadocs perhaps. That Converter API is screaming for some generics action! On Thu, Aug 1, 2013 at 8:23 PM, Paul Benedict wrote

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Paul Benedict
I can see that we should provide a decorator/delegate (CSVRecordWrapper?) that has these additional methods and defers them to Beanutils. We should use our other Commons project to accomplish the pluggable and configurable conversion. Beanutils can be an optional Maven dependency. This doesn't belo

Re: svn commit: r1509450 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordIntTest.java

2013-08-01 Thread James Carman
How about we put it to a vote? Would you withdraw your veto if a majority votes against it? On Thu, Aug 1, 2013 at 7:55 PM, sebb wrote: > On 2 August 2013 00:44, James Carman wrote: >> You are -1ing a code modification, which means this counts as a veto. >> Are you sure you want to veto this? >

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread James Carman
Perhaps it belongs in Commons Lang? Anything like this that you try to put together is going to blow up really quickly, by the way (registering new converter types, etc.). I don't see how having a few little helper methods in CSV is that big of an issue, personally. On Thu, Aug 1, 2013 at 7:59 P

Re: svn commit: r1509328 - /commons/proper/csv/trunk/NOTICE.txt

2013-08-01 Thread sebb
On 1 August 2013 17:58, wrote: > Author: ggregory > Date: Thu Aug 1 16:58:31 2013 > New Revision: 1509328 > > URL: http://svn.apache.org/r1509328 > Log: > [LEGAL-175] Distribute sample files from www.ferc.gov for unit tests. I'm not convinced that the NOTICE should be encumbered with this. See

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Paul Benedict
You might want to think of a conversion addon package using Common BeanUtils. That project is skilled at conversions from String and has pluggable capability to customize conversion types. On Aug 1, 2013 6:51 PM, "Paul Benedict" wrote: > None of these methods document exceptions if the conversion

Re: svn commit: r1509431 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordBooleanTest.java test/java/org/apache/commons/csv

2013-08-01 Thread sebb
On 1 August 2013 22:11, wrote: > Author: ggregory > Date: Thu Aug 1 21:11:10 2013 > New Revision: 1509431 > > URL: http://svn.apache.org/r1509431 > Log: > CSVRecord.get(String) throws IAE if the column is not mapped (does not > exist). This is similar to what JDBC does in ResultSet. OK >Add g

Re: svn commit: r1509449 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordLongTest.java

2013-08-01 Thread sebb
On 1 August 2013 22:54, wrote: > Author: ggregory > Date: Thu Aug 1 21:54:37 2013 > New Revision: 1509449 > > URL: http://svn.apache.org/r1509449 > Log: > Add CSVRecord#getLong(String) API and tests. -1 We don't have agreement to add these methods. > Added: > > commons/proper/csv/trunk/s

Re: svn commit: r1509450 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordIntTest.java

2013-08-01 Thread sebb
On 2 August 2013 00:44, James Carman wrote: > You are -1ing a code modification, which means this counts as a veto. > Are you sure you want to veto this? Yes. We don't have agreement that CSV should include these methods. > On Thu, Aug 1, 2013 at 7:28 PM, sebb wrote: >> On 1 August 2013 22:57,

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Paul Benedict
None of these methods document exceptions if the conversion fails (eg, not an integer). Also, how strict is the conversion? Can "x" represent boolean false or is that an exception? On Aug 1, 2013 9:00 AM, "Gary Gregory" wrote: > I would like to note this CSVRecord addition I am planning on: > >

Re: svn commit: r1509450 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordIntTest.java

2013-08-01 Thread James Carman
You are -1ing a code modification, which means this counts as a veto. Are you sure you want to veto this? On Thu, Aug 1, 2013 at 7:28 PM, sebb wrote: > On 1 August 2013 22:57, wrote: >> Author: ggregory >> Date: Thu Aug 1 21:57:46 2013 >> New Revision: 1509450 >> >> URL: http://svn.apache.org/

Re: svn commit: r1509450 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordIntTest.java

2013-08-01 Thread sebb
On 1 August 2013 22:57, wrote: > Author: ggregory > Date: Thu Aug 1 21:57:46 2013 > New Revision: 1509450 > > URL: http://svn.apache.org/r1509450 > Log: > Add CSVRecord#getInt(String) API and tests. -1 I think this is out of scope for CSV. > Added: > > commons/proper/csv/trunk/src/test/j

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread sebb
On 1 August 2013 23:32, Emmanuel Bourg wrote: > Le 01/08/2013 21:45, Benedikt Ritter a écrit : >> I agree with Gary. This sounds like a useful feature that doesn't seem to >> be to hard to implement. And if he (Gary) has the time to do the necessary >> coding, why not? > > Because you start with g

Re: svn commit: r1509260 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2013-08-01 Thread sebb
On 1 August 2013 15:51, Gary Gregory wrote: > Thank you for catching this Sebb. Thank Eclipse. > Gary > > > On Thu, Aug 1, 2013 at 10:38 AM, wrote: > >> Author: sebb >> Date: Thu Aug 1 14:38:17 2013 >> New Revision: 1509260 >> >> URL: http://svn.apache.org/r1509260 >> Log: >> Remove doc for no

Re: svn commit: r1509450 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordIntTest.java

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 23:57, ggreg...@apache.org a écrit : > Add CSVRecord#getInt(String) API and tests. All of these methods are already implemented in [configuration] with pretty much all the types you might need (Enums, URLs, colors, emails, dates, calendars, primitives, arrays, etc). If CSVRecord cou

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 21:45, Benedikt Ritter a écrit : > I agree with Gary. This sounds like a useful feature that doesn't seem to > be to hard to implement. And if he (Gary) has the time to do the necessary > coding, why not? Because you start with getBoolean(), then you add getInt(), getDate(), getList(

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 3:45 PM, Benedikt Ritter wrote: > I agree with Gary. This sounds like a useful feature that doesn't seem to > be to hard to implement. And if he (Gary) has the time to do the necessary > coding, why not? > > The only thing I don't like is the getBooleanPrimitive(String) met

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Benedikt Ritter
I agree with Gary. This sounds like a useful feature that doesn't seem to be to hard to implement. And if he (Gary) has the time to do the necessary coding, why not? The only thing I don't like is the getBooleanPrimitive(String) method. I think it is enough to have a getBoolean(String) that return

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
can you add asm and run benchmark 10 times? *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau*

Re: [proxy] and impl

2013-08-01 Thread James Carman
This is rudimentary off the top of my head, but the following code produces this output: It took a total of 9.022382 seconds using $Proxy0. It took a total of 5.528322 seconds using TestAnnotationTrainer$Foo$$EnhancerByCGLIB$$c462c19e. It took a total of 5.084160 seconds using JavassistUtilsGenera

[continuum] BUILD FAILURE: Apache Commons - Commons Sandbox Parent - Group (shared) Maven 2 Build Definition (Java 1.5)

2013-08-01 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=27212&projectId=132 Build statistics: State: Failed Previous State: Failed Started at: Thu 1 Aug 2013 15:52:16 + Finished at: Thu 1 Aug 2013 15:52:28 + Total time: 11s Build Trigger: Schedule Buil

[continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-08-01 Thread Continuum@vmbuild
Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 97 X-Continuum-Project-Name: Commons Math Online report : http://vmbuild.apache.org/con

[continuum] BUILD FAILURE: Apache Commons - Commons DBCP -

2013-08-01 Thread Continuum@vmbuild
Project Maven 2 Build Definition (Java 1.7) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 73 X-Continuum-Project-Name: Commons DBCP Online report : http://vmbuild.apache.org/continuum/

[continuum] BUILD FAILURE: Apache Commons - Commons Pool -

2013-08-01 Thread Continuum@vmbuild
Build using Java 1.6 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 98 X-Continuum-Project-Name: Commons Pool Online report : http://vmbuild.apache.org/continuum/buildResult.action?buil

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
hehe, do you have figures? when JIT did its work reflection is almost free. You can update the asm proxy factory to handle 3 implementations but it is not worth it IMO *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/*

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 10:30 AM, sebb wrote: > On 1 August 2013 15:21, Emmanuel Bourg wrote: > > Just like the bean mapping I prefer to keep the type conversion out of > 1.0. > > > > +1 > > It's definitely not essential to the initial release. > It's one of those things that was not essential t

Re: [proxy] and impl

2013-08-01 Thread Matt Benson
That's why I think we're going to want to have the ability to mine the config of a switchInterceptor. A given impl could inspect the config and say, oh this is a method name invocationmatcher; I'll eliminate a level and match the method directly to the consequent interceptor up front. For more dy

Re: [proxy] and impl

2013-08-01 Thread James Carman
You're going to lose the benefit of having ASM if you just end up using reflection to call the methods anyway aren't you? The Javassist code actually generates Java code that actually calls the real method on an instance of the appropriate type. That's what makes it faster. On Thu, Aug 1, 2013 a

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
No, but believe me you want a handler (this one or invoker) to maintain the code and keep it easy. *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rm

Re: [CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 10:53 AM, Benedikt Ritter wrote: > 2013/8/1 Gary Gregory > > > On Thu, Aug 1, 2013 at 10:35 AM, sebb wrote: > > > > > On 1 August 2013 15:23, Emmanuel Bourg wrote: > > > > Le 01/08/2013 16:17, Benedikt Ritter a écrit : > > > > > > > >> since Emmanuel has hijacked the ori

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 10:52 AM, Emmanuel Bourg wrote: > Le 01/08/2013 16:48, Gary Gregory a écrit : > > > I agree with Sebb. In addition, the whole point is to use 'real world' > > files. If we are not allowed this particular file set, then that's too > bad. > > Alternatively, if the URL is stab

Re: [proxy] and impl

2013-08-01 Thread Matt Benson
That's my point; it doesn't. On Thu, Aug 1, 2013 at 9:49 AM, James Carman wrote: > Does the ASM API require a java.lang.reflect.InvocationHandler? > > On Thu, Aug 1, 2013 at 10:41 AM, Romain Manni-Bucau > wrote: > > Well for the maintainance it is easier (and not really slower) to use a > > lit

Re: [CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/

2013-08-01 Thread Benedikt Ritter
2013/8/1 Gary Gregory > On Thu, Aug 1, 2013 at 10:35 AM, sebb wrote: > > > On 1 August 2013 15:23, Emmanuel Bourg wrote: > > > Le 01/08/2013 16:17, Benedikt Ritter a écrit : > > > > > >> since Emmanuel has hijacked the original thread for discussing legal > > >> issues, I'm bringing this up und

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 16:48, Gary Gregory a écrit : > I agree with Sebb. In addition, the whole point is to use 'real world' > files. If we are not allowed this particular file set, then that's too bad. Alternatively, if the URL is stable the file could be downloaded during the tests. Emmanuel Bourg -

Re: svn commit: r1509260 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2013-08-01 Thread Gary Gregory
Thank you for catching this Sebb. Gary On Thu, Aug 1, 2013 at 10:38 AM, wrote: > Author: sebb > Date: Thu Aug 1 14:38:17 2013 > New Revision: 1509260 > > URL: http://svn.apache.org/r1509260 > Log: > Remove doc for non-existent parameter > > Modified: > > commons/proper/csv/trunk/src/main/java

Re: [CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 10:35 AM, sebb wrote: > On 1 August 2013 15:23, Emmanuel Bourg wrote: > > Le 01/08/2013 16:17, Benedikt Ritter a écrit : > > > >> since Emmanuel has hijacked the original thread for discussing legal > >> issues, I'm bringing this up under a new topic ;-) > > > > Hey I simp

Re: [proxy] and impl

2013-08-01 Thread James Carman
Does the ASM API require a java.lang.reflect.InvocationHandler? On Thu, Aug 1, 2013 at 10:41 AM, Romain Manni-Bucau wrote: > Well for the maintainance it is easier (and not really slower) to use a > little abstraction. InvocationHandler/Inoker is fine. Since JdkProxy uses > the exact same code i

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 10:08 AM, sebb wrote: > On 1 August 2013 14:51, James Carman wrote: > > Why not just create files that look like these files? Do we have to > > use the originals? > > If it's necessary to read the originals to create the look-alikes, > that seems like cheating to me. > I

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
Well for the maintainance it is easier (and not really slower) to use a little abstraction. InvocationHandler/Inoker is fine. Since JdkProxy uses the exact same code i throught it could be shared. *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmanni

Re: [CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/

2013-08-01 Thread sebb
On 1 August 2013 15:23, Emmanuel Bourg wrote: > Le 01/08/2013 16:17, Benedikt Ritter a écrit : > >> since Emmanuel has hijacked the original thread for discussing legal >> issues, I'm bringing this up under a new topic ;-) > > Hey I simply started a parallel discussion ;) > > +1 for NoSuchElementE

Re: [proxy] and impl

2013-08-01 Thread Matt Benson
The behavior of proxies is specified by Invokers, ObjectProviders, and Interceptors. Each ProxyFactory implementation bridges from these interfaces to the most appropriate mechanism specific to the target technology. In the case of ASM, I would think that would be direct calls against the proxy int

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread sebb
On 1 August 2013 15:21, Emmanuel Bourg wrote: > Just like the bean mapping I prefer to keep the type conversion out of 1.0. > +1 It's definitely not essential to the initial release. I'm not sure it belongs in CSV at all. > Emmanuel Bourg > > > Le 01/08/2013 16:00, Gary Gregory a écrit : >> I

Re: [proxy] and impl

2013-08-01 Thread James Carman
Which code are you worried about? The checking for equals/hashcode? On Thu, Aug 1, 2013 at 10:21 AM, Romain Manni-Bucau wrote: > a sed shold almost work but the issue is the same: the code is duplicated, > no? is there invoker elsewhere? > > *Romain Manni-Bucau* > *Twitter: @rmannibucau

Re: [CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 16:17, Benedikt Ritter a écrit : > since Emmanuel has hijacked the original thread for discussing legal > issues, I'm bringing this up under a new topic ;-) Hey I simply started a parallel discussion ;) +1 for NoSuchElementException Emmanuel Bourg ---

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
a sed shold almost work but the issue is the same: the code is duplicated, no? is there invoker elsewhere? *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.c

Re: [csv] record.get APIs for primitive types

2013-08-01 Thread Emmanuel Bourg
Just like the bean mapping I prefer to keep the type conversion out of 1.0. Emmanuel Bourg Le 01/08/2013 16:00, Gary Gregory a écrit : > I would like to note this CSVRecord addition I am planning on: > > public Boolean getBoolean(String name) { > public boolean getBooleanPrimitive(Strin

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread James Carman
Are you kidding me? We can't ascertain a file format from some example file and create a similarly-formatted file in our test resources which exhibits this format to make sure we handle it? It's CSV! I can't imagine anyone can claim this is their IP. Do they have a patent on using CSV in this f

Re: [proxy] and impl

2013-08-01 Thread Matt Benson
But is there some technical reason why it's helpful for ASM proxies to use InvocationHandler specifically? Why wouldn't they just use Invoker directly? Matt On Thu, Aug 1, 2013 at 8:51 AM, Romain Manni-Bucau wrote: > +1 > > jdkproxyfactory can even be hardcoded as a default IMO (without using

[CSV] Throw NoSuchElementException from Iterator if CSVParser is closed? (was: Fwd: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/comm

2013-08-01 Thread Benedikt Ritter
Hi, since Emmanuel has hijacked the original thread for discussing legal issues, I'm bringing this up under a new topic ;-) Please see my comments below. Benedikt -- Forwarded message -- From: Benedikt Ritter Date: 2013/8/1 Subject: Re: svn commit: r1509068 - in /commons/proper

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread sebb
On 1 August 2013 14:51, James Carman wrote: > Why not just create files that look like these files? Do we have to > use the originals? If it's necessary to read the originals to create the look-alikes, that seems like cheating to me. I don't think that's something as a part of the ASF that Commo

Re: [csv] the plot thinkens: multi-record headers

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 8:51 AM, sebb wrote: > On 1 August 2013 10:56, Emmanuel Bourg wrote: > > Le 01/08/2013 01:38, Gary Gregory a écrit : > > > >> Thoughts? > > > > You'll always find a weird formats that doesn't fit with the common > > model. I don't think we should spend too much time trying

[csv] record.get APIs for primitive types

2013-08-01 Thread Gary Gregory
I would like to note this CSVRecord addition I am planning on: public Boolean getBoolean(String name) { public boolean getBooleanPrimitive(String name) The method listings are at the end of this message. What I want to note here is that these are conversion methods and that the record st

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
+1 jdkproxyfactory can even be hardcoded as a default IMO (without using the SPI) *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Git

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread James Carman
Why not just create files that look like these files? Do we have to use the originals? On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory wrote: > On Thu, Aug 1, 2013 at 8:56 AM, sebb wrote: > >> On 1 August 2013 13:48, Gary Gregory wrote: >> > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg >> wrot

Re: [proxy] and impl

2013-08-01 Thread James Carman
You mean all the InvocationHandler classes in JdkProxy? I guess we could break those out into top-level classes, but then you'd have multiple implementations on your classpath if you made a dependency on commons-proxy-jdk. We could move those to "core" I guess. On Thu, Aug 1, 2013 at 7:49 AM, Ro

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 8:56 AM, sebb wrote: > On 1 August 2013 13:48, Gary Gregory wrote: > > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg > wrote: > > > >> Le 01/08/2013 04:03, ggreg...@apache.org a écrit : > >> > >> > - Add some real world CSV files. > >> > >> Are we allowed to distribute t

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread sebb
On 1 August 2013 13:48, Gary Gregory wrote: > On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg wrote: > >> Le 01/08/2013 04:03, ggreg...@apache.org a écrit : >> >> > - Add some real world CSV files. >> >> Are we allowed to distribute these files? >> > > I did not see any copyrights, or licenses. I

Re: [csv] the plot thinkens: multi-record headers

2013-08-01 Thread sebb
On 1 August 2013 10:56, Emmanuel Bourg wrote: > Le 01/08/2013 01:38, Gary Gregory a écrit : > >> Thoughts? > > You'll always find a weird formats that doesn't fit with the common > model. I don't think we should spend too much time trying to support all > of them. +1 > In this case the header wi

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Gary Gregory
On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg wrote: > Le 01/08/2013 04:03, ggreg...@apache.org a écrit : > > > - Add some real world CSV files. > > Are we allowed to distribute these files? > I did not see any copyrights, or licenses. I did not text that states you cannot. I do see text about

Re: [proxy] and impl

2013-08-01 Thread Romain Manni-Bucau
Ok for all excepted last point (i was not clear i think). The ProxyFactory impl using jdk proxy uses Invocationhandler like the asm implementation so it would be great to be able to share the handler classes between both impl. *Romain Manni-Bucau* *Twitter: @rmannibucau

Re: [proxy] and impl

2013-08-01 Thread James Carman
On Thu, Aug 1, 2013 at 2:44 AM, Romain Manni-Bucau wrote: > ok, > > here it is: https://gist.github.com/rmannibucau/6128964 > Thanks! > > 1) i didn't fully get the goal of stub module, any pointers? It provides features very similar to the mocking support in libraries like Mockito/EasyMock. Ba

Re: commons-monitoring?

2013-08-01 Thread Olivier Lamy
+1 2013/8/1 Romain Manni-Bucau : > Do we want to keep cxf module? > > IMO it can be replaced by a monitoring filter (web module) > > wdyt? > > *Romain Manni-Bucau* > *Twitter: @rmannibucau * > *Blog: **http://rmannibucau.wordpress.com/*

Re: [csv] the plot thinkens: multi-record headers

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 01:38, Gary Gregory a écrit : > Thoughts? You'll always find a weird formats that doesn't fit with the common model. I don't think we should spend too much time trying to support all of them. In this case the header will have to be provided by the developer, and the first lines ski

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Emmanuel Bourg
Le 01/08/2013 04:03, ggreg...@apache.org a écrit : > - Add some real world CSV files. Are we allowed to distribute these files? Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional command

Re: commons-monitoring?

2013-08-01 Thread Romain Manni-Bucau
Do we want to keep cxf module? IMO it can be replaced by a monitoring filter (web module) wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rma

Re: svn commit: r1509068 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/ test/resources/ferc.gov/

2013-08-01 Thread Benedikt Ritter
Hi Gary, 2013/8/1 > Author: ggregory > Date: Thu Aug 1 02:03:33 2013 > New Revision: 1509068 > > URL: http://svn.apache.org/r1509068 > Log: > - Add some real world CSV files. > - Add a record API to get column values using an Enum. > - Throw a better exception when a resource is not found in a