Re: [pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/c

2013-07-29 Thread James Carman
I like the sound of that! On Mon, Jul 29, 2013 at 2:42 PM, Gary Gregory wrote: > On Mon, Jul 29, 2013 at 1:56 PM, Phil Steitz wrote: > >> On 7/24/13 1:06 PM, Mark Thomas wrote: >> > On 24/07/2013 21:01, ma...@apache.org wrote: >> >> Author: markt >> >> Date: Wed Jul 24 20:01:34 2013 >> >> New R

Re: [pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/c

2013-07-29 Thread Gary Gregory
On Mon, Jul 29, 2013 at 1:56 PM, Phil Steitz wrote: > On 7/24/13 1:06 PM, Mark Thomas wrote: > > On 24/07/2013 21:01, ma...@apache.org wrote: > >> Author: markt > >> Date: Wed Jul 24 20:01:34 2013 > >> New Revision: 1506685 > >> > >> URL: http://svn.apache.org/r1506685 > >> Log: > >> Create two n

Re: [pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/

2013-07-29 Thread Phil Steitz
On 7/29/13 11:11 AM, Mark Thomas wrote: > On 29/07/2013 19:56, Phil Steitz wrote: >> On 7/24/13 1:06 PM, Mark Thomas wrote: >>> On 24/07/2013 21:01, ma...@apache.org wrote: Author: markt Date: Wed Jul 24 20:01:34 2013 New Revision: 1506685 URL: http://svn.apache.org/r150668

Re: [pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/

2013-07-29 Thread Mark Thomas
On 29/07/2013 19:56, Phil Steitz wrote: > On 7/24/13 1:06 PM, Mark Thomas wrote: >> On 24/07/2013 21:01, ma...@apache.org wrote: >>> Author: markt >>> Date: Wed Jul 24 20:01:34 2013 >>> New Revision: 1506685 >>> >>> URL: http://svn.apache.org/r1506685 >>> Log: >>> Create two new factory interfaces

[pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/comm

2013-07-29 Thread Phil Steitz
On 7/24/13 1:06 PM, Mark Thomas wrote: > On 24/07/2013 21:01, ma...@apache.org wrote: >> Author: markt >> Date: Wed Jul 24 20:01:34 2013 >> New Revision: 1506685 >> >> URL: http://svn.apache.org/r1506685 >> Log: >> Create two new factory interfaces that work with PooledObject instances >> rather t

Re: [proxy] and impl

2013-07-29 Thread Romain Manni-Bucau
hmm not sure i follow, here we don't shade asm (it is already done) and if all libs shade it we will have at least 5 shade of the same version in tomee for instance (same comment on the app side) so that's not a solution for each lib. [proxy] is small enough to not shade IMO. That said if your relo

Re: svn commit: r1508094 - in /commons/proper/proxy/branches/version-2.0-work: ./ core/src/main/java/org/apache/commons/proxy2/interceptor/SwitchInterceptor.java core/src/test/java/org/apache/commons/

2013-07-29 Thread Matt Benson
Of course you're correct. Sorry for the noise! :) br, Matt On Mon, Jul 29, 2013 at 10:17 AM, James Carman wrote: > CaseBuilder returns "this" SwitchInterceptor from the then() method, > so it can't be static. Needs to have a reference to its enclosing > SwitchInterceptor. > > On Mon, Jul 29,

Re: [proxy] and impl

2013-07-29 Thread Matt Benson
Rather than duplicating code I thought we could code to asm4's released jars, and provide the basic proxy-asm artifact. Then shade asm4 and provide proxy-asm-shaded. Then optionally, we could create another shaded jar that relocates to the same destination as xbean-shaded-asm4 but does not actual

Re: svn commit: r1508094 - in /commons/proper/proxy/branches/version-2.0-work: ./ core/src/main/java/org/apache/commons/proxy2/interceptor/SwitchInterceptor.java core/src/test/java/org/apache/commons/

2013-07-29 Thread James Carman
CaseBuilder returns "this" SwitchInterceptor from the then() method, so it can't be static. Needs to have a reference to its enclosing SwitchInterceptor. On Mon, Jul 29, 2013 at 11:12 AM, Matt Benson wrote: > CaseBuilder could be static as well. > > Matt > > > On Mon, Jul 29, 2013 at 10:10 AM,

Re: svn commit: r1508094 - in /commons/proper/proxy/branches/version-2.0-work: ./ core/src/main/java/org/apache/commons/proxy2/interceptor/SwitchInterceptor.java core/src/test/java/org/apache/commons/

2013-07-29 Thread Matt Benson
CaseBuilder could be static as well. Matt On Mon, Jul 29, 2013 at 10:10 AM, wrote: > Author: jcarman > Date: Mon Jul 29 15:10:07 2013 > New Revision: 1508094 > > URL: http://svn.apache.org/r1508094 > Log: > PROXY-20: Changing API around a bit to be more "fluent" > > Modified: > commons/pro

Re: [proxy] and impl

2013-07-29 Thread Romain Manni-Bucau
You have the clean proxy code here (just rework the method generation which is a bit different): http://svn.apache.org/repos/asf/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyFactory.java the point is i already have cases where i want to use asm

Re: [DBCP] DBCP2 and logging

2013-07-29 Thread Mark Thomas
On 27/07/2013 00:24, James Carman wrote: > Perhaps an event listener for all dbcp events? Then folks can log it > themselves. I would be concerned about performance unless of course the > events are delivered asynchronously. My initial reaction was - neat idea lets do it. However, on further re

Re: [proxy] and impl

2013-07-29 Thread Matt Benson
On Sun, Jul 28, 2013 at 12:16 PM, Romain Manni-Bucau wrote: > answers inline > > *Romain Manni-Bucau* > *Twitter: @rmannibucau * > *Blog: **http://rmannibucau.wordpress.com/* > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* >

Re: [Math] "RandomDataGenerator.nextInt" vs "UniformIntegerDistribution.sample"

2013-07-29 Thread Phil Steitz
On 7/25/13 4:50 AM, Gilles wrote: > Hi. > > The classes > RandomDataGenerator > and > UniformIntegerDistribution > use different codes for providing random integers in a range. > > Shouldn't the same code be used in both? > Are both equally valid on the whole integer range? The version in Rando