Re: commons-monitoring?

2013-07-28 Thread Romain Manni-Bucau
Hi i was able to commit this morning :) *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 201

Re: commons-monitoring?

2013-07-28 Thread Romain Manni-Bucau
Hi, thanks Mark but i still get issues: โ”Œ( rmannibucau @ ubuntu )โ”€( 1.7.0 -:- 3.1.0 ) โ””( /opt/dev/tomee/commons-monitoring )ยท> svn ci -m "removing gauge which weren't really gauge, replacing it by a counter in counters, adding basic config, splitting in several modules, adding some js sorting/fil

Re: [proxy] and impl

2013-07-28 Thread Romain Manni-Bucau
answers inline *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/7/28 Matt Benson > Int

Re: [proxy] and impl

2013-07-28 Thread Matt Benson
Interesting patch. I have some questions and comments: - You'd additionally need to make sure the impl class is non-final, no? - note to others that asm4-shaded is used because asm didn't change packages from v3. Good to see this in use; I hadn't kept track after submitting that patch. ;-) - Woul

Re: commons-monitoring?

2013-07-28 Thread Mark Struberg
Hi folks! Romain is a great guy, I've now added him to commons-sandbox. LieGrue, strub - Original Message - From: James Carman To: Commons Developers List Cc: Sent: Saturday, 27 July 2013, 3:46 Subject: Re: commons-monitoring? On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau w

Re: [proxy] and impl

2013-07-28 Thread Romain Manni-Bucau
Hi here is a patch implementing proxying using ASM: https://gist.github.com/rmannibucau/6099063 having the handlers used by default in ProxyFactory protected would avoid to copy them in ASMProxyFactory. *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http:

[CSV][RTC] Revert builder implementation in CSVFormat

2013-07-28 Thread Benedikt Ritter
Hi guys, we've taked about this a lot and finally came to the agreement that we want to revert the builder implementation we've added a while ago. I've created a patch for this and attached it to CSV-99 [1]. Since this is a massive change in how the API works from a user POV I'd like to have some