Re: [DBCP] DBCP2 and logging

2013-07-26 Thread Romain Manni-Bucau
I like it! Le 27 juil. 2013 04:24, "James Carman" a écrit : > On Fri, Jul 26, 2013 at 10:01 PM, Gary Gregory > wrote: > > On Jul 26, 2013, at 19:24, James Carman > wrote: > > > >> Perhaps an event listener for all dbcp events? Then folks can log it > >> themselves. > > > > I would then expect

Re: [proxy] Package Dependency Cycles...

2013-07-26 Thread James Carman
The nullValue() method would stay. I'm talking about the nullObject() methods, which create objects of any type that return null values for all methods. Sent from my iPad On Jul 26, 2013, at 11:33 PM, Matt Benson wrote: > I know I have used the #nullValue() utility method elsewhere before, so

Re: [proxy] Package Dependency Cycles...

2013-07-26 Thread Matt Benson
I know I have used the #nullValue() utility method elsewhere before, so I'd prefer the latter option, or in the case of the former to provide a similar method in [lang]. Matt On Jul 26, 2013 10:26 PM, "James Carman" wrote: > We currently have some package cycles according to Sonar. The > org.ap

[proxy] Package Dependency Cycles...

2013-07-26 Thread James Carman
We currently have some package cycles according to Sonar. The org.apache.commons.proxy2 (I'm working in the branch) package depends on the org.apache.commons.proxy2.interceptor package (and vice versa) because of its use of the NullInvoker class to create "null objects." Since we have a little

Re: [DBCP] DBCP2 and logging

2013-07-26 Thread James Carman
On Fri, Jul 26, 2013 at 10:01 PM, Gary Gregory wrote: > On Jul 26, 2013, at 19:24, James Carman wrote: > >> Perhaps an event listener for all dbcp events? Then folks can log it >> themselves. > > I would then expect dbcp to deliver a logging implementation, probably > not hooked up by default. >

Re: [DBCP] DBCP2 and logging

2013-07-26 Thread Gary Gregory
On Jul 26, 2013, at 19:24, James Carman wrote: > Perhaps an event listener for all dbcp events? Then folks can log it > themselves. I would then expect dbcp to deliver a logging implementation, probably not hooked up by default. Gary > I would be concerned about performance unless of course

Re: commons-monitoring?

2013-07-26 Thread James Carman
On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau wrote: > Well we can discuss it in another thread but basically commons spirit for > me is more basic and shouldn't be a facade (excepted logging). So i'd > rather see proxy as an implementation of proxying using asm efficiently. > The issue with

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Well we can discuss it in another thread but basically commons spirit for me is more basic and shouldn't be a facade (excepted logging). So i'd rather see proxy as an implementation of proxying using asm efficiently. The issue with proxying is not its lifecycle or API in general but its specificiti

Re: [DBCP] DBCP2 and logging

2013-07-26 Thread James Carman
On Jul 26, 2013, at 8:22 PM, sebb wrote: > > So long as the docs make very clear that the listener must complete > quickly, I don't see why DBCP should have to take additional > precautions. > Indeed it might be useful for debugging if the listener were synchronous. > I'm cool with that. We

Re: [DBCP] DBCP2 and logging

2013-07-26 Thread sebb
On 27 July 2013 00:24, James Carman wrote: > Perhaps an event listener for all dbcp events? Then folks can log it > themselves. I would be concerned about performance unless of course the > events are delivered asynchronously. So long as the docs make very clear that the listener must complete

Re: [DBCP] DBCP2 and logging

2013-07-26 Thread James Carman
Perhaps an event listener for all dbcp events? Then folks can log it themselves. I would be concerned about performance unless of course the events are delivered asynchronously. On Wednesday, July 24, 2013, Phil Steitz wrote: > On 7/24/13 12:56 AM, Mark Thomas wrote: > > I'm working my way thro

Re: commons-monitoring?

2013-07-26 Thread James Carman
I didn't like the optional dependencies either. Version 2 splits that stuff out into their own modules with real dependencies, so that fixes that. Has Javassist fixed their memory leaks? If so, we should upgrade our dependency. I guess I don't understand what features you feel are missing. We'

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Mem leak through transitive deps (javassist for instance) Optional is the issue = doesnt work out of the box I see the project as a facade where id expect features inside (owb proxy should be close to reusable). Btw i dont know v2 so maybe i was irrelevant, i have to check. Thanks for pointing i

Re: commons-monitoring?

2013-07-26 Thread Matt Benson
That would be great. I had wanted to add some form of dynamic arg matching to the stub stuff, but had gotten hung up on the dog food consideration and wanted to use [functor]'s UnaryPredicate interface for this. Maybe best to just let it die for [proxy] 2.0 and come back to it later. Other than

Re: commons-monitoring?

2013-07-26 Thread James Carman
True! I have some time. Want to bang out the 2.0 code, Matt? Finally kids are getting older and I have some of my time back! On Friday, July 26, 2013, Matt Benson wrote: > and don't forget the proxy2 branch :D > > > On Fri, Jul 26, 2013 at 4:51 PM, James Carman > > >wrote: > > > What mem lea

Re: commons-monitoring?

2013-07-26 Thread Matt Benson
and don't forget the proxy2 branch :D On Fri, Jul 26, 2013 at 4:51 PM, James Carman wrote: > What mem leak? > > What is wrong with the transitive deps? They're all optional. > > What proxying logic is missing? > > On Friday, July 26, 2013, Romain Manni-Bucau wrote: > > > Mem leak, no transitive

Re: commons-monitoring?

2013-07-26 Thread James Carman
What mem leak? What is wrong with the transitive deps? They're all optional. What proxying logic is missing? On Friday, July 26, 2013, Romain Manni-Bucau wrote: > Mem leak, no transitive dep mgt, few proxying logic so depend a lot on > others etc... > Le 26 juil. 2013 23:43, "James Carman" >

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Mem leak, no transitive dep mgt, few proxying logic so depend a lot on others etc... Le 26 juil. 2013 23:43, "James Carman" a écrit : > Issues such as? > > On Friday, July 26, 2013, Romain Manni-Bucau wrote: > > > Commons-proxy you mean? I removed it. ATM we have cdi proxying, > > aopalliance, il

Re: commons-monitoring?

2013-07-26 Thread James Carman
Issues such as? On Friday, July 26, 2013, Romain Manni-Bucau wrote: > Commons-proxy you mean? I removed it. ATM we have cdi proxying, > aopalliance, ill add a correct aspectj and if we want more well use/(update > commons proxy to use) asm. Commons proxy brings an easy API which a bunch > of iss

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Commons-proxy you mean? I removed it. ATM we have cdi proxying, aopalliance, ill add a correct aspectj and if we want more well use/(update commons proxy to use) asm. Commons proxy brings an easy API which a bunch of issues behind ATM IMHO Le 26 juil. 2013 19:26, "James Carman" a écrit : > Well,

Re: [CSV] Towards release 1.0

2013-07-26 Thread Benedikt Ritter
Hi, I've attached a patch to CSV-99 [1]. Feedback is welcome! If nobody objects, I'll apply this patch on sunday. Benedikt [1] https://issues.apache.org/jira/browse/CSV-99 2013/7/24 Benedikt Ritter > Hi Roger, > > tbh I'm not really working on CSV-99. I planed to but then got caught up. > Bu

Re: commons-monitoring?

2013-07-26 Thread James Carman
Well, with [proxy], you can get your AOP you're looking for, too. On Wed, Feb 13, 2013 at 3:02 PM, Mark Struberg wrote: > I'm not sure if this is needed in this case. > > The Java interceptors spec got moved out of EJB a long time a go and is now a > standalone spec which is used by CDI, Spring

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Here is where i am: https://gist.github.com/rmannibucau/2aebf3f72523c9a9 i moved a bit packages, refactored a bit modules, added a Configuration class which is just a kind of very very light IoC based on properties (in fact it just handles instantiation + close() if the instance if closable).

Re: svn commit: r1507310 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingResultSet.java

2013-07-26 Thread sebb
On 26 July 2013 14:47, wrote: > Author: markt > Date: Fri Jul 26 13:47:37 2013 > New Revision: 1507310 > > URL: http://svn.apache.org/r1507310 > Log: > Make constructors private to ensure creation of DelegatingResultSet instances > is always via the static wrapResultSet(...) methods. This shoul

Re: commons-monitoring?

2013-07-26 Thread Benedikt Ritter
I have send Luc a mail. He probably hasn't followed this disucssion. I'll get back, when he gets in touch with me. 2013/7/26 Romain Manni-Bucau > Hi Benedikt, > > rmannibucau > > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.

Re: commons-monitoring?

2013-07-26 Thread Romain Manni-Bucau
Hi Benedikt, rmannibucau Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2013/7/26 Benedikt Ritter > > 2013/7/25 sebb > > > On 25 July 2013 19:40, Benedikt Ritter wrote: >

Re: commons-monitoring?

2013-07-26 Thread Benedikt Ritter
2013/7/25 sebb > On 25 July 2013 19:40, Benedikt Ritter wrote: > > Not every ASF committer can commit to commons repos but we have agreed to > > grant everybody committer write access to the sandbox if we are asked for > > it :-) > > > > Not sure how the exact process for this is. Can anybody he