2013/5/7 sebb
> On 6 May 2013 15:19, Benedikt Ritter wrote:
> > 2013/5/6
> >
> >> Author: sebb
> >> Date: Mon May 6 14:09:05 2013
> >> New Revision: 1479574
> >>
> >> URL: http://svn.apache.org/r1479574
> >> Log:
> >> Fix up internal raw types
> >>
> >
> > Keep in mind, that this will make app
I have reverted the commit and commented why we use an anonymous subclass
of DefaultExpectionContext. But to be honest I don't really see the point.
Since the signature of the constructor is
public ContextedRuntimeException(final String message, final Throwable
cause, ExceptionContext context)
ev
I think there is also a record count that should be consistent with
1-based indexing if it is not already.
Gary
On May 6, 2013, at 18:19, sebb wrote:
> I've just noticed that its Javadoc is inconsistent/ambiguous:
>
>/**
> * Returns the number of lines read
> *
> * @return the c
On 2013-05-06, Damjan Jovanovic wrote:
> I've been hacking on a patch that adds support for reading 7zip archives.
COMPRESS-54 is the most popular issue so you'd make quite a few people
happy.
You are talking about read-only suppport, right?
AFAIR there've been either legal/license or technical
On 6 May 2013 15:19, Benedikt Ritter wrote:
> 2013/5/6
>
>> Author: sebb
>> Date: Mon May 6 14:09:05 2013
>> New Revision: 1479574
>>
>> URL: http://svn.apache.org/r1479574
>> Log:
>> Fix up internal raw types
>>
>
> Keep in mind, that this will make applying patches created before
> generificat
On 6 May 2013 23:32, Jörg Schaible wrote:
>
> -1
>
> The test for this constructor showed, that you could use an own implementation
> for the last parameter. Providing a DefaultExceptionContext makes no
> difference to providing null (as it is done implicitly by the other
> constructors).
>
When
-1
The test for this constructor showed, that you could use an own implementation
for the last parameter. Providing a DefaultExceptionContext makes no
difference to providing null (as it is done implicitly by the other
constructors).
--- Weitergeleitete Nachricht (Anfang)
Betreff
I've just noticed that its Javadoc is inconsistent/ambiguous:
/**
* Returns the number of lines read
*
* @return the current-line-number (or -1)
*/
"Number of lines read" - I assume that is zero until the first
complete line has been read, i.e. 0-based.
"Current-line-numbe
On 6 May 2013 20:12, wrote:
> Author: tn
> Date: Mon May 6 19:12:25 2013
> New Revision: 1479682
>
> URL: http://svn.apache.org/r1479682
> Log:
> Add again chainedIterator method with 2 iterators to avoid generics warning
> in client code.
Please document this in the code, not just SVN log.
>
On Mon, May 6, 2013 at 5:49 PM, sebb wrote:
> The line number returned by
>
> ExtendedBufferedReader.getLineNumber()
>
> currently starts at zero, so an error in the first line in the file is
> reported as being in line 0.
>
> There does not seem to be any good reason for using a zero-based line
The line number returned by
ExtendedBufferedReader.getLineNumber()
currently starts at zero, so an error in the first line in the file is
reported as being in line 0.
There does not seem to be any good reason for using a zero-based line
number, so I would like to change it to 1-based. Some tests
On 6 May 2013 18:53, Benedikt Ritter wrote:
> 2013/5/5 sebb
>
> > On 3 May 2013 14:37, Benedikt Ritter wrote:
> >
> > > (moving this to a new thread)
> > >
> > > Hi,
> > >
> > > I did a very small refactoring in Lexer just to realize that the
> > isXXX(int)
> > > methods (like boolean isDelimit
Sorry about any double posting, it seems I did not "Reply All" on my 1st
try... arg.
Gary
On Mon, May 6, 2013 at 2:09 PM, Benedikt Ritter wrote:
> Again, Gary? ;-)
>
>
> 2013/5/6 Gary Gregory
>
> > Hi All:
> >
> > -1, see below WRT missing license headers.
> >
> > - I just fixed the FindBugs
Again, Gary? ;-)
2013/5/6 Gary Gregory
> Hi All:
>
> -1, see below WRT missing license headers.
>
> - I just fixed the FindBugs issue from
> https://people.apache.org/~rgoers/log4j2/log4j-api/findbugs.html
> BugCategoryDetailsLinePriority Argument of type String can't be handled by
> format spe
Hi All:
-1, see below WRT missing license headers.
- I just fixed the FindBugs issue from
https://people.apache.org/~rgoers/log4j2/log4j-api/findbugs.html
BugCategoryDetailsLinePriority Argument of type String can't be handled by
format specifier %d in new
org.apache.logging.log4j.message.Structu
2013/5/5 sebb
> On 3 May 2013 14:37, Benedikt Ritter wrote:
>
> > (moving this to a new thread)
> >
> > Hi,
> >
> > I did a very small refactoring in Lexer just to realize that the
> isXXX(int)
> > methods (like boolean isDelimiter(int c)) really belong to CSVFormat
> rather
> > than to the Lexe
I think I've fixed most of the issues.
I'm not entirely sure that FF, TAB and BACKSPACE should be handled the same
way as CR and LF.
The latter are special because they are EOL characters; as far as I can
tell the former don't need to be escaped, so they should not be treated
specially when unesca
2013/5/6
> Author: sebb
> Date: Mon May 6 14:09:05 2013
> New Revision: 1479574
>
> URL: http://svn.apache.org/r1479574
> Log:
> Fix up internal raw types
>
Keep in mind, that this will make applying patches created before
generification harder.
>
> Modified:
>
> commons/proper/beanutils/trun
It's ok by me, but you should create a JIRA for it so the new feature
can be tracked.
Gary
On May 6, 2013, at 8:00, Damjan Jovanovic wrote:
> Hi
>
> I've been hacking on a patch that adds support for reading 7zip archives.
> Can I go ahead and commit it, or would you like to review it first?
>
Hi
I've been hacking on a patch that adds support for reading 7zip archives.
Can I go ahead and commit it, or would you like to review it first?
Regards
Damjan
GitHub user fanxu123 opened a pull request:
https://github.com/apache/commons-lang/pull/5
Fix a Octal bug.
For escaped strings like "x\0365x", only "\036" is the octal number, but in
the original codes, it consides "\0365" (5 added) as the octal number, and
invoke a NumberFormatExc
21 matches
Mail list logo
