Re: [LANG] Save to remove @SuppressWarnings("null") from StrBuilder?

2013-05-02 Thread Benedikt Ritter
2013/5/2 sebb > On 2 May 2013 17:49, Benedikt Ritter wrote: > > > Hi, > > > > my Eclipse tells me that the suppression on > > > >public StrBuilder insert(final int index, String str) > > > > can be removed. > > > My Eclipse warns me that str can be null at 1501: str.getChars(), so it may > b

Re: svn commit: r1478621 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVLexer.java main/java/org/apache/commons/csv/Lexer.java test/java/org/apache/commons/csv/CSVLexerTest.ja

2013-05-02 Thread Benedikt Ritter
2013/5/3 > Author: sebb > Date: Fri May 3 01:10:34 2013 > New Revision: 1478621 > > URL: http://svn.apache.org/r1478621 > Log: > CSV-58 Unescape handling needs rethinking > Fixed up most issues. > TODO should TAB, FF and BACKSPACE be un/escaped? > Thanks for taking care of this sebb. > > Modi

Re: svn commit: r1478655 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java

2013-05-02 Thread Benedikt Ritter
The format field in Lexer is now only used by CSVLexer1 in the test directory. It may therefore be removed. I wonder if the isXXX methods really belong to CSVFormat. WDYT? Benedikt 2013/5/3 > Author: britter > Date: Fri May 3 06:37:58 2013 > New Revision: 1478655 > > URL: http://svn.apache.o

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread Benedikt Ritter
2013/5/2 Gary Gregory > (top-posting cause it's getting hard to find stuff) > > >Should CSV unconditionally recognise \r \n etc as CR LF? > >If so, then they don't need a ! escape beforehand. > > There is ONE escape character, so if it is '!', then "\r " is just "\r". > If we want >1 escape cha

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread Gary Gregory
(top-posting cause it's getting hard to find stuff) >Should CSV unconditionally recognise \r \n etc as CR LF? >If so, then they don't need a ! escape beforehand. There is ONE escape character, so if it is '!', then "\r " is just "\r". If we want >1 escape character, then that's a different story

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-02 Thread Gary Gregory
On Thu, May 2, 2013 at 4:05 PM, Jörg Schaible wrote: > Gary Gregory wrote: > > > I say +1 > > > > BUT... > > In the MANIFEST.MF, these look good: > > > > Implementation-Vendor: The Apache Software Foundation > > Implementation-Vendor-Id: org.apache > > Bundle-SymbolicName: org.apache.commons.logg

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread sebb
On 2 May 2013 18:26, Benedikt Ritter wrote: > 2013/5/2 sebb > > > On 2 May 2013 14:56, sebb wrote: > > > > > On 2 May 2013 09:48, Benedikt Ritter wrote: > > > > > >> 2013/5/1 sebb > > >> > > >> > On 1 May 2013 08:53, Benedikt Ritter wrote: > > >> > > > >> > > Hi, > > >> > > > > >> > > I have

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-02 Thread Jörg Schaible
Gary Gregory wrote: > I say +1 > > BUT... > In the MANIFEST.MF, these look good: > > Implementation-Vendor: The Apache Software Foundation > Implementation-Vendor-Id: org.apache > Bundle-SymbolicName: org.apache.commons.logging > Specification-Vendor: The Apache Software Foundation > Bundle-Vend

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-02 Thread Emmanuel Bourg
Thank you for managing this release Thomas. The build.xml file still contains "1.1.2-SNAPSHOT" Emmanuel Bourg Le 02/05/2013 20:43, Thomas Neidhart a écrit : > Hi, > > I'd like to call a vote for releasing Commons Logging 1.1.3 based on RC1. > > This release candidate has the following changes

Re: [LANG] Save to remove @SuppressWarnings("null") from StrBuilder?

2013-05-02 Thread sebb
On 2 May 2013 17:49, Benedikt Ritter wrote: > Hi, > > my Eclipse tells me that the suppression on > >public StrBuilder insert(final int index, String str) > > can be removed. My Eclipse warns me that str can be null at 1501: str.getChars(), so it may be how Eclipse is configured. Looking a

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-02 Thread Gary Gregory
I say +1 BUT... In the MANIFEST.MF, these look good: Implementation-Vendor: The Apache Software Foundation Implementation-Vendor-Id: org.apache Bundle-SymbolicName: org.apache.commons.logging Specification-Vendor: The Apache Software Foundation Bundle-Vendor: The Apache Software Foundation BUT I

[VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-02 Thread Thomas Neidhart
Hi, I'd like to call a vote for releasing Commons Logging 1.1.3 based on RC1. This release candidate has the following changes compared to 1.1.2: * Change Bundle-SymbolicName in the manifest to "org.apache.commons.logging" The files: The artifacts are deployed to Nexus: https://repository.

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread Benedikt Ritter
2013/5/2 sebb > On 2 May 2013 14:56, sebb wrote: > > > On 2 May 2013 09:48, Benedikt Ritter wrote: > > > >> 2013/5/1 sebb > >> > >> > On 1 May 2013 08:53, Benedikt Ritter wrote: > >> > > >> > > Hi, > >> > > > >> > > I have tried to solve CSV-58 - Escape handling needs rethinking [1] > a > >>

[LANG] Save to remove @SuppressWarnings("null") from StrBuilder?

2013-05-02 Thread Benedikt Ritter
Hi, my Eclipse tells me that the suppression on public StrBuilder insert(final int index, String str) can be removed. Looking at the code I tend to agree. Is anyone aware of a reason why this suppression should stay? Benedikt

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread sebb
On 2 May 2013 14:56, sebb wrote: > On 2 May 2013 09:48, Benedikt Ritter wrote: > >> 2013/5/1 sebb >> >> > On 1 May 2013 08:53, Benedikt Ritter wrote: >> > >> > > Hi, >> > > >> > > I have tried to solve CSV-58 - Escape handling needs rethinking [1] a >> few >> > > times over the past weeks now.

Re: [beanutils] Bad performance of MethodUtils#getMatchingAccessibleMethod due to Logger use

2013-05-02 Thread Benedikt Ritter
Hi Carsten, thanks for your report. The usual way to report any kind of bug/enhancement is to file an issue in Jira [1]. If you attach your proposal as SVN diff file, we can acknowledge your contribution in the contributors section of the components website. [1] https://issues.apache.org/jira 2

[beanutils] Bad performance of MethodUtils#getMatchingAccessibleMethod due to Logger use

2013-05-02 Thread Carsten.Friedrich
I'm currently tracking down performance issues in a highly multi-threaded application which heavily uses BeanUtils (1.8.3). I identified MethodUtils#getMatchingAccessibleMethod as a major problem. Especially its call to Log log = LogFactory.getLog(MethodUtils.class); for each invocati

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread sebb
On 2 May 2013 09:48, Benedikt Ritter wrote: > 2013/5/1 sebb > > > On 1 May 2013 08:53, Benedikt Ritter wrote: > > > > > Hi, > > > > > > I have tried to solve CSV-58 - Escape handling needs rethinking [1] a > few > > > times over the past weeks now. But I can not see a way to get this > > workin

Re: [LANG] Release Manager?

2013-05-02 Thread Benedikt Ritter
Gary, I love your attitude! :-) I'll try to dedicate some cycles to help you with lang. I'm currently looking at the reports. Clirr shows 3 Errors that we should definitely talk about. Benedikt 2013/5/1 Gary Gregory > I just went through the process for Codec so it painfully fresh in my > min

Re: [CSV] CSV-58 is killing me

2013-05-02 Thread Benedikt Ritter
2013/5/1 sebb > On 1 May 2013 08:53, Benedikt Ritter wrote: > > > Hi, > > > > I have tried to solve CSV-58 - Escape handling needs rethinking [1] a few > > times over the past weeks now. But I can not see a way to get this > working. > > There are two problems with our current implementation: >