Re: [Codec] Question about security implication of CODEC-113 issue in tracker

2013-03-24 Thread Gary Gregory
I thik it's up to you to decide what http://findbugs.sourceforge.net/bugDescriptions.html#MS_PKGPROTECT means for your customers. Gary On Sun, Mar 24, 2013 at 5:10 PM, Brian Martin < br...@opensecurityfoundation.org> wrote: > > Apache Commons project; > > Gary, the ticket reporter, indicated I

[Codec] Question about security implication of CODEC-113 issue in tracker

2013-03-24 Thread Brian Martin
Apache Commons project; Gary, the ticket reporter, indicated I should email the list to ask my question. I am not familiar with Java or the Commons project in detail, but was hoping someone could briefly explain this ticket in the context of security: https://issues.apache.org/jira/browse

Re: [VOTE] Release Apache Commons-FIleUpload 1.3 based on RC2

2013-03-24 Thread Gary Gregory
+1. FWIW: I fixed a site nit in trunk to add a hyperlink for an RFC. Non showstoppers: [WARNING] Javadoc Warnings [WARNING] C:\temp\rc\FILEUPLOAD_1_3_RC2\src\main\java\org\apache\commons\fileupload\FileUploadBase.java:1350: warning - Tag @link: can't find SizeLimitExceededException(String, long,

Re: [CSV] Extract interfaces?

2013-03-24 Thread Gary Gregory
On Sat, Mar 23, 2013 at 8:59 AM, Thomas Neidhart wrote: > On 03/23/2013 12:41 PM, Benedikt Ritter wrote: > > Hi, > > > > while looking through the code, I was asking myself why we expose > > implementation classes. Wouldn't it be better to extract interfaces from > > CSVParser, CSVPrinter and CSVR

Re: svn commit: r1460400 - in /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv: CSVParserTest.java CSVPrinterTest.java

2013-03-24 Thread sebb
On 24 March 2013 18:59, Benedikt Ritter wrote: > 2013/3/24 > >> Author: sebb >> Date: Sun Mar 24 15:28:11 2013 >> New Revision: 1460400 >> >> URL: http://svn.apache.org/r1460400 >> Log: >> Close printer (at least for non-Exception cases - these are unit tests) >> > > Would be nice if we could mov

[continuum] BUILD FAILURE: Apache Commons - Commons Configuration - Group (shared) Maven 2 Build Definition (Java 1.5)

2013-03-24 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=26604&projectId=72 Build statistics: State: Failed Previous State: Ok Started at: Sun 24 Mar 2013 21:20:09 + Finished at: Sun 24 Mar 2013 21:21:45 + Total time: 1m 35s Build Trigger: Schedule Buil

Re: svn commit: r1460400 - in /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv: CSVParserTest.java CSVPrinterTest.java

2013-03-24 Thread Benedikt Ritter
2013/3/24 > Author: sebb > Date: Sun Mar 24 15:28:11 2013 > New Revision: 1460400 > > URL: http://svn.apache.org/r1460400 > Log: > Close printer (at least for non-Exception cases - these are unit tests) > Would be nice if we could move this to @After > > Modified: > > commons/proper/csv/trunk/

Re: svn commit: r1460254 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java

2013-03-24 Thread Gary Gregory
On Sun, Mar 24, 2013 at 9:06 AM, Benedikt Ritter wrote: > 2013/3/24 > > > Author: ggregory > > Date: Sun Mar 24 02:02:11 2013 > > New Revision: 1460254 > > > > URL: http://svn.apache.org/r1460254 > > Log: > > Add a toBuilder method to do: > > CSVFormat format = CSVFormat.EXCEL.toBuilder().withHe

Re: svn commit: r1460254 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java

2013-03-24 Thread Gary Gregory
On Sun, Mar 24, 2013 at 8:30 AM, sebb wrote: > On 24 March 2013 02:02, wrote: > > Author: ggregory > > Date: Sun Mar 24 02:02:11 2013 > > New Revision: 1460254 > > > > URL: http://svn.apache.org/r1460254 > > Log: > > Add a toBuilder method to do: > > CSVFormat format = CSVFormat.EXCEL.toBuilder

Re: svn commit: r1460373 - /commons/proper/csv/trunk/pom.xml

2013-03-24 Thread Benedikt Ritter
2013/3/24 Benedikt Ritter > > > > 2013/3/24 Simone Tripodi > >> > Change organization from 'Apache' to 'Apache Software Foundation' >> >> you missed the `The` part, is `The Apache Software Foundation` have a >> look at ${project.name} on the apache parent pom[1] >> > > Ah okay, will have to chan

Re: svn commit: r1460373 - /commons/proper/csv/trunk/pom.xml

2013-03-24 Thread Benedikt Ritter
2013/3/24 Simone Tripodi > > Change organization from 'Apache' to 'Apache Software Foundation' > > you missed the `The` part, is `The Apache Software Foundation` have a > look at ${project.name} on the apache parent pom[1] > Ah okay, will have to change that for [beanutils] also (that's where I

Re: svn commit: r1460373 - /commons/proper/csv/trunk/pom.xml

2013-03-24 Thread Simone Tripodi
>> >> you missed the `The` part, is `The Apache Software Foundation` have a >> look at ${project.name} on the apache parent pom[1] > > Seems to be a general problem with component poms. > I can fix the proper ones shortly. > Thanks! http://people.apache.org/~simonetripodi/ http://simonetripodi.li

Re: svn commit: r1460373 - /commons/proper/csv/trunk/pom.xml

2013-03-24 Thread sebb
On 24 March 2013 13:52, Simone Tripodi wrote: >> Change organization from 'Apache' to 'Apache Software Foundation' > > you missed the `The` part, is `The Apache Software Foundation` have a > look at ${project.name} on the apache parent pom[1] Seems to be a general problem with component poms. I c

Re: svn commit: r1460373 - /commons/proper/csv/trunk/pom.xml

2013-03-24 Thread Simone Tripodi
> Change organization from 'Apache' to 'Apache Software Foundation' you missed the `The` part, is `The Apache Software Foundation` have a look at ${project.name} on the apache parent pom[1] HTH, -Simo [1] http://search.maven.org/#artifactdetails%7Corg.apache%7Capache%7C13%7Cpom http://people.ap

Re: [VOTE] Release Apache Commons-FIleUpload 1.3 based on RC2

2013-03-24 Thread Simone Tripodi
+1 http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Mar 24, 2013 at 2:13 PM, Simone Tripodi wrote: > Hi all, > > I've prepared the RC1 of Apache Commons-FileUpload 1.3 so I am here > to call for a vot

[VOTE] Release Apache Commons-FIleUpload 1.3 based on RC2

2013-03-24 Thread Simone Tripodi
Hi all, I've prepared the RC1 of Apache Commons-FileUpload 1.3 so I am here to call for a vote: Release Notes: http://people.apache.org/builds/commons/fileupload/1.3/RC2/RELEASE-NOTES.txt Tag: https://svn.apache.org/repos/asf/commons/proper/fileupload/tags/FILEUPLOAD_1_3_RC2 Site: http://pe

Re: svn commit: r1460254 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java

2013-03-24 Thread Benedikt Ritter
2013/3/24 > Author: ggregory > Date: Sun Mar 24 02:02:11 2013 > New Revision: 1460254 > > URL: http://svn.apache.org/r1460254 > Log: > Add a toBuilder method to do: > CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", > "Col3").build(); > Instead of: > CSVFormat format = >

Re: svn commit: r1460254 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java

2013-03-24 Thread sebb
On 24 March 2013 02:02, wrote: > Author: ggregory > Date: Sun Mar 24 02:02:11 2013 > New Revision: 1460254 > > URL: http://svn.apache.org/r1460254 > Log: > Add a toBuilder method to do: > CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", > "Col3").build(); > Instead of: >

Re: [CSV] Extract interfaces?

2013-03-24 Thread Simone Tripodi
> > I agree. Interfaces would make sense if you expected to have many different > implementations. > +1 http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ -

Re: [CSV] Extract interfaces?

2013-03-24 Thread Adrian Crum
On 3/23/2013 12:59 PM, Thomas Neidhart wrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser, CSVPrinter and CSVRecord? At least for the CSVRe