Re: svn commit: r1457544 - /commons/proper/dbutils/tags/DBUTILS_2_0_RC1/RELEASE-NOTES.txt

2013-03-17 Thread sebb
On 17 March 2013 19:51, wrote: > Author: wspeirs > Date: Sun Mar 17 19:51:32 2013 > New Revision: 1457544 > > URL: http://svn.apache.org/r1457544 > Log: > - Updated release notes > > > Modified: > commons/proper/dbutils/tags/DBUTILS_2_0_RC1/RELEASE-NOTES.txt Tags must not be modified. > Mod

Re: svn commit: r1457541 - /commons/proper/dbutils/tags/DBUTILS_2_0_RC1/pom.xml

2013-03-17 Thread sebb
On 17 March 2013 19:43, wrote: > Author: wspeirs > Date: Sun Mar 17 19:43:06 2013 > New Revision: 1457541 > > URL: http://svn.apache.org/r1457541 > Log: > - Setting to RC1 > > Modified: > commons/proper/dbutils/tags/DBUTILS_2_0_RC1/pom.xml Tags are supposed to be immutable. If you need to ch

Re: [DBUTILS] [VOTE] Release commons-dbutils 2.0 based on RC1

2013-03-17 Thread sebb
On 17 March 2013 20:02, Bill Speirs wrote: > I have worked on some significant enhancements to commons-dbutils, so I > would like to release 2.0. > > *Note: This is backwards incompatible change with the 1.x versions. As such > I've changed the maven > coordinates and package names. > > dbutils RC

Re: [Bag] random pick

2013-03-17 Thread Othmen Tiliouine
yes with auxiliary array it is a good solution too

[DBUTILS] [VOTE] Release commons-dbutils 2.0 based on RC1

2013-03-17 Thread Bill Speirs
I have worked on some significant enhancements to commons-dbutils, so I would like to release 2.0. *Note: This is backwards incompatible change with the 1.x versions. As such I've changed the maven coordinates and package names. dbutils RC1 is available for review here: http://people.apache.org/~

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-17 Thread Phil Steitz
On 3/17/13 7:05 AM, sebb wrote: > I temporarily changed the (shared) build definition to use Build Fresh > rather than SCM update and triggered a build. > > I've reverted to change to the build definition. Thanks! Looks like that worked. Phil > > Continuum ought to have an easier way to do this

Re: [Bag] random pick

2013-03-17 Thread Othmen Tiliouine
2013/3/17 Ted Dunning > Finally, the names should not consist of combinations of "pick" and > "remit". The correct English terms are "sample" and "replacement". > I suspected that the name was not good, it is because my English is poor also, it was perhaps unnecessary to consider two methods 'p

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-17 Thread sebb
I temporarily changed the (shared) build definition to use Build Fresh rather than SCM update and triggered a build. I've reverted to change to the build definition. Continuum ought to have an easier way to do this ... On 17 March 2013 13:37, Luc Maisonobe wrote: > Hi all, > > Le 17/03/2013 14:

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-17 Thread Luc Maisonobe
Hi all, Le 17/03/2013 14:20, Continuum@vmbuild a écrit : > Group (shared) Maven 2 Build Definition (Java 1.5) > MIME-Version: 1.0 > Content-Type: text/plain; charset=us-ascii > Content-Transfer-Encoding: 7bit > X-Continuum-Build-Host: vmbuild > X-Continuum-Project-Id: 97 > X-Continuum-Pr

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 17 March 2013 13:18, Simone Tripodi wrote: >>> /** >>> + * the decoding table size. >>> + */ >>> +private static final int DECODING_TABLE_SIZE = 256; >>> + >> >> The Javadoc does not say why the value 256 is used, so the number is >> still a magic number ... >> > > What should

Re: svn commit: r1456645 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread Simone Tripodi
>> checkstyle: Variable 'encodingTable' must be private and have accessor >> methods > > Log comment does not agree with the change below. OUCH! http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ ---

[continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-17 Thread Continuum@vmbuild
Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 97 X-Continuum-Project-Name: Commons Math Online report : http://vmbuild.apache.org/con

Re: svn commit: r1456857 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread Simone Tripodi
>> /** >> + * The default number of byte shift for decode. >> + */ >> +private static final int OUT_SHIFT = 4; >> + > > The Javadoc needs to say why the value 4 is used, otherwise it's still > a magic number. > it is even part of black magic if you take in consideration that is it

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread Simone Tripodi
>> /** >> + * the decoding table size. >> + */ >> +private static final int DECODING_TABLE_SIZE = 256; >> + > > The Javadoc does not say why the value 256 is used, so the number is > still a magic number ... > What should be added more than `the decoding table size` in javadoc? I'

Re: [Chain] Any future plans for commons-chain?

2013-03-17 Thread Simone Tripodi
Hi Bene, >> I have to dig in the ML to find the discussion, anyway IIRC the >> CatalogFactory has been designed to be integrated in the XML/textual >> configuration, mixing a lot of pattern - not in the best way. >> With new Configuration design, we thought delegating the config >> implementation

Re: [Chain] Any future plans for commons-chain?

2013-03-17 Thread Benedikt Ritter
Hi Simo, Send from my mobile device Am 17.03.2013 um 11:05 schrieb Simone Tripodi : > Hi Steve! > > I have to dig in the ML to find the discussion, anyway IIRC the > CatalogFactory has been designed to be integrated in the XML/textual > configuration, mixing a lot of pattern - not in the best w

Re: svn commit: r1457387 - /commons/cms-site/trunk/content/xdoc/releases/prepare.xml

2013-03-17 Thread sebb
On 17 March 2013 06:51, wrote: > Author: bodewig > Date: Sun Mar 17 06:51:22 2013 > New Revision: 1457387 > > URL: http://svn.apache.org/r1457387 > Log: > xdocs doesn't know a subsubsection > > Modified: > commons/cms-site/trunk/content/xdoc/releases/prepare.xml > > Modified: commons/cms-site

Re: svn commit: r1456804 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/MimeUtility.java

2013-03-17 Thread sebb
On 15 March 2013 08:47, wrote: > Author: simonetripodi > Date: Fri Mar 15 08:47:53 2013 > New Revision: 1456804 > > URL: http://svn.apache.org/r1456804 > Log: > checkstyle: Expected @throws tag > > Modified: > > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util

Re: svn commit: r1456645 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 14 March 2013 20:15, wrote: > Author: simonetripodi > Date: Thu Mar 14 20:15:35 2013 > New Revision: 1456645 > > URL: http://svn.apache.org/r1456645 > Log: > checkstyle: Variable 'encodingTable' must be private and have accessor methods Log comment does not agree with the change below. > Mod

Re: svn commit: r1456852 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread sebb
See other comments on magic number fixes. I don't think these changes achieve anything apart from keeping Checkstyle happy. IMO the number is still magic (unexplained) when it is turned into a constant, and it seems stilly to have a constant that is only used once. On 15 March 2013 10:02, wrote

Re: svn commit: r1456857 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread sebb
On 15 March 2013 10:11, wrote: > Author: simonetripodi > Date: Fri Mar 15 10:11:09 2013 > New Revision: 1456857 > > URL: http://svn.apache.org/r1456857 > Log: > checkstyle: '4' is a magic number. > > Modified: > > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ut

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 15 March 2013 10:37, wrote: > Author: simonetripodi > Date: Fri Mar 15 10:37:01 2013 > New Revision: 1456871 > > URL: http://svn.apache.org/r1456871 > Log: > checkstyle: '256' is a magic number. > > Modified: > > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/

[Commons Wiki] Trivial Update of "JocelynBx" by JocelynBx

2013-03-17 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "JocelynBx" page has been changed by JocelynBx: http://wiki.apache.org/commons/JocelynBx New page: My name: Jocelyn Penn<> My age: 20<> Country: Switzerland<> Town: Mauensee <> ZIP

Re: [Chain] Any future plans for commons-chain?

2013-03-17 Thread Simone Tripodi
Hi Steve! I have to dig in the ML to find the discussion, anyway IIRC the CatalogFactory has been designed to be integrated in the XML/textual configuration, mixing a lot of pattern - not in the best way. With new Configuration design, we thought delegating the config implementation to resolve com

Re: [Bag] random pick

2013-03-17 Thread Thomas Neidhart
On 03/17/2013 03:02 AM, Ted Dunning wrote: > I think that this implementation is a problem. > > Bag implementations tend to fall into different categories, according to > whether they provide unit (or log) time random access, random deletion and > ordered traversal. Most implementations don't pro