[continuum] BUILD FAILURE: Apache Commons - Commons Logging -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 96 X-Continuum-Project-Name: Commons Logging Online report : http://vmbuild.apache.org/

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Logging -

On 13/03/2013 21:45, Thomas Neidhart wrote: > On 03/13/2013 10:20 PM, Continuum@vmbuild wrote: >> Group (shared) Maven 2 Build Definition (Java 1.5) >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=us-ascii >> Content-Transfer-Encoding: 7bit >> X-Continuum-Build-Host: vmbuild >>

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Logging -

On 03/13/2013 10:20 PM, Continuum@vmbuild wrote: > Group (shared) Maven 2 Build Definition (Java 1.5) > MIME-Version: 1.0 > Content-Type: text/plain; charset=us-ascii > Content-Transfer-Encoding: 7bit > X-Continuum-Build-Host: vmbuild > X-Continuum-Project-Id: 96 > X-Continuum-Project-Nam

[continuum] BUILD FAILURE: Apache Commons - Commons Logging -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 96 X-Continuum-Project-Name: Commons Logging Online report : http://vmbuild.apache.org/

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

On 03/08/2013 11:34 PM, sebb wrote: > On 8 March 2013 20:28, sebb wrote: >> On 8 March 2013 07:31, Thomas Neidhart wrote: >>> On 03/08/2013 01:25 AM, sebb wrote: On 7 March 2013 18:49, Thomas Neidhart wrote: > On 03/05/2013 11:08 PM, Thomas Neidhart wrote: >> Hi, >> >> I'd l

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

Hallo Jörg! > Looks fine from a compatibility view. I wonder if we should add a comment in > the javadoc that the new interface is just there for backward compatibility > and it might vanish for a refactored 2.x version moving the new method into > RequestContext again. sounds reasonable, I am go

Re: [Chain] Any future plans for commons-chain?

Hi Steve, very nice to hear there is someone willing to put new energies on Chain! :) So, the latest step IMHO before to cut the first chain RC, is CHAIN-76[1] where some work has already been done but far to be completed. If you want to give a help here, there's enough space to get involved - I

Re: [Bag] random pick

I remplaced the patch 2013/3/13 Ted Dunning > You seem to have reformatted the entire file. This makes it nearly > impossible to review your suggested change. > > Can you make a diff that doesn't involve changing every line in the file? > > On Tue, Mar 12, 2013 at 3:48 PM, Othmen Tiliouine < >

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Le 13/03/2013 16:46, Simone Tripodi a écrit : > Hi again Luc/all, > > I just realised that our fellows of Apache Geronimo ship an ALv2.0 > version of javax.mail[1] - there should be any kind of issue on > importing and adapting their source code, right? Sure. It's much better this way. Luc > >

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

Hi Simo, Simone Tripodi wrote: > Hi again Jörg! > I just included that modification on r1455855, may I can kindly ask > you for a review? Looks fine from a compatibility view. I wonder if we should add a comment in the javadoc that the new interface is just there for backward compatibility and

Re: [VOTE] Release Compress 1.5 based on RC1

+1, builds fine from source and tests run with all my Java runtime environments. Stefan Bodewig wrote: > Hi all, > > [took me a few days longer since I wanted to incorporate fixes for the > two issues that popped up last week. So here we go.] > > With 30 JIRA issues fixed it is about time to

[Chain] Any future plans for commons-chain?

I wanted to get a sense of what (if anything) is planned for commons-chain. I used this in some years ago, and for various reasons I now find myself returning to it. In examining the SVN trunk things have not stood still: - Discussions (and subsequent work) in 2011 to accommodate work as a precurs

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Hi again Luc/all, I just realised that our fellows of Apache Geronimo ship an ALv2.0 version of javax.mail[1] - there should be any kind of issue on importing and adapting their source code, right? TIA! -Simo [1] http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-javamail_1.4_spec-1.4

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o

Re: [ALL] DOAP file placement - move out of trunk?

Hi, Seb > > But Onami does not appear in projects.apache.org! > > I could not find the Onami DOAP - where is it? > each Onami's component website's page has a element which points to its related DOAP, i.e. * the main site points to the parent doap: http://

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

> > Indeed. > > > Although this document specifies the requirements for the generation of > HTTP/1.1 messages, not all applications will be correct in their > implementation. We therefore recommend that operational applications be > tolerant of deviations whenever those deviations can be interpret

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

A -1 on a code modification proposal (in this case the code was already changed, but i think it still applies) is called a veto by the ASF. If accompanied by a valid technical justification, it stands (unless the person can be talked out of it). http://www.apache.org/foundation/voting.html On

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

Hi All: It seems to me that we are misusing the term veto. A release cannot be vetoes, it can be VOTEd on with a -1, which is not a veto, but is usually interpreted as one, by me, at least, as a courtesy to my fellow PMD member for putting the time in to care. You can -1 a commit which is not rea

[continuum] BUILD FAILURE: Apache Commons - Commons Parent -

CP cannot use -Prelease MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 131 X-Continuum-Project-Name: Commons Parent Online report : http://vmbuild.apache.org/continuum/buildResult.actio

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

On Mar 12, 2013, at 12:36 PM, sebb wrote: > > In which case, vetoing the commit that causes the problem makes more > sense, surely? > Perhaps we should set up a Sonar rule to catch stuff like this to save you the trouble of trolling the SVN commit log messages. The veto was unnecessary. It'

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

On 13/03/2013 09:12, Jörg Schaible wrote: > Hi Simo, > > Simone Tripodi wrote: > >> Hi Felix! >> >>> >>> See RFC-2616 5.1.1 Method. >>> >> >> the paragraph is indeed clear about that: >> >>The Method token indicates the method to be performed on the >>resource identified by the Request-U

Re: [fileupload] please help on reviewing FILEUPLOAD-199

On 13/03/2013 08:30, Jörg Schaible wrote: > Hi Simo, > > Simone Tripodi wrote: > >> Hi Felix! >> >>> While it looks like the new packages are not exported (which is good), I >>> now get an import on javax.mail.internet. I don't think this makes sense. >>> >> >> the javax.mail.internet import is a

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o

Re: [continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

> The Maven Shade Plugin apparently requires Maven 3.0. > Perhaps switch to a different version that is less demanding? I am looking for an alternative solution for including a Mime decoder, in order to not ship the java.mail one - do you have any suggestion? TIA! -Simo http://people.apache.org/

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

Hi again Jörg! I just included that modification on r1455855, may I can kindly ask you for a review? Many thanks in advance, alles gute! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Mar 13, 20

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

Hallo Jörg, > Follow the RFC. will do, I am updating FILEUPLOAD-229 then will provide the fix. Alles Gute! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Mar 13, 2013 at 10:12 AM, Jörg Schaib

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

Hallo Jörg, > > class RequestContext { > // [snip] > @Deprecated // since 1.3 > int getContentLength(); > } > > // @since 1.3 > class RequestContextExt extends RequestContext { > // @since 1.3 > long contentLength(); > } > should work like a charm, it will require a little more work to propagate

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Guten Morgen Jörg! > Why do we have to shade here anything at all? fileupload is meant to run in > a JEE environment and javax.mail is then provided. I see your point, thanks! The reason why I thought shading those 2 classes was a good ideas is because today users are able to use FileUpload even

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

Hi Simo, Simone Tripodi wrote: > Hi Felix! > >> >> See RFC-2616 5.1.1 Method. >> > > the paragraph is indeed clear about that: > >The Method token indicates the method to be performed on the >resource identified by the Request-URI. The method is case-sensitive. > >Method

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

Hi Felix! > > See RFC-2616 5.1.1 Method. > the paragraph is indeed clear about that: The Method token indicates the method to be performed on the resource identified by the Request-URI. The method is case-sensitive. Method = "OPTIONS"; Section 9.2

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

Hi Simo, Simone Tripodi wrote: >> Adding a new method to the public RequestContext interface also creates >> an Clirr error, as classes implementing this interface are required to >> implement this method. > > yup I know it, but the alternative of suppressing this breakage is > pushing back FILE

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Hi Simo, Simone Tripodi wrote: > Hi Felix! > >> While it looks like the new packages are not exported (which is good), I >> now get an import on javax.mail.internet. I don't think this makes sense. >> > > the javax.mail.internet import is at source level only, once the > shade-plugin has done i

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Salut Luc! thanks a lot for supervising, much more than appreciated! :) > > This should not be done in the LICENSE file but in the NOTICE file. > I think we already discussed it in the past and, while it is true that notes in NOTICE are missing, it is also true that redistributing 3rd parties re

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

Actually: The method is in fact case-sensitive and must be POST in uppercase. See RFC-2616 5.1.1 Method. So IMHO there is no need for equalsIgnoreCase or toLowerCase at all and "POST".equals(...) should just do it. Regards Felix Am 13.03.2013 um 08:51 schrieb Simone Tripodi: >> It would be sa

Re: [fileupload] please help on reviewing FILEUPLOAD-199

Hi Felix! > While it looks like the new packages are not exported (which is good), I now > get an import on javax.mail.internet. I don't think this makes sense. > the javax.mail.internet import is at source level only, once the shade-plugin has done its job, the import becomes o.a.c.fileupload.u

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

> It would be safer to use equalsIgnoreCase(), for two reasons: > - POST_METHOD case is then irrelevant (methods are usually shown as uppercase) > - toLowerCase() is Locale-dependent. +1 and it would be even faster in therms of complexity - I already voted to the issue you filled, are you going to

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

> Adding a new method to the public RequestContext interface also creates > an Clirr error, as classes implementing this interface are required to > implement this method. yup I know it, but the alternative of suppressing this breakage is pushing back FILEUPLOAD-188 and FILEUPLOAD-195. Do you have

Re: svn commit: r1455731 - /commons/proper/fileupload/trunk/src/changes/changes.xml

> I think 212 can be resolved, for 202 I want to make a few more tests, > but did not have enough time yesterday. good thanks a lot, I am takiing care of JIRA if you haven't done already in the meanwhile :P all the best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejour

Re: svn commit: r1455731 - /commons/proper/fileupload/trunk/src/changes/changes.xml

On 03/13/2013 08:21 AM, Simone Tripodi wrote: > Hi Thomas! > thanks a lot for taking care of them, much more than appreciated! > >> + >> +Exceptions resulting from upload size limitations (fileSizeMax, >> sizeMax) >> +are now correctly propagated to the caller (these could b

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

On 03/09/2013 02:32 PM, Simone Tripodi wrote: > Hi all, > > I've prepared the RC1 of Apache Commons-FileUpload 1.3 so I am here > to call for a vote: > > Release Notes: > > http://people.apache.org/builds/commons/fileupload/1.3/RC1/RELEASE-NOTES.txt > > Tag: > > https://svn.apache.org/repos/a

Re: svn commit: r1455731 - /commons/proper/fileupload/trunk/src/changes/changes.xml

Hi Thomas! thanks a lot for taking care of them, much more than appreciated! > + > +Exceptions resulting from upload size limitations (fileSizeMax, > sizeMax) > +are now correctly propagated to the caller (these could be > encountered > +formerly as MalformedStreamE

[continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 81 X-Continuum-Project-Name: Commons FileUpload Online report : http://vmbuild.apache.o