Re: [OGNL] God Class

2011-05-17 Thread Simone Tripodi
Hi Murizio, it is indeed hard sometimes manage some classes, but take also in consideration that some of them - like the OgnlParser - are generated by JavaCC and should not versioned in the SCM at all, there's an open issue about it (OGNL-) My suggestion would be: let's make first the current OGNL

Re: CollectionUtils class has a BUG in commons-collections-3.2.1-src.‏

2011-05-17 Thread Henri Yandell
4.0 isn't looking like it'll be released anytime soon. Maybe the pre-4.0 branch should be taken and a 3.3 released; this is the gazillionth (okay, 4th?) time this one has been reported. Hen On Tue, May 17, 2011 at 5:10 PM, Gary Gregory wrote: > That looks like a bug that was fixed in trunk and

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2011-05-17 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2011-05-17 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

Re: [pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken

2011-05-17 Thread Phil Steitz
I have fixed this locally and will commit. The problem was that the tests share a protected pool field that is but that test needs . That must have caused compilation failure so the pool variable was redeclared locally instead of just set. In any case, I have fixed it and will commit once I

Re: [pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken

2011-05-17 Thread sebb
On 17 May 2011 21:49, Phil Steitz wrote: > The generics changes made this test no longer test with the expected > pool config.  The runTestThreads method uses the protected pool > field and the pool set up in the test was changed to a local > variable in the generics changes. Not sure that was a

Re: [OGNL] God Class

2011-05-17 Thread sebb
On 18 May 2011 00:17, Stephen Williams wrote: > The opposite, ravioli classes or when it goes very badly: "class diarrhea" > (my term, see below), can be worse.  When breaking down a business > application, giant objects are usually a problem and something to avoid. >  When A) solving a complex an

Re: CollectionUtils class has a BUG in commons-collections-3.2.1-src.‏

2011-05-17 Thread Gary Gregory
That looks like a bug that was fixed in trunk and reported here: https://issues.apache.org/jira/browse/COLLECTIONS-357 Gary On Tue, May 17, 2011 at 12:25 AM, 林蒋 wrote: > Hi, > I have read the common collection 3.2.1 source code, in the > CollectionUtils class, the removeAll method incorrect i

Re: [OGNL] God Class

2011-05-17 Thread Stephen Williams
The opposite, ravioli classes or when it goes very badly: "class diarrhea" (my term, see below), can be worse. When breaking down a business application, giant objects are usually a problem and something to avoid. When A) solving a complex and tightly integrated problem that should be used as s

Re: [math] [sandbox] merging Apache Commons BSP into Apache Commons Math

2011-05-17 Thread Gilles Sadowski
> [...] > The current layout in [math] is one o.a.c.math.geometry package with > 6 3D specif classes. The current layout in [bsp] is one > o.a.c.bsp.partitioning package that is dimension-independent, one > o.a.c.bsp.utility package, three dimension-specific euclidean > packages o.a.c.bsp.euclidean

[OGNL] God Class

2011-05-17 Thread Maurizio Cucchiara
if there is something I hate in programming is the god class [1]. OGNL seems to embrace god object's cause pretty well. -- find -size +30k -name "*.java"| xargs -i sh -c "wc -l {}" |

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Simone Tripodi
+1!!! :) http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Tue, May 17, 2011 at 11:36 PM, Henri Yandell wrote: > Looks useful to me. > > Download the ant task. Use this standard file. Execute. > > Save us maintaining a pointless build.xml. > > Hen > > On Tue, May 17, 2011 at 1

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Henri Yandell
Looks useful to me. Download the ant task. Use this standard file. Execute. Save us maintaining a pointless build.xml. Hen On Tue, May 17, 2011 at 10:07 AM, Olivier Lamy wrote: > Hello, > At least for dependency resolution you can use [1]. > But is it useful ? > > /Olivier > [1] http://maven.a

[pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken

2011-05-17 Thread Phil Steitz
The generics changes made this test no longer test with the expected pool config. The runTestThreads method uses the protected pool field and the pool set up in the test was changed to a local variable in the generics changes. Phil ---

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Jörg Schaible
Henri Yandell wrote: > On Tue, May 17, 2011 at 8:17 AM, Jörg Schaible > wrote: >> Henri Yandell wrote: >> >>> Generally that it's fine to drop the build and focus on the m2 build, >>> but if someone is willing to step up and support a different build >>> then that is fine too. >>> >>> I think the

Re: [math] [GUMP@vmgump]: Project commons-math (in module apache-commons) failed

2011-05-17 Thread Phil Steitz
On 5/17/11 1:22 AM, luc.maison...@free.fr wrote: > - "Phil Steitz" a écrit : > >> On 5/16/11 3:47 PM, Gilles Sadowski wrote: >>> On Mon, May 16, 2011 at 02:39:01PM -0700, Phil Steitz wrote: On 5/16/11 3:44 AM, Dr. Dietmar Wolz wrote: > Nikolaus Hansen, Luc and me discussed this issue

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Simone Tripodi
Hi Antonio, don't worry and thanks for your feedback!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Tue, May 17, 2011 at 9:00 PM, Antonio Petrelli wrote: > 2011/5/17 Simone Tripodi > >> WDYT on dropping old opensymphony ant related build stuff? I think >> maintaini

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Antonio Petrelli
2011/5/17 Simone Tripodi > WDYT on dropping old opensymphony ant related build stuff? I think > maintaining the maven stuff only is more than enough, or not? > I don't think that minor-task worths an Iusse, just discuss about it here. > Hi Absolutely, kill Ant stuff, we don't need it and we can

Re: [codec] submitting a StringEncoder

2011-05-17 Thread Gary Gregory
Also, you should probably create one ticket for each encoder, one of BM, one for DM. Thank you, Gary On Mon, May 16, 2011 at 11:49 AM, Gary Gregory wrote: > Hi Matthiew, > > If I've not already mentioned this, make sure you get good coverage for the > code to be included. You can see the code co

CollectionUtils class has a BUG in commons-collections-3.2.1-src.‏

2011-05-17 Thread 林蒋
Hi, I have read the common collection 3.2.1 source code, in the CollectionUtils class, the removeAll method incorrect invoked the ListUtils.retainAll method, I think the CollectionUtils's removeAll method should invoke ListUtils.removeAll method. Is this a BUG? Best Regards! Jiang Lin

Re: [VOTE] Revised dormancy policy

2011-05-17 Thread Gary Gregory
On May 17, 2011, at 11:59, Phil Steitz wrote: > On 5/17/11 2:27 AM, Emmanuel Bourg wrote: >> What is the goal of this policy? Is it meant to lure users away >> from the component because it's obsolete or seriously broken? Is >> it an attempt to get new developers interested in maintaining the >>

Re: [jci] preparing for jci 1.1 release

2011-05-17 Thread Gary Gregory
On May 17, 2011, at 12:17, "Jörg Schaible" wrote: > Torsten Curdt wrote: > >> Thanks for checking, Christian. >> >>> I have moved my code base from my old version of jci 1.1 to the trunk and >>> everything looks good. I did have trouble building the trunk, because >>> the fam module is not inclu

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Olivier Lamy
Hello, At least for dependency resolution you can use [1]. But is it useful ? /Olivier [1] http://maven.apache.org/ant-tasks/ 2011/5/17 Henri Yandell : > On Tue, May 17, 2011 at 8:17 AM, Jörg Schaible > wrote: >> Henri Yandell wrote: >> >>> Generally that it's fine to drop the build and focus on

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Henri Yandell
On Tue, May 17, 2011 at 8:17 AM, Jörg Schaible wrote: > Henri Yandell wrote: > >> Generally that it's fine to drop the build and focus on the m2 build, >> but if someone is willing to step up and support a different build >> then that is fine too. >> >> I think the solution is an Ant task that can

Re: [jci] preparing for jci 1.1 release

2011-05-17 Thread Christian T Trimble
Torsten, Can improvements to the current code base be rescheduled to 1.2? This project has been without a release for some time and those projects that depend on JCI 1.1 need a release of the current functionality for their own releases. If that is not an option, can we at least get SNAPSHO

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Simone Tripodi
We're using the commons-parent, that has the ant-plugin already set, I'll give a try :) thanks! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Tue, May 17, 2011 at 5:17 PM, Jörg Schaible wrote: > Henri Yandell wrote: > >> Generally that it's fine to drop the build and

Re: [jci] preparing for jci 1.1 release

2011-05-17 Thread Jörg Schaible
Torsten Curdt wrote: > Thanks for checking, Christian. > >> I have moved my code base from my old version of jci 1.1 to the trunk and >> everything looks good. I did have trouble building the trunk, because >> the fam module is not included in the module list. I have opened JCI-66 >> to address

Re: [jci] preparing for jci 1.1 release

2011-05-17 Thread Christian T Trimble
Torsten, I do not need 1.4 compatibility. -Christian On May 13, 2011, at 12:06 AM, Torsten Curdt wrote: > Thanks for checking, Christian. > >> I have moved my code base from my old version of jci 1.1 to the trunk and >> everything looks good. I did have trouble building the trunk, because

Re: [VOTE] Revised dormancy policy

2011-05-17 Thread Phil Steitz
On 5/17/11 2:27 AM, Emmanuel Bourg wrote: > What is the goal of this policy? Is it meant to lure users away > from the component because it's obsolete or seriously broken? Is > it an attempt to get new developers interested in maintaining the > component? Or a mere indication that no support will b

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Jörg Schaible
Henri Yandell wrote: > Generally that it's fine to drop the build and focus on the m2 build, > but if someone is willing to step up and support a different build > then that is fine too. > > I think the solution is an Ant task that can parse pom.xml and provide > basic build/test support :) You

Re: [OGNL] drop old opensymphony build

2011-05-17 Thread Henri Yandell
Generally that it's fine to drop the build and focus on the m2 build, but if someone is willing to step up and support a different build then that is fine too. I think the solution is an Ant task that can parse pom.xml and provide basic build/test support :) Hen On Tue, May 17, 2011 at 6:47 AM,

[OGNL] drop old opensymphony build

2011-05-17 Thread Simone Tripodi
Hi all guys, WDYT on dropping old opensymphony ant related build stuff? I think maintaining the maven stuff only is more than enough, or not? I don't think that minor-task worths an Iusse, just discuss about it here. Have a nice day! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.

Re: [VOTE] Revised dormancy policy

2011-05-17 Thread Emmanuel Bourg
What is the goal of this policy? Is it meant to lure users away from the component because it's obsolete or seriously broken? Is it an attempt to get new developers interested in maintaining the component? Or a mere indication that no support will be provided for this component? - If the compo

Re: [VOTE] Revised dormancy policy

2011-05-17 Thread luc . maisonobe
- "Phil Steitz" a écrit : > On 5/16/11 4:21 PM, sebb wrote: > > On 17 May 2011 00:07, Gary Gregory wrote: > >> On Mon, May 16, 2011 at 5:57 PM, Paul Libbrecht > wrote: > >> > >>> So we should relaunch a vote? > >>> (or... I should vote a no and relaunch?) > >>> > >>> paul > >>> > >>> > >>>

Re: [math] [GUMP@vmgump]: Project commons-math (in module apache-commons) failed

2011-05-17 Thread luc . maisonobe
- "Phil Steitz" a écrit : > On 5/16/11 3:47 PM, Gilles Sadowski wrote: > > On Mon, May 16, 2011 at 02:39:01PM -0700, Phil Steitz wrote: > >> On 5/16/11 3:44 AM, Dr. Dietmar Wolz wrote: > >>> Nikolaus Hansen, Luc and me discussed this issue in Toulouse. > > Reading that, I've been assuming th

Re: [VOTE] Revised dormancy policy

2011-05-17 Thread Simone Tripodi
+1 to Gary's idea and Torsten considerations Have a nice day! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Tue, May 17, 2011 at 8:56 AM, Torsten Curdt wrote: > IMO "domant" is just an indication of a status. If someone goes and > keeps on working stuff ... well ... t