Re: [math] Frequency getUniqueCount

2010-12-06 Thread Ted Dunning
Or you can include the test case in the same patch. That almost guarantees you are far enough up the tree. And using the same name is actually good. Don't bother to delete the old version, just upload with the same name. JIRA will show old versions in greyed out style. On Mon, Dec 6, 2010 at 7:

Re: [math] Frequency getUniqueCount

2010-12-06 Thread sebb
On 7 December 2010 03:10, Patrick Meyer wrote: > OK, I generated the patch file using Eclipse and it seems to have the > information you described. I'm not sure if the revision part is correct > though. The latest patch is named MATH-448.patch and it is now attached to > the JIRA issue, https://is

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Ted Dunning
Looks right to me. Welcome to Apache contributorhood! On Mon, Dec 6, 2010 at 7:10 PM, Patrick Meyer wrote: > OK, I generated the patch file using Eclipse and it seems to have the > information you described. I'm not sure if the revision part is correct > though. The latest patch is named MATH-4

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Patrick Meyer
OK, I generated the patch file using Eclipse and it seems to have the information you described. I'm not sure if the revision part is correct though. The latest patch is named MATH-448.patch and it is now attached to the JIRA issue, https://issues.apache.org/jira/browse/MATH-448. I hope this latest

Re: [math] Storeless covariance

2010-12-06 Thread Phil Steitz
Patrick, Thanks for contributing this. Looks useful and IMO a good addition to [math]. It would speed things up a bit if you added javadoc and a test class. Thanks again for your interest and contribution. Phil On Mon, Dec 6, 2010 at 9:14 AM, Patrick Meyer wrote: > There are now accurate al

Re: svn commit: r1042610 - /commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/linear/RealVector.java

2010-12-06 Thread sebb
On 6 December 2010 22:21, Gilles Sadowski wrote: >> >> > -     * @deprecated in 2.2 (to be removed in 3.0). Please use >> >> > -     * {...@link #map(UnivariateRealFunction)} directly with >> >> > -     * the function classes in package >> >> > -     * {...@link org.apache.commons.math.analysis.fu

Re: svn commit: r1042596 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math: analysis/solvers/ distribution/

2010-12-06 Thread Phil Steitz
On Mon, Dec 6, 2010 at 5:35 PM, Luc Maisonobe wrote: > Hi Gilles, > > Le 06/12/2010 23:27, Gilles Sadowski a écrit : > > Hi. > > > >>> Log: > >>> MATH-452 > >>> Made all static variables (accuracies) "private". > >> > >> > >> We have already started a discussion on a similar point some months ago

Re: svn commit: r1042596 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math: analysis/solvers/ distribution/

2010-12-06 Thread Luc Maisonobe
Hi Gilles, Le 06/12/2010 23:27, Gilles Sadowski a écrit : > Hi. > >>> Log: >>> MATH-452 >>> Made all static variables (accuracies) "private". >> >> >> We have already started a discussion on a similar point some months ago. >> Last message is here: ,

Re: svn commit: r1042596 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math: analysis/solvers/ distribution/

2010-12-06 Thread Gilles Sadowski
Hi. > > Log: > > MATH-452 > > Made all static variables (accuracies) "private". > > > We have already started a discussion on a similar point some months ago. > Last message is here: , > but we did not really conclude. > > To summarize my point from

Re: svn commit: r1042610 - /commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/linear/RealVector.java

2010-12-06 Thread Gilles Sadowski
> >> > -     * @deprecated in 2.2 (to be removed in 3.0). Please use > >> > -     * {...@link #map(UnivariateRealFunction)} directly with > >> > -     * the function classes in package > >> > -     * {...@link org.apache.commons.math.analysis.function}. > >> > +     * @deprecated in 2.2 (to be remo

Re: svn commit: r1042596 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math: analysis/solvers/ distribution/

2010-12-06 Thread Luc Maisonobe
Hi, Le 06/12/2010 12:56, er...@apache.org a écrit : > Author: erans > Date: Mon Dec 6 11:56:26 2010 > New Revision: 1042596 > > URL: http://svn.apache.org/viewvc?rev=1042596&view=rev > Log: > MATH-452 > Made all static variables (accuracies) "private". We have already started a discussion on a

Re: svn commit: r1042610 - /commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/linear/RealVector.java

2010-12-06 Thread sebb
On 6 December 2010 17:17, Gilles Sadowski wrote: >> > @@ -250,10 +250,7 @@ public interface RealVector { >> >      * >> >      * @param d Operator value. >> >      * @return a mapped copy of the vector. >> > -     * @deprecated in 2.2 (to be removed in 3.0). Please use >> > -     * {...@link #map(

Re: [math] Frequency getUniqueCount

2010-12-06 Thread sebb
On 6 December 2010 17:06, Ted Dunning wrote: > Looks right.  I think that the base of the patch is one level too low. The base level of patches should ideally be the top-level of an SVN checkout, in this case commons-math/trunk, or possibly two levels higher. [Some people may check out multiple C

Re: svn commit: r1042610 - /commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/linear/RealVector.java

2010-12-06 Thread Gilles Sadowski
> > @@ -250,10 +250,7 @@ public interface RealVector { > >      * > >      * @param d Operator value. > >      * @return a mapped copy of the vector. > > -     * @deprecated in 2.2 (to be removed in 3.0). Please use > > -     * {...@link #map(UnivariateRealFunction)} directly with > > -     * the f

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Ted Dunning
Looks right. I think that the base of the patch is one level too low. It is also a nice convention to name the patch after the JIRA. Thus your patch would be called MATH-448.patch It is also a nice convention to just upload on top of the previous version. This leaves JIRA with a development hi

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Patrick Meyer
I originally used Netbeans to generate the Diff, then copy and pasted it into Wordpad to save it. I just uploaded a new patch that was created with the Netbeans "Export Diff Patch" function. Is this new file in the correct format? (Please excuse the noob - I'll get the process right eventually.)

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Ted Dunning
How did you create this diff? The normal way is to use svn diff in the project root directory. On Mon, Dec 6, 2010 at 8:29 AM, Patrick Meyer wrote: > OK, I attached a diff file to, > https://issues.apache.org/jira/browse/MATH-448. > However, I am new to subversion and JIRA and I'm not sure I ha

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Patrick Meyer
OK, I attached a diff file to,https://issues.apache.org/jira/browse/MATH-448. However, I am new to subversion and JIRA and I'm not sure I have done this correctly. Please let me know if I have done something wrong. I am happy to volunteer and contribute to the project. I just want to make sure I am

Re: [VOTE] Release Commons VFS 2.0

2010-12-06 Thread Ralph Goers
On Dec 6, 2010, at 7:07 AM, Gary Gregory wrote: > Hi Ralph: > > While the src distro ran the Maven test goal OK for me on Vista + Java 6, I > see that no tests ran (0% success rate) according to > http://people.apache.org/~rgoers/commons-vfs/surefire-report.html > > How can that be? > > VF

Re: [VOTE] Release Commons VFS 2.0

2010-12-06 Thread Gary Gregory
On Dec 6, 2010, at 10:49, "sebb" wrote: > On 6 December 2010 02:04, Ralph Goers wrote: >> This is a vote to release Apache Commons VFS 2.0. >> >> Since the last candidate the package name was changed from vfs to vfs2. Many >> of the Jira issues were reviewed and those that required a possibly

Re: [VOTE] Release Commons VFS 2.0

2010-12-06 Thread sebb
On 6 December 2010 02:04, Ralph Goers wrote: > This is a vote to release Apache Commons VFS 2.0. > > Since the last candidate the package name was changed from vfs to vfs2. Many > of the Jira issues were reviewed and those that required a possibly > incompatible API change were addressed. Most i

Re: [math] Frequency getUniqueCount

2010-12-06 Thread Ted Dunning
If you provide a suggested patch, this will go forward much more quickly than if you wait for a volunteer to appear out of the mists. It is after all a volunteer effort. Go ahead and volunteer! On Mon, Dec 6, 2010 at 6:07 AM, Patrick Meyer wrote: > I have a small feature request for the org.ap

RE: [VOTE] Release Commons VFS 2.0

2010-12-06 Thread Gary Gregory
Hi Ralph: While the src distro ran the Maven test goal OK for me on Vista + Java 6, I see that no tests ran (0% success rate) according to http://people.apache.org/~rgoers/commons-vfs/surefire-report.html How can that be? Gary Gregory Senior Software Engineer Rocket Software 3340 Peachtree Roa

Re: svn commit: r1042610 - /commons/proper/math/branches/MATH_2_X/src/main/java/org/apache/commons/math/linear/RealVector.java

2010-12-06 Thread sebb
On 6 December 2010 12:52, wrote: > Author: erans > Date: Mon Dec  6 12:52:36 2010 > New Revision: 1042610 > > URL: http://svn.apache.org/viewvc?rev=1042610&view=rev > Log: > MATH-453 > Removed Javadoc comment referring to non-existent package. > > Modified: >     > commons/proper/math/branches/MA

[math] Storeless covariance

2010-12-06 Thread Patrick Meyer
There are now accurate algorithms for an incremental, storeless covariance that are extentions of West's algorithm for storeless variance. I submitted the algorithm and technical paper on its derivation in JIRA, https://issues.apache.org/jira/browse/MATH-449. It would be nice to have this added to

[math] Frequency getUniqueCount

2010-12-06 Thread Patrick Meyer
I have a small feature request for the org.apache.commons.math.stat Frequency class. It is often useful to know the unique number of elements in a frequency table. Would you add this feature? I submitted an issue with JIRA with the code needed to make this happen, https://issues.apache.org/jira/bro